Page MenuHomePhabricator

Disallow automatic conversion between disparate hash types
ClosedPublic

Authored by Fabien on Feb 3 2021, 13:42.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC79bd38319de0: Disallow automatic conversion between disparate hash types
Summary
This bases the script/standard hash types, TxDestination-related and
CScriptID on a base template which does not silently convert the
underlying uintN type.

Inspired by and built on #17924. Commits are small and focused to ease
review.

Note some of these changes may be relative to existing bugs of the same
sort as #17924. See particularly "Convert CPubKey to WitnessV0KeyHash
directly" and "Remove an apparently unnecessary conversion".

Backport of core PR17938.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable