Paths

Table of Contentst

Differential D9233

[Cashtab] show active wallet on home
ClosedPublic
Actions

Authored by bytesofman on Feb 16 2021, 14:20.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC5a0f74cdd8b5: [Cashtab] show active wallet on home

Summary

Show "Wallet Name: walletname" on home screen so that user knows which wallet balance is displayed.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Feb 16 2021, 14:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 16 2021, 14:20

bytesofman requested review of this revision.Feb 16 2021, 14:20

Here's what it looks like

image.png (627×461 px, 40 KB)

Harbormaster completed remote builds in B15209: Diff 27709.Feb 16 2021, 14:32

Apply active wallet label in standardized way to all screens

Harbormaster completed remote builds in B15211: Diff 27712.Feb 16 2021, 19:14

Please update the summary to reflect the current diff content

web/cashtab/src/components/Common/WalletLabel.js
5 ↗	(On Diff #27712)	This is not very large when compared to other texts, but this is a pretty important one. Can it be slightly larger and/or bold ?
14 ↗	(On Diff #27712)	The `Wallet:` prefix is not really useful imo, it is obvious enough without it and you get some display room

This revision now requires changes to proceed.Feb 17 2021, 09:21

Bold, bump font size, remove margin bottom, remove unnecessary !important flag

Harbormaster completed remote builds in B15221: Diff 27724.Feb 17 2021, 17:57

Fabien accepted this revision.Feb 17 2021, 19:17

This revision is now accepted and ready to land.Feb 17 2021, 19:17

Closed by commit rABC5a0f74cdd8b5: [Cashtab] show active wallet on home (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyFeb 17 2021, 19:28

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABC5a0f74cdd8b5: [Cashtab] show active wallet on home.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

2 lines

Common/

22 lines

Send/

1 line

Diff 27726

web/cashtab/src/components/App.js

Loading...

web/cashtab/src/components/Common/WalletLabel.js

Loading...

web/cashtab/src/components/Send/Send.js

Loading...