Page MenuHomePhabricator

build: set Unicode true for NSIS installer
ClosedPublic

Authored by Fabien on Mar 11 2021, 15:15.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC5a7d692efc78: build: set Unicode true for NSIS installer
Summary
Now that we are using Focal for gitian builds, and have NSIS 3.0+
available (also in Guix), we can create installers that support unicode.

Unicode is only becoming the default beginning with the 3.07 release,
https://nsis.sourceforge.io/Docs/AppendixF.html#v3.07-cl,
so we need to set this attribute to get support.

Should close: #13817

On Debian 10 the nsis version is 3.04, so we should be able to use the
feature.

Backport of core#21333

Test Plan

Run the windows gitian build twice, ensure it's deterministic.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable