Page MenuHomePhabricator

[avalanche] implement buildRemoteSighash and buildLocalSighash
ClosedPublic

Authored by PiRK on Mar 18 2021, 09:19.

Details

Summary

buildLocalSighash is extracted from sendHello and buildRemoteSighash will be used in D9327 to check the AVAHELLO message sent by a peer.

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Mar 18 2021, 09:19

I just noticed that buildRemoteChallenge is already implemented in the test framework and is called get_sighash: https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/test/functional/test_framework/messages.py$998

Maybe getSigHash is a more descriptive name?

rename "Challenge" -> "Sighash" to keep the c++ and python code consistent

PiRK retitled this revision from [avalanche] implement buildRemoteChallenge and buildLocalChallenge to [avalanche] implement buildRemoteSighash and buildLocalSighash.Mar 19 2021, 13:17
PiRK edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 19 2021, 13:44