Differential D9388

[SECP256K1] Use bit ops instead of int mult for constant-time logic in gej_add_ge
ClosedPublic
Actions

Authored by Fabien on Apr 8 2021, 14:55.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCcda247c5f7da: [SECP256K1] Use bit ops instead of int mult for constant-time logic in…

Summary

Nothing is wrong with the current implementation. But it looks out of
place because we generally prefer bit operations because they're faster
and are more likely constant-time.

Backport of secp256k1#882

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 8 2021, 14:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2021, 14:55

Fabien requested review of this revision.Apr 8 2021, 14:55

teamcity edited the summary of this revision. (Show Details)Apr 8 2021, 14:55

Harbormaster completed remote builds in B15472: Diff 28119.Apr 8 2021, 15:09

majcosta accepted this revision.Apr 8 2021, 16:05

This revision is now accepted and ready to land.Apr 8 2021, 16:05

Closed by commit rABCcda247c5f7da: [SECP256K1] Use bit ops instead of int mult for constant-time logic in… (authored by Tim Ruffing <crypto@timruffing.de>, committed by Fabien). · Explain WhyApr 8 2021, 17:21

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCcda247c5f7da: [SECP256K1] Use bit ops instead of int mult for constant-time logic in….

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

group_impl.h

2 lines

Diff 28124

View Options

src/secp256k1/src/group_impl.h

[SECP256K1] Use bit ops instead of int mult for constant-time logic in gej_add_geClosedPublicActions