Paths

Table of Contentst

Differential D9457

refactor: Drop ::HasWallets()
ClosedPublic
Actions

Authored by PiRK on Apr 28 2021, 20:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd66b0479d499: refactor: Drop ::HasWallets()

Summary

Minor follow-up of core#19250. The global HasWallets() is used only once and at the call site there's already a way to know if any wallet is loaded.

This is a backport of core#19261

Depends on D9456

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 28 2021, 20:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2021, 20:37

PiRK requested review of this revision.Apr 28 2021, 20:37

teamcity edited the summary of this revision. (Show Details)Apr 28 2021, 20:38

Harbormaster completed remote builds in B15598: Diff 28300.Apr 28 2021, 20:59

Fabien accepted this revision.Apr 29 2021, 07:45

This revision is now accepted and ready to land.Apr 29 2021, 07:45

Closed by commit rABCd66b0479d499: refactor: Drop ::HasWallets() (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyApr 29 2021, 11:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd66b0479d499: refactor: Drop ::HasWallets().

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

2 lines

wallet.h

1 line

wallet.cpp

5 lines

Diff 28305

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/wallet.h

View Options

refactor: Drop ::HasWallets()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28305

src/wallet/rpcwallet.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

refactor: Drop ::HasWallets()
ClosedPublic
Actions

Revision Contents
Changeset List