Differential D9740

[LINTER] Enforce mypy >= 0.780
ClosedPublic
Actions

Authored by Fabien on Jul 6 2021, 10:04.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCcff75003c4fc: [LINTER] Enforce mypy >= 0.780

Summary

Found during testing, previous versions are buggy in several ways:

They don't follow dependencies the same and print the issues from other files
They have trouble handling python 3.6 type annotation syntax

Test Plan

Read and try the instructions (tested on Debian 10 and Ubuntu Focal).

arc lint --everything

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 6 2021, 10:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 6 2021, 10:04

Fabien requested review of this revision.Jul 6 2021, 10:04

Harbormaster completed remote builds in B16113: Diff 29072.Jul 6 2021, 10:04

Fabien added a child revision: D9741: [LINTER] Switch to clang-format 10.Jul 6 2021, 10:33

PiRK accepted this revision.Jul 6 2021, 12:26

This revision is now accepted and ready to land.Jul 6 2021, 12:26

Closed by commit rABCcff75003c4fc: [LINTER] Enforce mypy >= 0.780 (authored by Fabien). · Explain WhyJul 6 2021, 12:28

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCcff75003c4fc: [LINTER] Enforce mypy >= 0.780.

Revision Contents
Changeset List

Path

Size

.arclint

1 line

CONTRIBUTING.md

12 lines

contrib/

utils/

install-dependencies.sh

7 lines

Diff 29074

View Options

.arclint

View Options

CONTRIBUTING.md

View Options

contrib/utils/install-dependencies.sh

[LINTER] Enforce mypy >= 0.780ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29074

.arclint

CONTRIBUTING.md

contrib/utils/install-dependencies.sh

[LINTER] Enforce mypy >= 0.780
ClosedPublic
Actions

Revision Contents
Changeset List