functional tests: Remove portseed_offset from test runner
ClosedPublic
Actions

Authored by PiRK on Jul 8 2021, 15:03.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC3ba5cf0a5e6c: functional tests: Remove portseed_offset from test runner

Summary

PR description:

The portseed_offset is no longer needed in the test runner, since we already kill leftover processes

The pseudo-random portseed causes port collisions with other daemons. Core devs had issues with port 11211 (memcached), and we are seeing issues with 21325 (trezord).
This backport is a first step in avoiding random failures, by making the ports more deterministic again.

We cannot use the number of tests as a unique seed for Bitcoin ABC like Core does, because we run tests in parallel, so use the test number instead.

This is a backport of core#13421

Test Plan

for i in {1..4}; do ninja check-functional; done

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 8 2021, 15:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 8 2021, 15:03

PiRK requested review of this revision.Jul 8 2021, 15:03

teamcity edited the summary of this revision. (Show Details)Jul 8 2021, 15:03

Harbormaster completed remote builds in B16140: Diff 29117.Jul 8 2021, 15:13

PiRK retitled this revision from qa: Remove portseed_offset from test runner to functional tests: Remove portseed_offset from test runner.Jul 8 2021, 15:14

majcosta accepted this revision.Jul 8 2021, 15:21

This revision is now accepted and ready to land.Jul 8 2021, 15:21

Closed by commit rABC3ba5cf0a5e6c: functional tests: Remove portseed_offset from test runner (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJul 8 2021, 16:06

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC3ba5cf0a5e6c: functional tests: Remove portseed_offset from test runner.