Page MenuHomePhabricator

[avalanche] Don't protect nodes from peers with low score
AbandonedPublic

Authored by Fabien on Aug 10 2021, 11:08.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Summary

The current behavior is to protect the best node from each avalanche peer. This is not ideal in the case the peer has a low score such that the probability of being selected is very low.

Depends on D9858.

Ref T1634.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_eviction_peer_score
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16296
Build 32459: Build Diffbuild-diff · build-debug · build-clang-tidy · build-without-wallet · build-clang · lint-circular-dependencies
Build 32458: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Aug 10 2021, 11:08
deadalnix requested changes to this revision.Aug 10 2021, 12:51
deadalnix added a subscriber: deadalnix.

I don't think this approach makes sense. Peer score is used to chose the poling frequency, so this metric should show in the node's avalanche score. I think you are trying to optimize something that shouldn't exist here.

This revision now requires changes to proceed.Aug 10 2021, 12:51