cli: extract ParseResult() and ParseError()
ClosedPublic
Actions

Authored by PiRK on Aug 25 2021, 16:21.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC0edee2dcce9d: cli: extract ParseResult() and ParseError()

Summary

and make callable higher up with (nRet == 0) check.

This is a backport of core#19133 [5/10]
https://github.com/bitcoin/bitcoin/pull/19133/commits/ff41a3690066081772b172f3c31a63f5fe6ea7ed

Depends on D9944

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 25 2021, 16:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 25 2021, 16:21

PiRK requested review of this revision.Aug 25 2021, 16:21

teamcity edited the summary of this revision. (Show Details)Aug 25 2021, 16:21

PiRK added a child revision: D9946: cli: create bitcoin-cli -generate command.Aug 25 2021, 16:22

Harbormaster completed remote builds in B16423: Diff 29567.Aug 25 2021, 16:51

majcosta accepted this revision.Aug 26 2021, 07:24

This revision is now accepted and ready to land.Aug 26 2021, 07:24

Closed by commit rABC0edee2dcce9d: cli: extract ParseResult() and ParseError() (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyAug 26 2021, 08:12

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0edee2dcce9d: cli: extract ParseResult() and ParseError().

Revision Contents
Changeset List

Path

Size

src/

bitcoin-cli.cpp

93 lines

Diff 29583

View Options

cli: extract ParseResult() and ParseError()ClosedPublicActions