Differential D774 Diff 2022 doc/developer-notes.md

Changeset View

Standalone View

doc/developer-notes.md

Show First 20 Lines • Show All 489 Lines • ▼ Show 20 Lines	file:

[remote "upstream-pull"]		[remote "upstream-pull"]
fetch = +refs/pull/:refs/remotes/upstream-pull/		fetch = +refs/pull/:refs/remotes/upstream-pull/
url = git@github.com:bitcoin/bitcoin.git		url = git@github.com:bitcoin/bitcoin.git

This will add an `upstream-pull` remote to your git repository, which can be fetched using `git fetch --all`		This will add an `upstream-pull` remote to your git repository, which can be fetched using `git fetch --all`
or `git fetch upstream-pull`. Afterwards, you can use `upstream-pull/NUMBER/head` in arguments to `git show`,		or `git fetch upstream-pull`. Afterwards, you can use `upstream-pull/NUMBER/head` in arguments to `git show`,
`git checkout` and anywhere a commit id would be acceptable to see the changes from pull request NUMBER.		`git checkout` and anywhere a commit id would be acceptable to see the changes from pull request NUMBER.


Committing Changes
--------------------

First, clone the repo from https://reviews.bitcoinabc.org/source/bitcoin-abc/
If you cloned from Github or elsewhere, your upstream origin will be incorrect and you will not be able to push changes.

Then, you'll need Arcanist installed:
```
sudo apt-get install arcanist
```

And setup Arcanist with your reviews.bitcoinabc.org account:
```
arc install-certificate
```

Don't forget to add your SSH key to your account:
https://reviews.bitcoinabc.org/settings/user/<username>/page/ssh/

Now you can submit changes for review:
```
arc diff
```

And push them once they are approved:
```
arc land
```

Additional Arcanist setup information: https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/