Changeset View
Changeset View
Standalone View
Standalone View
CONTRIBUTING.md
Show First 20 Lines • Show All 220 Lines • ▼ Show 20 Lines | |||||
You should add suggested reviewers and a test plan to the commit message. | You should add suggested reviewers and a test plan to the commit message. | ||||
Note that Arcanist is set up to look only at the most-recent commit message, | Note that Arcanist is set up to look only at the most-recent commit message, | ||||
So all you changes for this Diff should be in one Git commit. | So all you changes for this Diff should be in one Git commit. | ||||
- For large changes, break them into several Diffs, as described in this | - For large changes, break them into several Diffs, as described in this | ||||
[guide](https://medium.com/@kurtisnusbaum/stacked-diffs-keeping-phabricator-diffs-small-d9964f4dcfa6). | [guide](https://medium.com/@kurtisnusbaum/stacked-diffs-keeping-phabricator-diffs-small-d9964f4dcfa6). | ||||
You must also include "Depends on Dxxx" in the Arcanist summary to indicate | You must also include "Depends on Dxxx" in the Arcanist summary to indicate | ||||
dependence on other Diffs. Note: the `arc land` procedure described in the | dependence on other Diffs. Note: the `arc land` procedure described in the | ||||
guide above is obsolete. With the most recent version of arcanist, you may | guide above is obsolete. With the most recent version of arcanist, you may | ||||
`arc land` the latest commit of your stacked diff after all parts are approved. | `arc land` the latest commit of your stacked diff after all parts are approved. | ||||
- Log into Phabricator to see review and feedback. | - Log into Phabricator to see review and feedback. | ||||
- Make changes as suggested by the reviewers. You can simply edit the files | - Make changes as suggested by the reviewers. You can simply edit the files | ||||
with my-topic-branch checked out, and then type `arc diff`. Arcanist will | with my-topic-branch checked out, and then type `arc diff`. Arcanist will | ||||
give you the option to add uncommited changes. Or, alternatively, you can | give you the option to add uncommited changes. Or, alternatively, you can | ||||
commit the changes using `git commit -a --am` to add them to the last commit, | commit the changes using `git commit -a --am` to add them to the last commit, | ||||
Show All 40 Lines |