Differential D11669 Diff 34183 src/avalanche/test/peermanager_tests.cpp

Changeset View

Standalone View

src/avalanche/test/peermanager_tests.cpp

// Copyright (c) 2020 The Bitcoin developers		// Copyright (c) 2020 The Bitcoin developers
// Distributed under the MIT software license, see the accompanying		// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.		// file COPYING or http://www.opensource.org/licenses/mit-license.php.

#include <avalanche/delegationbuilder.h>		#include <avalanche/delegationbuilder.h>
#include <avalanche/peermanager.h>		#include <avalanche/peermanager.h>
#include <avalanche/proofbuilder.h>		#include <avalanche/proofbuilder.h>
#include <avalanche/proofcomparator.h>		#include <avalanche/proofcomparator.h>
#include <avalanche/test/util.h>		#include <avalanche/test/util.h>
		#include <config.h>
#include <script/standard.h>		#include <script/standard.h>
#include <util/time.h>		#include <util/time.h>
#include <util/translation.h>		#include <util/translation.h>
#include <validation.h>		#include <validation.h>

#include <test/util/setup_common.h>		#include <test/util/setup_common.h>

#include <boost/test/unit_test.hpp>		#include <boost/test/unit_test.hpp>
▲ Show 20 Lines • Show All 566 Lines • ▼ Show 20 Lines	for (int i = 0; i < 10; i++) {
BOOST_CHECK(!TestPeerManager::isNodePending(pm, i));		BOOST_CHECK(!TestPeerManager::isNodePending(pm, i));
BOOST_CHECK(!TestPeerManager::nodeBelongToPeer(pm, i, peerid));		BOOST_CHECK(!TestPeerManager::nodeBelongToPeer(pm, i, peerid));
BOOST_CHECK_EQUAL(pm.getNodeCount(), 0);		BOOST_CHECK_EQUAL(pm.getNodeCount(), 0);
BOOST_CHECK_EQUAL(pm.getPendingNodeCount(), 10 - i - 1);		BOOST_CHECK_EQUAL(pm.getPendingNodeCount(), 10 - i - 1);
}		}
}		}

BOOST_AUTO_TEST_CASE(node_binding_reorg) {		BOOST_AUTO_TEST_CASE(node_binding_reorg) {
		gArgs.ForceSetArg("-avaproofstakeutxoconfirmations", "2");
avalanche::PeerManager pm;		avalanche::PeerManager pm;

auto key = CKey::MakeCompressedKey();		auto proof = buildRandomProof(MIN_VALID_PROOF_SCORE, 99);

COutPoint utxo = createUtxo(key);

auto proof = buildProofWithOutpoints(key, {utxo}, 10 * COIN);
const ProofId &proofid = proof->getId();		const ProofId &proofid = proof->getId();

PeerId peerid = TestPeerManager::registerAndGetPeerId(pm, proof);		PeerId peerid = TestPeerManager::registerAndGetPeerId(pm, proof);
BOOST_CHECK_NE(peerid, NO_PEER);		BOOST_CHECK_NE(peerid, NO_PEER);
BOOST_CHECK(pm.verify());		BOOST_CHECK(pm.verify());

// Add nodes to our peer		// Add nodes to our peer
for (int i = 0; i < 10; i++) {		for (int i = 0; i < 10; i++) {
BOOST_CHECK(pm.addNode(i, proofid));		BOOST_CHECK(pm.addNode(i, proofid));
BOOST_CHECK(!TestPeerManager::isNodePending(pm, i));		BOOST_CHECK(!TestPeerManager::isNodePending(pm, i));
BOOST_CHECK(TestPeerManager::nodeBelongToPeer(pm, i, peerid));		BOOST_CHECK(TestPeerManager::nodeBelongToPeer(pm, i, peerid));
}		}

// Orphan the proof		// Orphan the proof by reorging to a shorter chain that makes the proof
		// immature
{		{
LOCK(cs_main);		BlockValidationState state;
CCoinsViewCache &coins = ::ChainstateActive().CoinsTip();		::ChainstateActive().InvalidateBlock(GetConfig(), state,
coins.SpendCoin(utxo);		::ChainActive().Tip());
		BOOST_CHECK_EQUAL(::ChainActive().Height(), 99);
}		}

pm.updatedBlockTip();		pm.updatedBlockTip();
BOOST_CHECK(pm.isOrphan(proofid));		BOOST_CHECK(pm.isOrphan(proofid));
BOOST_CHECK(!pm.isBoundToPeer(proofid));		BOOST_CHECK(!pm.isBoundToPeer(proofid));
for (int i = 0; i < 10; i++) {		for (int i = 0; i < 10; i++) {
BOOST_CHECK(TestPeerManager::isNodePending(pm, i));		BOOST_CHECK(TestPeerManager::isNodePending(pm, i));
BOOST_CHECK(!TestPeerManager::nodeBelongToPeer(pm, i, peerid));		BOOST_CHECK(!TestPeerManager::nodeBelongToPeer(pm, i, peerid));
}		}
BOOST_CHECK(pm.verify());		BOOST_CHECK(pm.verify());

// Make the proof great again		// Make the proof great again
addCoin(utxo, key);		{
		// Advance the clock so the newly mined block won't collide with the
		// other deterministically-generated blocks
		SetMockTime(GetTime() + 20);
		mineBlocks(1);
		BlockValidationState state;
		BOOST_CHECK(::ChainstateActive().ActivateBestChain(GetConfig(), state));
		BOOST_CHECK_EQUAL(::ChainActive().Height(), 100);
		}

pm.updatedBlockTip();		pm.updatedBlockTip();
BOOST_CHECK(!pm.isOrphan(proofid));		BOOST_CHECK(!pm.isOrphan(proofid));
BOOST_CHECK(pm.isBoundToPeer(proofid));		BOOST_CHECK(pm.isBoundToPeer(proofid));
// The peerid has certainly been updated		// The peerid has certainly been updated
peerid = TestPeerManager::registerAndGetPeerId(pm, proof);		peerid = TestPeerManager::registerAndGetPeerId(pm, proof);
BOOST_CHECK_NE(peerid, NO_PEER);		BOOST_CHECK_NE(peerid, NO_PEER);
for (int i = 0; i < 10; i++) {		for (int i = 0; i < 10; i++) {
▲ Show 20 Lines • Show All 70 Lines • ▼ Show 20 Lines	BOOST_CHECK_EQUAL(getPeerId({COutPoint(txid1, 0), COutPoint(txid2, 2)}),
NO_PEER);		NO_PEER);
}		}

BOOST_AUTO_TEST_CASE(orphan_proofs) {		BOOST_AUTO_TEST_CASE(orphan_proofs) {
gArgs.ForceSetArg("-avaproofstakeutxoconfirmations", "2");		gArgs.ForceSetArg("-avaproofstakeutxoconfirmations", "2");
avalanche::PeerManager pm;		avalanche::PeerManager pm;

auto key = CKey::MakeCompressedKey();		auto key = CKey::MakeCompressedKey();
		int immatureHeight = 100;
COutPoint outpoint1 = COutPoint(TxId(GetRandHash()), 0);
COutPoint outpoint2 = COutPoint(TxId(GetRandHash()), 0);
COutPoint outpoint3 = COutPoint(TxId(GetRandHash()), 0);
COutPoint outpoint4 = COutPoint(TxId(GetRandHash()), 0);

const Amount v = 5 * COIN;
const int height = 98;
const int wrongHeight = 99;
const int immatureHeight = 100;

const auto makeProof = [&](const COutPoint &outpoint, const int h) {
return buildProofWithOutpoints(key, {outpoint}, v, key, 0, h);
};

auto proof1 = makeProof(outpoint1, height);
auto proof2 = makeProof(outpoint2, height);
auto proof3 = makeProof(outpoint3, wrongHeight);
auto proof4 = makeProof(outpoint4, immatureHeight);

// Add outpoints, except for proof 2
addCoin(outpoint1, key, v, height);
addCoin(outpoint3, key, v, height);
addCoin(outpoint4, key, v, immatureHeight);

// Add the proofs
BOOST_CHECK(pm.registerProof(proof1));

auto registerOrphan = [&](const ProofRef &proof) {		auto registerOrphan = [&](const ProofRef &proof) {
ProofRegistrationState state;		ProofRegistrationState state;
BOOST_CHECK(!pm.registerProof(proof, state));		BOOST_CHECK(!pm.registerProof(proof, state));
BOOST_CHECK(state.GetResult() == ProofRegistrationResult::ORPHAN);		BOOST_CHECK(state.GetResult() == ProofRegistrationResult::ORPHAN);
};		};

registerOrphan(proof2);
registerOrphan(proof3);
registerOrphan(proof4);

auto checkOrphan = [&](const ProofRef &proof, bool expectedOrphan) {		auto checkOrphan = [&](const ProofRef &proof, bool expectedOrphan) {
const ProofId &proofid = proof->getId();		const ProofId &proofid = proof->getId();
BOOST_CHECK(pm.exists(proofid));		BOOST_CHECK(pm.exists(proofid));

BOOST_CHECK_EQUAL(pm.isOrphan(proofid), expectedOrphan);		BOOST_CHECK_EQUAL(pm.isOrphan(proofid), expectedOrphan);
BOOST_CHECK_EQUAL(pm.isBoundToPeer(proofid), !expectedOrphan);		BOOST_CHECK_EQUAL(pm.isBoundToPeer(proofid), !expectedOrphan);

bool ret = false;		bool ret = false;
pm.forEachPeer([&](const Peer &peer) {		pm.forEachPeer([&](const Peer &peer) {
if (proof->getId() == peer.proof->getId()) {		if (proof->getId() == peer.proof->getId()) {
ret = true;		ret = true;
}		}
});		});
BOOST_CHECK_EQUAL(ret, !expectedOrphan);		BOOST_CHECK_EQUAL(ret, !expectedOrphan);
};		};

// Good		// Track orphans so we can test them later
checkOrphan(proof1, false);
// MISSING_UTXO
checkOrphan(proof2, true);
// HEIGHT_MISMATCH
checkOrphan(proof3, true);
// IMMATURE_UTXO
checkOrphan(proof4, true);

// Add outpoint2, proof2 is no longer considered orphan
addCoin(outpoint2, key, v, height);

pm.updatedBlockTip();
checkOrphan(proof2, false);

// The status of proof1 and proof3 are unchanged
checkOrphan(proof1, false);
checkOrphan(proof3, true);

// Mine a block to increase the chain height for proof4 verification
mineBlocks(1);
pm.updatedBlockTip();
checkOrphan(proof4, false);

// Spend outpoint1, proof1 becomes orphan
{
LOCK(cs_main);
CCoinsViewCache &coins = ::ChainstateActive().CoinsTip();
coins.SpendCoin(outpoint1);
}

pm.updatedBlockTip();
checkOrphan(proof1, true);

// The status of proof2 and proof3 are unchanged
checkOrphan(proof2, false);
checkOrphan(proof3, true);

// A reorg could make a previous HEIGHT_MISMATCH become valid
{
LOCK(cs_main);
CCoinsViewCache &coins = ::ChainstateActive().CoinsTip();
coins.SpendCoin(outpoint3);
}
addCoin(outpoint3, key, v, wrongHeight);

pm.updatedBlockTip();
checkOrphan(proof3, false);

// The status of proof 1 and proof2 are unchanged
checkOrphan(proof1, true);
checkOrphan(proof2, false);

// Track expected orphans so we can test them later
std::vector<ProofRef> orphans;		std::vector<ProofRef> orphans;
orphans.push_back(proof1);

// Fill up orphan pool to test the size limit		// Fill up orphan pool to test the size limit
for (uint32_t i = 1; i < AVALANCHE_MAX_ORPHAN_PROOFS; i++) {		for (int64_t i = 1; i <= AVALANCHE_MAX_ORPHAN_PROOFS; i++) {
COutPoint outpoint = COutPoint(TxId(GetRandHash()), 0);		COutPoint outpoint = COutPoint(TxId(GetRandHash()), 0);
auto proof =		auto proof = buildProofWithOutpoints(key, {outpoint}, i * COIN, key, 0,
buildProofWithOutpoints(key, {outpoint}, 10 * COIN, key, 0, height);		immatureHeight);
		addCoin(outpoint, key, i * COIN, immatureHeight);
registerOrphan(proof);		registerOrphan(proof);
		checkOrphan(proof, true);
orphans.push_back(proof);		orphans.push_back(proof);
}		}

// New orphans are rejected when the pool is full, even if they have higher		// More orphans evict lower scoring proofs
// proof scores.		for (auto i = 0; i < 100; i++) {
{
COutPoint outpoint = COutPoint(TxId(GetRandHash()), 0);		COutPoint outpoint = COutPoint(TxId(GetRandHash()), 0);
auto proof =		auto proof = buildProofWithOutpoints(key, {outpoint}, 200 * COIN, key,
buildProofWithOutpoints(key, {outpoint}, 20 * COIN, key, 0, height);		0, immatureHeight);
registerOrphan(proof);		addCoin(outpoint, key, 200 * COIN, immatureHeight);
BOOST_CHECK(!pm.exists(proof->getId()));
}

// Replacement when the pool is full still works
{
auto proof = buildProofWithOutpoints(key, {outpoint1}, 10 * COIN, key,
1, height);
registerOrphan(proof);		registerOrphan(proof);
checkOrphan(proof, true);		checkOrphan(proof, true);
BOOST_CHECK(!pm.exists(proof1->getId()));
orphans.push_back(proof);		orphans.push_back(proof);
		BOOST_CHECK(!pm.exists(orphans.front()->getId()));
orphans.erase(orphans.begin());		orphans.erase(orphans.begin());
}		}

// Reorg so that some more proofs become orphans		// Replacement when the pool is full still works
{
LOCK(cs_main);
CCoinsViewCache &coins = ::ChainstateActive().CoinsTip();
coins.SpendCoin(outpoint2);
coins.SpendCoin(outpoint3);
coins.SpendCoin(outpoint4);

orphans.push_back(proof2);
orphans.push_back(proof3);
orphans.push_back(proof4);
}

pm.updatedBlockTip();

// New orphans are rejected when the pool is full, even if they have higher
// proof scores.
{		{
COutPoint outpoint = COutPoint(TxId(GetRandHash()), 0);		const COutPoint &outpoint =
auto proof =		orphans.front()->getStakes()[0].getStake().getUTXO();
buildProofWithOutpoints(key, {outpoint}, 20 * COIN, key, 0, height);		auto proof = buildProofWithOutpoints(key, {outpoint}, 101 * COIN, key,
		1, immatureHeight);
registerOrphan(proof);		registerOrphan(proof);
BOOST_CHECK(!pm.exists(proof->getId()));
}

// Even though we've exceeded the orphan pool limit, the reorged proofs are
// still being tracked.
for (auto &proof : orphans) {
checkOrphan(proof, true);		checkOrphan(proof, true);
		orphans.push_back(proof);
		BOOST_CHECK(!pm.exists(orphans.front()->getId()));
		orphans.erase(orphans.begin());
}		}

// Another block causes orphans to be trimmed to the limit		// Mine a block to increase the chain height, making all orphans mature
		mineBlocks(1);
pm.updatedBlockTip();		pm.updatedBlockTip();
		for (const auto &proof : orphans) {
int numOrphans = 0;		checkOrphan(proof, false);
for (auto &proof : orphans) {
if (pm.exists(proof->getId())) {
checkOrphan(proof, true);
numOrphans++;
}		}
}		}
BOOST_CHECK_EQUAL(numOrphans, AVALANCHE_MAX_ORPHAN_PROOFS);
}

BOOST_AUTO_TEST_CASE(dangling_node) {		BOOST_AUTO_TEST_CASE(dangling_node) {
avalanche::PeerManager pm;		avalanche::PeerManager pm;

auto proof = buildRandomProof(MIN_VALID_PROOF_SCORE);		auto proof = buildRandomProof(MIN_VALID_PROOF_SCORE);
PeerId peerid = TestPeerManager::registerAndGetPeerId(pm, proof);		PeerId peerid = TestPeerManager::registerAndGetPeerId(pm, proof);
BOOST_CHECK_NE(peerid, NO_PEER);		BOOST_CHECK_NE(peerid, NO_PEER);

▲ Show 20 Lines • Show All 104 Lines • ▼ Show 20 Lines	BOOST_CHECK(pm.isInConflictingPool(conflictingProof->getId()));
LOCK(cs_main);		LOCK(cs_main);
CCoinsViewCache &coins = ::ChainstateActive().CoinsTip();		CCoinsViewCache &coins = ::ChainstateActive().CoinsTip();
// Make proofToInvalidate invalid		// Make proofToInvalidate invalid
coins.SpendCoin(outpointToSend);		coins.SpendCoin(outpointToSend);
}		}

pm.updatedBlockTip();		pm.updatedBlockTip();

BOOST_CHECK(pm.isOrphan(proofToInvalidate->getId()));		BOOST_CHECK(!pm.exists(proofToInvalidate->getId()));

BOOST_CHECK(!pm.isInConflictingPool(conflictingProof->getId()));		BOOST_CHECK(!pm.isInConflictingPool(conflictingProof->getId()));
BOOST_CHECK(pm.isBoundToPeer(conflictingProof->getId()));		BOOST_CHECK(pm.isBoundToPeer(conflictingProof->getId()));
}		}

BOOST_FIXTURE_TEST_CASE(conflicting_proof_selection, NoCoolDownFixture) {		BOOST_FIXTURE_TEST_CASE(conflicting_proof_selection, NoCoolDownFixture) {
const CKey key = CKey::MakeCompressedKey();		const CKey key = CKey::MakeCompressedKey();

▲ Show 20 Lines • Show All 79 Lines • ▼ Show 20 Lines	for (const CKey &k : {key, CKey::MakeCompressedKey()}) {
checkPreferred(proofSimilar, proof_multiUtxo,		checkPreferred(proofSimilar, proof_multiUtxo,
proofSimilar->getId() < proof_multiUtxo->getId());		proofSimilar->getId() < proof_multiUtxo->getId());
}		}

gArgs.ClearForcedArg("-enableavalancheproofreplacement");		gArgs.ClearForcedArg("-enableavalancheproofreplacement");
}		}

BOOST_AUTO_TEST_CASE(conflicting_orphans) {		BOOST_AUTO_TEST_CASE(conflicting_orphans) {
		gArgs.ForceSetArg("-avaproofstakeutxoconfirmations", "2");
avalanche::PeerManager pm;		avalanche::PeerManager pm;

const CKey key = CKey::MakeCompressedKey();		const CKey key = CKey::MakeCompressedKey();

const COutPoint conflictingOutpoint(TxId(GetRandHash()), 0);		const COutPoint conflictingOutpoint = createUtxo(key);
const COutPoint randomOutpoint1(TxId(GetRandHash()), 0);		const COutPoint matureOutpoint = createUtxo(key, 10 * COIN, 99);

auto orphan10 = buildProofWithSequence(key, {conflictingOutpoint}, 10);		auto orphan10 = buildProofWithSequence(key, {conflictingOutpoint}, 10);
auto orphan20 =		auto orphan20 =
buildProofWithSequence(key, {conflictingOutpoint, randomOutpoint1}, 20);		buildProofWithSequence(key, {conflictingOutpoint, matureOutpoint}, 20);

BOOST_CHECK(!pm.registerProof(orphan10));		BOOST_CHECK(!pm.registerProof(orphan10));
BOOST_CHECK(pm.isOrphan(orphan10->getId()));		BOOST_CHECK(pm.isOrphan(orphan10->getId()));

BOOST_CHECK(!pm.registerProof(orphan20));		BOOST_CHECK(!pm.registerProof(orphan20));
BOOST_CHECK(pm.isOrphan(orphan20->getId()));		BOOST_CHECK(pm.isOrphan(orphan20->getId()));
BOOST_CHECK(!pm.exists(orphan10->getId()));		BOOST_CHECK(!pm.exists(orphan10->getId()));

const COutPoint outpointToSend(TxId(GetRandHash()), 0);
// Add both randomOutpoint1 and outpointToSend to the UTXO set. The orphan20
// proof is still an orphan because the conflictingOutpoint is unknown.
addCoin(randomOutpoint1, key);
addCoin(outpointToSend, key);

// Build and register proof valid proof that will conflict with the orphan		// Build and register proof valid proof that will conflict with the orphan
auto proof30 =		auto proof30 =
buildProofWithSequence(key, {randomOutpoint1, outpointToSend}, 30);		buildProofWithOutpoints(key, {matureOutpoint}, 10 * COIN, key, 30, 99);
BOOST_CHECK(pm.registerProof(proof30));		BOOST_CHECK(pm.registerProof(proof30));
BOOST_CHECK(pm.isBoundToPeer(proof30->getId()));		BOOST_CHECK(pm.isBoundToPeer(proof30->getId()));

// Spend the outpointToSend to orphan proof30		// Reorg to a shorter chain to orphan proof30
{		{
LOCK(cs_main);		BlockValidationState state;
CCoinsViewCache &coins = ::ChainstateActive().CoinsTip();		::ChainstateActive().InvalidateBlock(GetConfig(), state,
coins.SpendCoin(outpointToSend);		::ChainActive().Tip());
}		}

// Check that a rescan will also select the preferred orphan, in this case		// Check that a rescan will also select the preferred orphan, in this case
// proof30 will replace orphan20.		// proof30 will replace orphan20.
pm.updatedBlockTip();		pm.updatedBlockTip();

BOOST_CHECK(!pm.isBoundToPeer(proof30->getId()));		BOOST_CHECK(!pm.isBoundToPeer(proof30->getId()));
BOOST_CHECK(pm.isOrphan(proof30->getId()));		BOOST_CHECK(pm.isOrphan(proof30->getId()));
▲ Show 20 Lines • Show All 222 Lines • ▼ Show 20 Lines	BOOST_AUTO_TEST_CASE(conflicting_proof_cooldown) {
checkRegistrationFailure(proofSeq40, ProofRegistrationResult::CONFLICTING);		checkRegistrationFailure(proofSeq40, ProofRegistrationResult::CONFLICTING);
BOOST_CHECK(pm.isInConflictingPool(proofSeq40->getId()));		BOOST_CHECK(pm.isInConflictingPool(proofSeq40->getId()));
BOOST_CHECK(!pm.exists(proofSeq20->getId()));		BOOST_CHECK(!pm.exists(proofSeq20->getId()));

gArgs.ClearForcedArg("-avalancheconflictingproofcooldown");		gArgs.ClearForcedArg("-avalancheconflictingproofcooldown");
}		}

BOOST_FIXTURE_TEST_CASE(reject_proof, NoCoolDownFixture) {		BOOST_FIXTURE_TEST_CASE(reject_proof, NoCoolDownFixture) {
		gArgs.ForceSetArg("-avaproofstakeutxoconfirmations", "2");
avalanche::PeerManager pm;		avalanche::PeerManager pm;

const CKey key = CKey::MakeCompressedKey();		const CKey key = CKey::MakeCompressedKey();

const COutPoint conflictingOutpoint = createUtxo(key);		const COutPoint conflictingOutpoint = createUtxo(key, 10 * COIN, 99);
		const COutPoint immatureOutpoint = createUtxo(key);

// The good, the bad and the ugly		// The good, the bad and the ugly
auto proofSeq10 = buildProofWithSequence(key, {conflictingOutpoint}, 10);		auto proofSeq10 = buildProofWithOutpoints(key, {conflictingOutpoint},
auto proofSeq20 = buildProofWithSequence(key, {conflictingOutpoint}, 20);		10 * COIN, key, 10, 99);
		auto proofSeq20 = buildProofWithOutpoints(key, {conflictingOutpoint},
		10 * COIN, key, 20, 99);
auto orphan30 = buildProofWithSequence(		auto orphan30 = buildProofWithSequence(
key, {conflictingOutpoint, {TxId(GetRandHash()), 0}}, 30);		key, {conflictingOutpoint, immatureOutpoint}, 30);

BOOST_CHECK(pm.registerProof(proofSeq20));		BOOST_CHECK(pm.registerProof(proofSeq20));
BOOST_CHECK(!pm.registerProof(proofSeq10));		BOOST_CHECK(!pm.registerProof(proofSeq10));
BOOST_CHECK(!pm.registerProof(orphan30));		BOOST_CHECK(!pm.registerProof(orphan30));

BOOST_CHECK(pm.isBoundToPeer(proofSeq20->getId()));		BOOST_CHECK(pm.isBoundToPeer(proofSeq20->getId()));
BOOST_CHECK(pm.isInConflictingPool(proofSeq10->getId()));		BOOST_CHECK(pm.isInConflictingPool(proofSeq10->getId()));
BOOST_CHECK(pm.isOrphan(orphan30->getId()));		BOOST_CHECK(pm.isOrphan(orphan30->getId()));
▲ Show 20 Lines • Show All 602 Lines • Show Last 20 Lines