Changeset View
Changeset View
Standalone View
Standalone View
test/functional/abc_p2p_version_timestamp.py
| #!/usr/bin/env python3 | #!/usr/bin/env python3 | ||||
| # Copyright (c) 2020 The Bitcoin developers | # Copyright (c) 2020 The Bitcoin developers | ||||
| # Distributed under the MIT software license, see the accompanying | # Distributed under the MIT software license, see the accompanying | ||||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | # file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||||
| """Test time adjustment behavior when receiving a VERSION message. | """Test time adjustment behavior when receiving a VERSION message. | ||||
| Messages with a timestamp too far in the past are ignored and discouraged. | Messages with a timestamp too far in the past are ignored and discouraged. | ||||
| Messages with a timestamp more recent than the genesis block timestamp are used to | Messages from an outbound peer with a timestamp more recent than the genesis block | ||||
| adjust our local time. | timestamp are used to adjust our local time. | ||||
| """ | """ | ||||
| from test_framework.blocktools import TIME_GENESIS_BLOCK | from test_framework.blocktools import TIME_GENESIS_BLOCK | ||||
| from test_framework.messages import NODE_NETWORK, msg_version | from test_framework.messages import NODE_NETWORK, msg_version | ||||
| from test_framework.p2p import P2P_SUBVERSION, P2P_VERSION, P2PInterface | from test_framework.p2p import P2P_SUBVERSION, P2P_VERSION, P2PInterface | ||||
| from test_framework.test_framework import BitcoinTestFramework | from test_framework.test_framework import BitcoinTestFramework | ||||
| from test_framework.util import assert_equal | |||||
| NODE0_TIME = TIME_GENESIS_BLOCK + 1337 | |||||
| class ModifiedVersionTimestampP2PInterface(P2PInterface): | class ModifiedVersionTimestampP2PInterface(P2PInterface): | ||||
| def __init__(self, timestamp): | def __init__(self, timestamp): | ||||
| super().__init__() | super().__init__() | ||||
| self.versionTimestamp = timestamp | self.versionTimestamp = timestamp | ||||
| def peer_connect(self, *args, services=NODE_NETWORK, | def peer_connect(self, *args, services=NODE_NETWORK, | ||||
| Show All 15 Lines | def peer_connect(self, *args, services=NODE_NETWORK, | ||||
| # Will be sent right after connection_made | # Will be sent right after connection_made | ||||
| self.on_connection_send_msg = vt | self.on_connection_send_msg = vt | ||||
| return create_conn | return create_conn | ||||
| class VersionTimestampTest(BitcoinTestFramework): | class VersionTimestampTest(BitcoinTestFramework): | ||||
| def set_test_params(self): | def set_test_params(self): | ||||
| self.num_nodes = 1 | self.num_nodes = 2 | ||||
| def setup_network(self): | |||||
| self.setup_nodes() | |||||
| # Don't connect the nodes | |||||
| def run_test(self): | def run_test(self): | ||||
| # Set a deterministic time so that we can check the time offset with other | |||||
| # nodes is as expected | |||||
| self.nodes[0].setmocktime(NODE0_TIME) | |||||
| self.log.info("Check some invalid timestamp in the version message") | self.log.info("Check some invalid timestamp in the version message") | ||||
| with self.nodes[0].assert_debug_log( | with self.nodes[0].assert_debug_log( | ||||
| expected_msgs=["Added connection peer=0", | expected_msgs=["Added connection peer=0", | ||||
| "Ignoring invalid timestamp in version message"]): | "Ignoring invalid timestamp in version message"]): | ||||
| self.nodes[0].add_p2p_connection( | self.nodes[0].add_p2p_connection( | ||||
| ModifiedVersionTimestampP2PInterface(-9223372036854775807), | ModifiedVersionTimestampP2PInterface(-9223372036854775807), | ||||
| send_version=False) | send_version=False) | ||||
| self.log.info("Check invalid side of the timestamp boundary") | self.log.info("Check invalid side of the timestamp boundary") | ||||
| with self.nodes[0].assert_debug_log( | with self.nodes[0].assert_debug_log( | ||||
| expected_msgs=["Added connection peer=1", | expected_msgs=["Added connection peer=1", | ||||
| "Ignoring invalid timestamp in version message"]): | "Ignoring invalid timestamp in version message"]): | ||||
| self.nodes[0].add_p2p_connection( | self.nodes[0].add_p2p_connection( | ||||
| ModifiedVersionTimestampP2PInterface(TIME_GENESIS_BLOCK - 1), | ModifiedVersionTimestampP2PInterface(TIME_GENESIS_BLOCK - 1), | ||||
| send_version=False) | send_version=False) | ||||
| self.log.info("Check valid side of the timestamp boundary (genesis timestamp)") | self.log.info("Check valid side of the timestamp boundary (genesis timestamp)") | ||||
| # Outbound connection: the timestamp is used for our adjusted time | |||||
| with self.nodes[0].assert_debug_log( | with self.nodes[0].assert_debug_log( | ||||
| expected_msgs=["Added connection peer=2", "added time data"], | expected_msgs=["Added connection peer=2", "added time data"], | ||||
| unexpected_msgs=["Ignoring invalid timestamp in version message"]): | unexpected_msgs=["Ignoring invalid timestamp in version message"]): | ||||
| self.nodes[1].setmocktime(TIME_GENESIS_BLOCK) | |||||
Fabien: Oh I see, the mocktime is now set within the assertion context. My bad, previous version was… | |||||
| self.connect_nodes(0, 1) | |||||
| # This check verifies that the mocktime was indeed used in the VERSION message | |||||
| assert_equal(self.nodes[0].getpeerinfo()[2]["timeoffset"], | |||||
| TIME_GENESIS_BLOCK - NODE0_TIME) | |||||
| # Inbound connection: the timestamp is ignored | |||||
| with self.nodes[0].assert_debug_log( | |||||
| expected_msgs=["Added connection peer=3"], | |||||
| unexpected_msgs=["Ignoring invalid timestamp in version message", | |||||
| "added time data"]): | |||||
| self.nodes[0].add_p2p_connection( | self.nodes[0].add_p2p_connection( | ||||
| ModifiedVersionTimestampP2PInterface(TIME_GENESIS_BLOCK), | ModifiedVersionTimestampP2PInterface(TIME_GENESIS_BLOCK), | ||||
| send_version=False) | send_version=False) | ||||
FabienUnsubmitted Not Done Inline ActionsYou can also check that the node 0 timeoffset didn't change, but no blocker Fabien: You can also check that the node 0 timeoffset didn't change, but no blocker | |||||
PiRKAuthorUnsubmitted Done Inline ActionsI will not do it in this diff, as this requires changing the test some more. I think the current test does not actually affect node0's adjusted time, maybe because the delta is larger than DEFAULT_MAX_TIME_ADJUSTMENT, or maybe because some parts of the code don't use the mocktime as expected... To be investigated. PiRK: I will not do it in this diff, as this requires changing the test some more. I think the… | |||||
PiRKAuthorUnsubmitted Done Inline ActionsActually it is because the time is not actually adjusted before there are 5 valid offsets added to the list. PiRK: Actually it is because the time is not actually adjusted before there are 5 valid offsets added… | |||||
| if __name__ == '__main__': | if __name__ == '__main__': | ||||
| VersionTimestampTest().main() | VersionTimestampTest().main() | ||||
Oh I see, the mocktime is now set within the assertion context. My bad, previous version was correct, please revert