Page MenuHomePhabricator
Differential D13887 Diff 40276 test/functional/wallet_multiwallet.py

Changeset View

Standalone View

View Options

test/functional/wallet_multiwallet.py

Show All 15 Lines
from test_framework.authproxy import JSONRPCException from test_framework.authproxy import JSONRPCException
from test_framework.test_framework import BitcoinTestFramework from test_framework.test_framework import BitcoinTestFramework
from test_framework.test_node import ErrorMatch from test_framework.test_node import ErrorMatch
from test_framework.util import assert_equal, assert_raises_rpc_error, get_rpc_proxy from test_framework.util import assert_equal, assert_raises_rpc_error, get_rpc_proxy
got_loading_error = False got_loading_error = False
def test_load_unload(node, name, timeout=60.): def test_load_unload(node, name, timeout=60.0):
global got_loading_error global got_loading_error
t0 = time.time() t0 = time.time()
while time.time() - t0 < timeout and not got_loading_error: while time.time() - t0 < timeout and not got_loading_error:
try: try:
node.loadwallet(name) node.loadwallet(name)
node.unloadwallet(name) node.unloadwallet(name)
except JSONRPCException as e: except JSONRPCException as e:
if e.error['code'] == - \ if (
4 and 'Wallet already being loading' in e.error['message']: e.error["code"] == -4
and "Wallet already being loading" in e.error["message"]
):
got_loading_error = True got_loading_error = True
return return
# Add a small sleep to avoid CPU exhaustion in the unlikely case # Add a small sleep to avoid CPU exhaustion in the unlikely case
# the race never happens. # the race never happens.
time.sleep(0.001) time.sleep(0.001)
class MultiWalletTest(BitcoinTestFramework): class MultiWalletTest(BitcoinTestFramework):
def set_test_params(self): def set_test_params(self):
self.setup_clean_chain = True self.setup_clean_chain = True
self.num_nodes = 2 self.num_nodes = 2
self.rpc_timeout = 120 self.rpc_timeout = 120
def skip_test_if_missing_module(self): def skip_test_if_missing_module(self):
self.skip_if_no_wallet() self.skip_if_no_wallet()
def add_options(self, parser): def add_options(self, parser):
parser.add_argument( parser.add_argument(
'--data_wallets_dir', "--data_wallets_dir",
default=os.path.join( default=os.path.join(
os.path.dirname( os.path.dirname(os.path.realpath(__file__)), "data/wallets/"
os.path.realpath(__file__)), ),
'data/wallets/'), help="Test data with wallet directories (default: %(default)s)",
help='Test data with wallet directories (default: %(default)s)',
) )
def run_test(self): def run_test(self):
node = self.nodes[0] node = self.nodes[0]
def data_dir(*p): return os.path.join(node.datadir, self.chain, *p) def data_dir(*p):
return os.path.join(node.datadir, self.chain, *p)
def wallet_dir(*p): return data_dir('wallets', *p) def wallet_dir(*p):
return data_dir("wallets", *p)
def wallet(name): return node.get_wallet_rpc(name) def wallet(name):
return node.get_wallet_rpc(name)
def wallet_file(name): def wallet_file(name):
if os.path.isdir(wallet_dir(name)): if os.path.isdir(wallet_dir(name)):
return wallet_dir(name, self.wallet_data_filename) return wallet_dir(name, self.wallet_data_filename)
return wallet_dir(name) return wallet_dir(name)
assert_equal(self.nodes[0].listwalletdir(), assert_equal(
{'wallets': [{'name': self.default_wallet_name}]}) self.nodes[0].listwalletdir(),
{"wallets": [{"name": self.default_wallet_name}]},
)
# check wallet.dat is created # check wallet.dat is created
self.stop_nodes() self.stop_nodes()
assert_equal(os.path.isfile(wallet_dir(self.default_wallet_name, assert_equal(
self.wallet_data_filename)), os.path.isfile(
True) wallet_dir(self.default_wallet_name, self.wallet_data_filename)
),
True,
)
# create symlink to verify wallet directory path can be referenced # create symlink to verify wallet directory path can be referenced
# through symlink # through symlink
if os.name != 'nt': if os.name != "nt":
os.mkdir(wallet_dir('w7')) os.mkdir(wallet_dir("w7"))
os.symlink('w7', wallet_dir('w7_symlink')) os.symlink("w7", wallet_dir("w7_symlink"))
# rename wallet.dat to make sure plain wallet file paths (as opposed to # rename wallet.dat to make sure plain wallet file paths (as opposed to
# directory paths) can be loaded # directory paths) can be loaded
os.rename(wallet_dir(self.default_wallet_name, self.wallet_data_filename), os.rename(
wallet_dir("w8")) wallet_dir(self.default_wallet_name, self.wallet_data_filename),
wallet_dir("w8"),
)
# create another dummy wallet for use in testing backups later # create another dummy wallet for use in testing backups later
self.start_node( self.start_node(0, ["-nowallet", f"-wallet={self.default_wallet_name}"])
0, ["-nowallet", f"-wallet={self.default_wallet_name}"])
self.stop_nodes() self.stop_nodes()
empty_wallet = os.path.join(self.options.tmpdir, 'empty.dat') empty_wallet = os.path.join(self.options.tmpdir, "empty.dat")
os.rename(wallet_dir(self.default_wallet_name, self.wallet_data_filename), os.rename(
empty_wallet) wallet_dir(self.default_wallet_name, self.wallet_data_filename),
empty_wallet,
)
# restart node with a mix of wallet names: # restart node with a mix of wallet names:
# w1, w2, w3 - to verify new wallets created when non-existing paths specified # w1, w2, w3 - to verify new wallets created when non-existing paths specified
# w - to verify wallet name matching works when one wallet path is prefix of another # w - to verify wallet name matching works when one wallet path is prefix of another
# sub/w5 - to verify relative wallet path is created correctly # sub/w5 - to verify relative wallet path is created correctly
# extern/w6 - to verify absolute wallet path is created correctly # extern/w6 - to verify absolute wallet path is created correctly
# w7_symlink - to verify symlinked wallet path is initialized correctly # w7_symlink - to verify symlinked wallet path is initialized correctly
# w8 - to verify existing wallet file is loaded correctly # w8 - to verify existing wallet file is loaded correctly
# '' - to verify default wallet file is created correctly # '' - to verify default wallet file is created correctly
wallet_names = ['w1', 'w2', 'w3', 'w', 'sub/w5', wallet_names = [
os.path.join(self.options.tmpdir, 'extern/w6'), "w1",
'w7_symlink', 'w8', self.default_wallet_name] "w2",
if os.name == 'nt': "w3",
wallet_names.remove('w7_symlink') "w",
extra_args = ['-nowallet'] + \ "sub/w5",
[f'-wallet={n}' for n in wallet_names] os.path.join(self.options.tmpdir, "extern/w6"),
"w7_symlink",
"w8",
self.default_wallet_name,
]
if os.name == "nt":
wallet_names.remove("w7_symlink")
extra_args = ["-nowallet"] + [f"-wallet={n}" for n in wallet_names]
self.start_node(0, extra_args) self.start_node(0, extra_args)
assert_equal( assert_equal(
sorted(w['name'] for w in self.nodes[0].listwalletdir()['wallets']), sorted(w["name"] for w in self.nodes[0].listwalletdir()["wallets"]),
[self.default_wallet_name, os.path.join('sub', 'w5'), 'w', 'w1', [
'w2', 'w3', 'w7', 'w7_symlink', 'w8']) self.default_wallet_name,
os.path.join("sub", "w5"),
"w",
"w1",
"w2",
"w3",
"w7",
"w7_symlink",
"w8",
],
)
assert_equal(set(node.listwallets()), set(wallet_names)) assert_equal(set(node.listwallets()), set(wallet_names))
# check that all requested wallets were created # check that all requested wallets were created
self.stop_node(0) self.stop_node(0)
for wallet_name in wallet_names: for wallet_name in wallet_names:
assert_equal(os.path.isfile(wallet_file(wallet_name)), True) assert_equal(os.path.isfile(wallet_file(wallet_name)), True)
# should not initialize if wallet path can't be created # should not initialize if wallet path can't be created
exp_stderr = ( exp_stderr = (
"filesystem error:" if sys.platform != 'win32' "filesystem error:" if sys.platform != "win32" else "create_directories:"
else "create_directories:"
) )
self.nodes[0].assert_start_raises_init_error( self.nodes[0].assert_start_raises_init_error(
['-wallet=w8/bad'], exp_stderr, match=ErrorMatch.PARTIAL_REGEX) ["-wallet=w8/bad"], exp_stderr, match=ErrorMatch.PARTIAL_REGEX
)
self.nodes[0].assert_start_raises_init_error( self.nodes[0].assert_start_raises_init_error(
['-walletdir=wallets'], 'Error: Specified -walletdir "wallets" does not exist') ["-walletdir=wallets"],
'Error: Specified -walletdir "wallets" does not exist',
)
self.nodes[0].assert_start_raises_init_error( self.nodes[0].assert_start_raises_init_error(
['-walletdir=wallets'], 'Error: Specified -walletdir "wallets" is a relative path', cwd=data_dir()) ["-walletdir=wallets"],
'Error: Specified -walletdir "wallets" is a relative path',
cwd=data_dir(),
)
self.nodes[0].assert_start_raises_init_error( self.nodes[0].assert_start_raises_init_error(
['-walletdir=debug.log'], 'Error: Specified -walletdir "debug.log" is not a directory', cwd=data_dir()) ["-walletdir=debug.log"],
'Error: Specified -walletdir "debug.log" is not a directory',
cwd=data_dir(),
)
self.start_node(0, ['-wallet=w1', '-wallet=w1']) self.start_node(0, ["-wallet=w1", "-wallet=w1"])
self.stop_node(0, 'Warning: Ignoring duplicate -wallet w1.') self.stop_node(0, "Warning: Ignoring duplicate -wallet w1.")
# should not initialize if one wallet is a copy of another # should not initialize if one wallet is a copy of another
shutil.copyfile(wallet_dir('w8'), wallet_dir('w8_copy')) shutil.copyfile(wallet_dir("w8"), wallet_dir("w8_copy"))
exp_stderr = r"BerkeleyDatabase: Can't open database w8_copy \(duplicates fileid \w+ from w8\)" exp_stderr = (
r"BerkeleyDatabase: Can't open database w8_copy \(duplicates fileid \w+"
r" from w8\)"
)
self.nodes[0].assert_start_raises_init_error( self.nodes[0].assert_start_raises_init_error(
['-wallet=w8', '-wallet=w8_copy'], exp_stderr, match=ErrorMatch.PARTIAL_REGEX) ["-wallet=w8", "-wallet=w8_copy"],
exp_stderr,
match=ErrorMatch.PARTIAL_REGEX,
)
# should not initialize if wallet file is a symlink # should not initialize if wallet file is a symlink
if os.name != 'nt': if os.name != "nt":
os.symlink('w8', wallet_dir('w8_symlink')) os.symlink("w8", wallet_dir("w8_symlink"))
self.nodes[0].assert_start_raises_init_error( self.nodes[0].assert_start_raises_init_error(
['-wallet=w8_symlink'], r'Error: Invalid -wallet path \'w8_symlink\'\. .*', match=ErrorMatch.FULL_REGEX) ["-wallet=w8_symlink"],
r"Error: Invalid -wallet path \'w8_symlink\'\. .*",
match=ErrorMatch.FULL_REGEX,
)
# should not initialize if the specified walletdir does not exist # should not initialize if the specified walletdir does not exist
self.nodes[0].assert_start_raises_init_error( self.nodes[0].assert_start_raises_init_error(
['-walletdir=bad'], 'Error: Specified -walletdir "bad" does not exist') ["-walletdir=bad"], 'Error: Specified -walletdir "bad" does not exist'
)
# should not initialize if the specified walletdir is not a directory # should not initialize if the specified walletdir is not a directory
not_a_dir = wallet_dir('notadir') not_a_dir = wallet_dir("notadir")
open(not_a_dir, 'a', encoding="utf8").close() open(not_a_dir, "a", encoding="utf8").close()
self.nodes[0].assert_start_raises_init_error( self.nodes[0].assert_start_raises_init_error(
[f"-walletdir={not_a_dir}"], f"Error: Specified -walletdir \"{not_a_dir}\" is not a directory") [f"-walletdir={not_a_dir}"],
f'Error: Specified -walletdir "{not_a_dir}" is not a directory',
)
# if wallets/ doesn't exist, datadir should be the default wallet dir # if wallets/ doesn't exist, datadir should be the default wallet dir
wallet_dir2 = data_dir('walletdir') wallet_dir2 = data_dir("walletdir")
os.rename(wallet_dir(), wallet_dir2) os.rename(wallet_dir(), wallet_dir2)
self.start_node(0, ['-nowallet', '-wallet=w4', '-wallet=w5']) self.start_node(0, ["-nowallet", "-wallet=w4", "-wallet=w5"])
assert_equal(set(node.listwallets()), {"w4", "w5"}) assert_equal(set(node.listwallets()), {"w4", "w5"})
w5 = wallet("w5") w5 = wallet("w5")
self.generatetoaddress( self.generatetoaddress(
node, node, nblocks=1, address=w5.getnewaddress(), sync_fun=self.no_op
nblocks=1, )
address=w5.getnewaddress(),
sync_fun=self.no_op)
# now if wallets/ exists again, but the rootdir is specified as the # now if wallets/ exists again, but the rootdir is specified as the
# walletdir, w4 and w5 should still be loaded # walletdir, w4 and w5 should still be loaded
os.rename(wallet_dir2, wallet_dir()) os.rename(wallet_dir2, wallet_dir())
self.restart_node(0, ['-nowallet', '-wallet=w4', '-wallet=w5', self.restart_node(
f"-walletdir={data_dir()}"]) 0, ["-nowallet", "-wallet=w4", "-wallet=w5", f"-walletdir={data_dir()}"]
)
assert_equal(set(node.listwallets()), {"w4", "w5"}) assert_equal(set(node.listwallets()), {"w4", "w5"})
w5 = wallet("w5") w5 = wallet("w5")
w5_info = w5.getwalletinfo() w5_info = w5.getwalletinfo()
assert_equal(w5_info['immature_balance'], 50000000) assert_equal(w5_info["immature_balance"], 50000000)
competing_wallet_dir = os.path.join( competing_wallet_dir = os.path.join(self.options.tmpdir, "competing_walletdir")
self.options.tmpdir, 'competing_walletdir')
os.mkdir(competing_wallet_dir) os.mkdir(competing_wallet_dir)
self.restart_node(0, [f"-walletdir={competing_wallet_dir}"]) self.restart_node(0, [f"-walletdir={competing_wallet_dir}"])
exp_stderr = r"Error: Error initializing wallet database environment \"\S+competing_walletdir\"!" exp_stderr = (
r"Error: Error initializing wallet database environment"
r" \"\S+competing_walletdir\"!"
)
self.nodes[1].assert_start_raises_init_error( self.nodes[1].assert_start_raises_init_error(
[f"-walletdir={competing_wallet_dir}"], exp_stderr, match=ErrorMatch.PARTIAL_REGEX) [f"-walletdir={competing_wallet_dir}"],
exp_stderr,
match=ErrorMatch.PARTIAL_REGEX,
)
self.restart_node(0, extra_args) self.restart_node(0, extra_args)
assert_equal( assert_equal(
sorted(w['name'] for w in self.nodes[0].listwalletdir()['wallets']), sorted(w["name"] for w in self.nodes[0].listwalletdir()["wallets"]),
[self.default_wallet_name, os.path.join('sub', 'w5'), 'w', 'w1', 'w2', [
'w3', 'w7', 'w7_symlink', 'w8', 'w8_copy']) self.default_wallet_name,
os.path.join("sub", "w5"),
"w",
"w1",
"w2",
"w3",
"w7",
"w7_symlink",
"w8",
"w8_copy",
],
)
wallets = [wallet(w) for w in wallet_names] wallets = [wallet(w) for w in wallet_names]
wallet_bad = wallet("bad") wallet_bad = wallet("bad")
# check wallet names and balances # check wallet names and balances
self.generatetoaddress( self.generatetoaddress(
node, nblocks=1, address=wallets[0].getnewaddress(), sync_fun=self.no_op) node, nblocks=1, address=wallets[0].getnewaddress(), sync_fun=self.no_op
)
for wallet_name, wallet in zip(wallet_names, wallets): for wallet_name, wallet in zip(wallet_names, wallets):
info = wallet.getwalletinfo() info = wallet.getwalletinfo()
assert_equal(info['immature_balance'], assert_equal(
50000000 if wallet is wallets[0] else 0) info["immature_balance"], 50000000 if wallet is wallets[0] else 0
assert_equal(info['walletname'], wallet_name) )
assert_equal(info["walletname"], wallet_name)
# accessing invalid wallet fails # accessing invalid wallet fails
assert_raises_rpc_error(-18, "Requested wallet does not exist or is not loaded", assert_raises_rpc_error(
wallet_bad.getwalletinfo) -18,
"Requested wallet does not exist or is not loaded",
wallet_bad.getwalletinfo,
)
# accessing wallet RPC without using wallet endpoint fails # accessing wallet RPC without using wallet endpoint fails
assert_raises_rpc_error(-19, "Wallet file not specified (must request wallet RPC through /wallet/<filename> uri-path).", assert_raises_rpc_error(
node.getwalletinfo) -19,
(
"Wallet file not specified (must request wallet RPC through"
" /wallet/<filename> uri-path)."
),
node.getwalletinfo,
)
w1, w2, w3, w4, *_ = wallets w1, w2, w3, w4, *_ = wallets
self.generatetoaddress( self.generatetoaddress(
node, node, nblocks=101, address=w1.getnewaddress(), sync_fun=self.no_op
nblocks=101, )
address=w1.getnewaddress(),
sync_fun=self.no_op)
assert_equal(w1.getbalance(), 100000000) assert_equal(w1.getbalance(), 100000000)
assert_equal(w2.getbalance(), 0) assert_equal(w2.getbalance(), 0)
assert_equal(w3.getbalance(), 0) assert_equal(w3.getbalance(), 0)
assert_equal(w4.getbalance(), 0) assert_equal(w4.getbalance(), 0)
w1.sendtoaddress(w2.getnewaddress(), 1000000) w1.sendtoaddress(w2.getnewaddress(), 1000000)
w1.sendtoaddress(w3.getnewaddress(), 2000000) w1.sendtoaddress(w3.getnewaddress(), 2000000)
w1.sendtoaddress(w4.getnewaddress(), 3000000) w1.sendtoaddress(w4.getnewaddress(), 3000000)
self.generatetoaddress( self.generatetoaddress(
node, node, nblocks=1, address=w1.getnewaddress(), sync_fun=self.no_op
nblocks=1, )
address=w1.getnewaddress(),
sync_fun=self.no_op)
assert_equal(w2.getbalance(), 1000000) assert_equal(w2.getbalance(), 1000000)
assert_equal(w3.getbalance(), 2000000) assert_equal(w3.getbalance(), 2000000)
assert_equal(w4.getbalance(), 3000000) assert_equal(w4.getbalance(), 3000000)
batch = w1.batch([w1.getblockchaininfo.get_request(), batch = w1.batch(
w1.getwalletinfo.get_request()]) [w1.getblockchaininfo.get_request(), w1.getwalletinfo.get_request()]
)
assert_equal(batch[0]["result"]["chain"], self.chain) assert_equal(batch[0]["result"]["chain"], self.chain)
assert_equal(batch[1]["result"]["walletname"], "w1") assert_equal(batch[1]["result"]["walletname"], "w1")
self.log.info('Check for per-wallet settxfee call') self.log.info("Check for per-wallet settxfee call")
assert_equal(w1.getwalletinfo()['paytxfee'], 0) assert_equal(w1.getwalletinfo()["paytxfee"], 0)
assert_equal(w2.getwalletinfo()['paytxfee'], 0) assert_equal(w2.getwalletinfo()["paytxfee"], 0)
w2.settxfee(1000) w2.settxfee(1000)
assert_equal(w1.getwalletinfo()['paytxfee'], 0) assert_equal(w1.getwalletinfo()["paytxfee"], 0)
assert_equal(w2.getwalletinfo()['paytxfee'], Decimal('1000.00')) assert_equal(w2.getwalletinfo()["paytxfee"], Decimal("1000.00"))
self.log.info("Test dynamic wallet loading") self.log.info("Test dynamic wallet loading")
self.restart_node(0, ['-nowallet']) self.restart_node(0, ["-nowallet"])
assert_equal(node.listwallets(), []) assert_equal(node.listwallets(), [])
assert_raises_rpc_error( assert_raises_rpc_error(
-18, -18,
(
"No wallet is loaded. Load a wallet using loadwallet or create a new" "No wallet is loaded. Load a wallet using loadwallet or create a new"
" one with createwallet. (Note: A default wallet is no longer " " one with createwallet. (Note: A default wallet is no longer "
"automatically created)", "automatically created)"
node.getwalletinfo ),
node.getwalletinfo,
) )
self.log.info("Load first wallet") self.log.info("Load first wallet")
loadwallet_name = node.loadwallet(wallet_names[0]) loadwallet_name = node.loadwallet(wallet_names[0])
assert_equal(loadwallet_name['name'], wallet_names[0]) assert_equal(loadwallet_name["name"], wallet_names[0])
assert_equal(node.listwallets(), wallet_names[0:1]) assert_equal(node.listwallets(), wallet_names[0:1])
node.getwalletinfo() node.getwalletinfo()
w1 = node.get_wallet_rpc(wallet_names[0]) w1 = node.get_wallet_rpc(wallet_names[0])
w1.getwalletinfo() w1.getwalletinfo()
self.log.info("Load second wallet") self.log.info("Load second wallet")
loadwallet_name = node.loadwallet(wallet_names[1]) loadwallet_name = node.loadwallet(wallet_names[1])
assert_equal(loadwallet_name['name'], wallet_names[1]) assert_equal(loadwallet_name["name"], wallet_names[1])
assert_equal(node.listwallets(), wallet_names[0:2]) assert_equal(node.listwallets(), wallet_names[0:2])
assert_raises_rpc_error(-19, assert_raises_rpc_error(-19, "Wallet file not specified", node.getwalletinfo)
"Wallet file not specified", node.getwalletinfo)
w2 = node.get_wallet_rpc(wallet_names[1]) w2 = node.get_wallet_rpc(wallet_names[1])
w2.getwalletinfo() w2.getwalletinfo()
self.log.info("Concurrent wallet loading") self.log.info("Concurrent wallet loading")
threads = [] threads = []
for _ in range(3): for _ in range(3):
n = node.cli if self.options.usecli else get_rpc_proxy( n = (
node.url, 1, timeout=600, coveragedir=node.coverage_dir) node.cli
if self.options.usecli
else get_rpc_proxy(
node.url, 1, timeout=600, coveragedir=node.coverage_dir
)
)
t = Thread( t = Thread(
target=test_load_unload, target=test_load_unload,
args=( args=(n, wallet_names[2], 20 * self.rpc_timeout),
n, )
wallet_names[2],
20 * self.rpc_timeout))
t.start() t.start()
threads.append(t) threads.append(t)
for t in threads: for t in threads:
t.join() t.join()
global got_loading_error global got_loading_error
assert_equal(got_loading_error, True) assert_equal(got_loading_error, True)
self.log.info("Load remaining wallets") self.log.info("Load remaining wallets")
for wallet_name in wallet_names[2:]: for wallet_name in wallet_names[2:]:
loadwallet_name = self.nodes[0].loadwallet(wallet_name) loadwallet_name = self.nodes[0].loadwallet(wallet_name)
assert_equal(loadwallet_name['name'], wallet_name) assert_equal(loadwallet_name["name"], wallet_name)
assert_equal(set(self.nodes[0].listwallets()), set(wallet_names)) assert_equal(set(self.nodes[0].listwallets()), set(wallet_names))
# Fail to load if wallet doesn't exist # Fail to load if wallet doesn't exist
path = os.path.join(self.options.tmpdir, "node0", "regtest", path = os.path.join(
"wallets", "wallets") self.options.tmpdir, "node0", "regtest", "wallets", "wallets"
)
assert_raises_rpc_error( assert_raises_rpc_error(
-18, -18,
f"Wallet file verification failed. Failed to load database path '{path}'. " (
"Path does not exist.", "Wallet file verification failed. Failed to load database path"
self.nodes[0].loadwallet, 'wallets') f" '{path}'. Path does not exist."
),
self.nodes[0].loadwallet,
"wallets",
)
# Fail to load duplicate wallets # Fail to load duplicate wallets
path = os.path.join( path = os.path.join(
self.options.tmpdir, self.options.tmpdir,
"node0", "node0",
"regtest", "regtest",
"wallets", "wallets",
"w1", "w1",
self.wallet_data_filename) self.wallet_data_filename,
)
assert_raises_rpc_error( assert_raises_rpc_error(
-4, -4,
(
"Wallet file verification failed. Refusing to load database. " "Wallet file verification failed. Refusing to load database. "
f"Data file '{path}' is already loaded.", f"Data file '{path}' is already loaded."
),
self.nodes[0].loadwallet, self.nodes[0].loadwallet,
wallet_names[0]) wallet_names[0],
)
# Fail to load duplicate wallets by different ways (directory and # Fail to load duplicate wallets by different ways (directory and
# filepath) # filepath)
path = os.path.join( path = os.path.join(
self.options.tmpdir, self.options.tmpdir,
"node0", "node0",
"regtest", "regtest",
"wallets", "wallets",
self.wallet_data_filename) self.wallet_data_filename,
)
assert_raises_rpc_error( assert_raises_rpc_error(
-4, -4,
(
"Wallet file verification failed. Refusing to load database. " "Wallet file verification failed. Refusing to load database. "
f"Data file '{path}' is already loaded.", f"Data file '{path}' is already loaded."
),
self.nodes[0].loadwallet, self.nodes[0].loadwallet,
self.wallet_data_filename) self.wallet_data_filename,
)
# Fail to load if one wallet is a copy of another # Fail to load if one wallet is a copy of another
assert_raises_rpc_error(-4, "BerkeleyDatabase: Can't open database w8_copy (duplicates fileid", assert_raises_rpc_error(
self.nodes[0].loadwallet, 'w8_copy') -4,
"BerkeleyDatabase: Can't open database w8_copy (duplicates fileid",
self.nodes[0].loadwallet,
"w8_copy",
)
# Fail to load if one wallet is a copy of another. # Fail to load if one wallet is a copy of another.
# Test this twice to make sure that we don't re-introduce # Test this twice to make sure that we don't re-introduce
# https://github.com/bitcoin/bitcoin/issues/14304 # https://github.com/bitcoin/bitcoin/issues/14304
assert_raises_rpc_error(-4, "BerkeleyDatabase: Can't open database w8_copy (duplicates fileid", assert_raises_rpc_error(
self.nodes[0].loadwallet, 'w8_copy') -4,
"BerkeleyDatabase: Can't open database w8_copy (duplicates fileid",
self.nodes[0].loadwallet,
"w8_copy",
)
# Fail to load if wallet file is a symlink # Fail to load if wallet file is a symlink
if os.name != 'nt': if os.name != "nt":
assert_raises_rpc_error( assert_raises_rpc_error(
-4, -4,
"Wallet file verification failed. Invalid -wallet path 'w8_symlink'", "Wallet file verification failed. Invalid -wallet path 'w8_symlink'",
self.nodes[0].loadwallet, self.nodes[0].loadwallet,
'w8_symlink') "w8_symlink",
)
# Fail to load if a directory is specified that doesn't contain a # Fail to load if a directory is specified that doesn't contain a
# wallet # wallet
os.mkdir(wallet_dir('empty_wallet_dir')) os.mkdir(wallet_dir("empty_wallet_dir"))
path = os.path.join(self.options.tmpdir, "node0", "regtest", path = os.path.join(
"wallets", "empty_wallet_dir") self.options.tmpdir, "node0", "regtest", "wallets", "empty_wallet_dir"
)
assert_raises_rpc_error( assert_raises_rpc_error(
-18, -18,
f"Wallet file verification failed. Failed to load database path '{path}'. " (
"Data is not in recognized format.", "Wallet file verification failed. Failed to load database path"
self.nodes[0].loadwallet, 'empty_wallet_dir') f" '{path}'. Data is not in recognized format."
),
self.nodes[0].loadwallet,
"empty_wallet_dir",
)
self.log.info("Test dynamic wallet creation.") self.log.info("Test dynamic wallet creation.")
# Fail to create a wallet if it already exists. # Fail to create a wallet if it already exists.
path = os.path.join(self.options.tmpdir, "node0", "regtest", path = os.path.join(self.options.tmpdir, "node0", "regtest", "wallets", "w2")
"wallets", "w2")
assert_raises_rpc_error( assert_raises_rpc_error(
-4, -4,
f"Failed to create database path '{path}'. Database already exists.", f"Failed to create database path '{path}'. Database already exists.",
self.nodes[0].createwallet, 'w2') self.nodes[0].createwallet,
"w2",
)
# Successfully create a wallet with a new name # Successfully create a wallet with a new name
loadwallet_name = self.nodes[0].createwallet('w9') loadwallet_name = self.nodes[0].createwallet("w9")
assert_equal(loadwallet_name['name'], 'w9') assert_equal(loadwallet_name["name"], "w9")
w9 = node.get_wallet_rpc('w9') w9 = node.get_wallet_rpc("w9")
assert_equal(w9.getwalletinfo()['walletname'], 'w9') assert_equal(w9.getwalletinfo()["walletname"], "w9")
assert 'w9' in self.nodes[0].listwallets() assert "w9" in self.nodes[0].listwallets()
# Successfully create a wallet using a full path # Successfully create a wallet using a full path
new_wallet_dir = os.path.join(self.options.tmpdir, 'new_walletdir') new_wallet_dir = os.path.join(self.options.tmpdir, "new_walletdir")
new_wallet_name = os.path.join(new_wallet_dir, 'w10') new_wallet_name = os.path.join(new_wallet_dir, "w10")
loadwallet_name = self.nodes[0].createwallet(new_wallet_name) loadwallet_name = self.nodes[0].createwallet(new_wallet_name)
assert_equal(loadwallet_name['name'], new_wallet_name) assert_equal(loadwallet_name["name"], new_wallet_name)
w10 = node.get_wallet_rpc(new_wallet_name) w10 = node.get_wallet_rpc(new_wallet_name)
assert_equal(w10.getwalletinfo()['walletname'], new_wallet_name) assert_equal(w10.getwalletinfo()["walletname"], new_wallet_name)
assert new_wallet_name in self.nodes[0].listwallets() assert new_wallet_name in self.nodes[0].listwallets()
self.log.info("Test dynamic wallet unloading") self.log.info("Test dynamic wallet unloading")
# Test `unloadwallet` errors # Test `unloadwallet` errors
assert_raises_rpc_error(-1, "JSON value is not a string as expected", assert_raises_rpc_error(
self.nodes[0].unloadwallet) -1, "JSON value is not a string as expected", self.nodes[0].unloadwallet
assert_raises_rpc_error(-18, "Requested wallet does not exist or is not loaded", )
self.nodes[0].unloadwallet, "dummy") assert_raises_rpc_error(
assert_raises_rpc_error(-18, "Requested wallet does not exist or is not loaded", -18,
node.get_wallet_rpc("dummy").unloadwallet) "Requested wallet does not exist or is not loaded",
assert_raises_rpc_error(-8, "Cannot unload the requested wallet", self.nodes[0].unloadwallet,
w1.unloadwallet, "w2"), "dummy",
)
assert_raises_rpc_error(
-18,
"Requested wallet does not exist or is not loaded",
node.get_wallet_rpc("dummy").unloadwallet,
)
assert_raises_rpc_error(
-8, "Cannot unload the requested wallet", w1.unloadwallet, "w2"
),
# Successfully unload the specified wallet name # Successfully unload the specified wallet name
self.nodes[0].unloadwallet("w1") self.nodes[0].unloadwallet("w1")
assert 'w1' not in self.nodes[0].listwallets() assert "w1" not in self.nodes[0].listwallets()
# Successfully unload the wallet referenced by the request endpoint # Successfully unload the wallet referenced by the request endpoint
# Also ensure unload works during walletpassphrase timeout # Also ensure unload works during walletpassphrase timeout
w2.encryptwallet('test') w2.encryptwallet("test")
w2.walletpassphrase('test', 1) w2.walletpassphrase("test", 1)
w2.unloadwallet() w2.unloadwallet()
time.sleep(1.1) time.sleep(1.1)
assert 'w2' not in self.nodes[0].listwallets() assert "w2" not in self.nodes[0].listwallets()
# Successfully unload all wallets # Successfully unload all wallets
for wallet_name in self.nodes[0].listwallets(): for wallet_name in self.nodes[0].listwallets():
self.nodes[0].unloadwallet(wallet_name) self.nodes[0].unloadwallet(wallet_name)
assert_equal(self.nodes[0].listwallets(), []) assert_equal(self.nodes[0].listwallets(), [])
assert_raises_rpc_error( assert_raises_rpc_error(
-18, -18,
(
"No wallet is loaded. Load a wallet using loadwallet or create a new" "No wallet is loaded. Load a wallet using loadwallet or create a new"
" one with createwallet. (Note: A default wallet is no longer " " one with createwallet. (Note: A default wallet is no longer "
"automatically created)", "automatically created)"
self.nodes[0].getwalletinfo ),
self.nodes[0].getwalletinfo,
) )
# Successfully load a previously unloaded wallet # Successfully load a previously unloaded wallet
self.nodes[0].loadwallet('w1') self.nodes[0].loadwallet("w1")
assert_equal(self.nodes[0].listwallets(), ['w1']) assert_equal(self.nodes[0].listwallets(), ["w1"])
assert_equal(w1.getwalletinfo()['walletname'], 'w1') assert_equal(w1.getwalletinfo()["walletname"], "w1")
assert_equal( assert_equal(
sorted(w['name'] for w in self.nodes[0].listwalletdir()['wallets']), sorted(w["name"] for w in self.nodes[0].listwalletdir()["wallets"]),
[self.default_wallet_name, os.path.join('sub', 'w5'), 'w', 'w1', 'w2', [
'w3', 'w7', 'w7_symlink', 'w8', 'w8_copy', 'w9']) self.default_wallet_name,
os.path.join("sub", "w5"),
"w",
"w1",
"w2",
"w3",
"w7",
"w7_symlink",
"w8",
"w8_copy",
"w9",
],
)
# Test backing up and restoring wallets # Test backing up and restoring wallets
self.log.info("Test wallet backup") self.log.info("Test wallet backup")
self.restart_node(0, ['-nowallet']) self.restart_node(0, ["-nowallet"])
for wallet_name in wallet_names: for wallet_name in wallet_names:
self.nodes[0].loadwallet(wallet_name) self.nodes[0].loadwallet(wallet_name)
for wallet_name in wallet_names: for wallet_name in wallet_names:
rpc = self.nodes[0].get_wallet_rpc(wallet_name) rpc = self.nodes[0].get_wallet_rpc(wallet_name)
addr = rpc.getnewaddress() addr = rpc.getnewaddress()
backup = os.path.join(self.options.tmpdir, 'backup.dat') backup = os.path.join(self.options.tmpdir, "backup.dat")
rpc.backupwallet(backup) rpc.backupwallet(backup)
self.nodes[0].unloadwallet(wallet_name) self.nodes[0].unloadwallet(wallet_name)
shutil.copyfile(empty_wallet, wallet_file(wallet_name)) shutil.copyfile(empty_wallet, wallet_file(wallet_name))
self.nodes[0].loadwallet(wallet_name) self.nodes[0].loadwallet(wallet_name)
assert_equal(rpc.getaddressinfo(addr)['ismine'], False) assert_equal(rpc.getaddressinfo(addr)["ismine"], False)
self.nodes[0].unloadwallet(wallet_name) self.nodes[0].unloadwallet(wallet_name)
shutil.copyfile(backup, wallet_file(wallet_name)) shutil.copyfile(backup, wallet_file(wallet_name))
self.nodes[0].loadwallet(wallet_name) self.nodes[0].loadwallet(wallet_name)
assert_equal(rpc.getaddressinfo(addr)['ismine'], True) assert_equal(rpc.getaddressinfo(addr)["ismine"], True)
# Test .walletlock file is closed # Test .walletlock file is closed
self.start_node(1) self.start_node(1)
wallet = os.path.join(self.options.tmpdir, 'my_wallet') wallet = os.path.join(self.options.tmpdir, "my_wallet")
self.nodes[0].createwallet(wallet) self.nodes[0].createwallet(wallet)
assert_raises_rpc_error(-4, "Error initializing wallet database environment", assert_raises_rpc_error(
self.nodes[1].loadwallet, wallet) -4,
"Error initializing wallet database environment",
self.nodes[1].loadwallet,
wallet,
)
self.nodes[0].unloadwallet(wallet) self.nodes[0].unloadwallet(wallet)
self.nodes[1].loadwallet(wallet) self.nodes[1].loadwallet(wallet)
if __name__ == '__main__': if __name__ == "__main__":
MultiWalletTest().main() MultiWalletTest().main()