Changeset View
Changeset View
Standalone View
Standalone View
src/dstencode.h
| #ifndef BITCOIN_DSTENCODE_H | #ifndef BITCOIN_DSTENCODE_H | ||||
| #define BITCOIN_DSTENCODE_H | #define BITCOIN_DSTENCODE_H | ||||
| // key.h and pubkey.h are not used here, but gcc doesn't want to instantiate | // key.h and pubkey.h are not used here, but gcc doesn't want to instantiate | ||||
| // CTxDestination if types are unknown | // CTxDestination if types are unknown | ||||
| #include "key.h" | #include "key.h" | ||||
| #include "pubkey.h" | #include "pubkey.h" | ||||
| #include "script/standard.h" | #include "script/standard.h" | ||||
| #include <string> | #include <string> | ||||
| class Config; | class Config; | ||||
| class CChainParams; | class CChainParams; | ||||
| std::string EncodeDestination(const CTxDestination &dest, const Config &config); | std::string EncodeDestination(const CTxDestination &dest, const Config &config); | ||||
| CTxDestination DecodeDestination(const std::string &addr, const CChainParams &); | CTxDestination DecodeDestination(const std::string &addr, const Config &); | ||||
jasonbcox: End of this line looks very inconsistent without a variable name. Please add one even though… | |||||
| bool IsValidDestinationString(const std::string &addr, | bool IsValidDestinationString(const std::string &addr, const Config &config); | ||||
deadalnixUnsubmitted Not Done Inline ActionsWho do these need to take a config ? This seems like it si creating a ton of code churn for no good reason. deadalnix: Who do these need to take a config ? This seems like it si creating a ton of code churn for no… | |||||
| const CChainParams ¶ms); | |||||
| // Temporary workaround. Don't rely on global state, pass all parameters in new | |||||
| // code. | |||||
| std::string EncodeDestination(const CTxDestination &); | |||||
| #endif // BITCOIN_DSTENCODE_H | #endif // BITCOIN_DSTENCODE_H | ||||
End of this line looks very inconsistent without a variable name. Please add one even though there wasn't before. :)