Differential D2188 Diff 6334 test/functional/abc-sync-chain.py

Changeset View

Standalone View

test/functional/abc-sync-chain.py

This file was added.

Property	Old Value	New Value
File Mode	null	100755

				#!/usr/bin/env python3
				# Copyright (c) 2018 The Bitcoin developers
				# Distributed under the MIT software license, see the accompanying
				# file COPYING or http://www.opensource.org/licenses/mit-license.php.

				"""
				Test that a node receiving many (potentially out of order) blocks exits
				initial block download (IBD; this occurs once it has passed minimumchainwork)
				and continues to sync without seizing.
				"""

				import os
				FabienUnsubmitted Done Inline Actions Not required Fabien: Not required
				import random

				from test_framework.blocktools import (create_block, create_coinbase)
				FabienUnsubmitted Done Inline Actions Could you whether remove the parenthesis or use it everywhere when there is no line break involved ? Fabien: Could you whether remove the parenthesis or use it everywhere when there is no line break…
				from test_framework.mininode import (CBlockHeader,
				NetworkThread,
				NodeConn,
				NodeConnCB,
				msg_block,
				msg_headers)
				from test_framework.test_framework import BitcoinTestFramework
				from test_framework.util import assert_equal, wait_until, p2p_port


				NUM_IBD_BLOCKS = 50


				class BaseNode(NodeConnCB):
				def send_header(self, block):
				msg = msg_headers()
				msg.headers = [CBlockHeader(block)]
				self.send_message(msg)

				def send_block(self, block):
				self.send_message(msg_block(block))


				class SyncChainTest(BitcoinTestFramework):
				def set_test_params(self):
				self.num_nodes = 1
				# Setting minimumchainwork makes sure we test IBD as well as post-IBD
				self.extra_args = [["-minimumchainwork=%s" %
				FabienUnsubmitted Done Inline Actions I would advise you to use the new format() method, like this: `"-minimumchainwork={:#x}".format(202 + 2 * NUM_IBD_BLOCKS)` which is intended to replace the % string format Fabien: I would advise you to use the new format() method, like this: `"-minimumchainwork={:#x}".format…
				hex(202 + 2 * NUM_IBD_BLOCKS)]]
				FabienUnsubmitted Not Done Inline Actions Shouldn't it be `200 + NUM_IBD_BLOCKS` to have half the blocks during IBD and half the blocks outside of IBD ? Fabien: Shouldn't it be `200 + NUM_IBD_BLOCKS` to have half the blocks during IBD and half the blocks…
				jasonbcoxAuthorUnsubmitted Done Inline Actions I ran the test with NUM_IBD_BLOCKS set at 50 and got 404 chainwork at the end of the test. From this, I figured the chainwork per block was 2. jasonbcox: I ran the test with NUM_IBD_BLOCKS set at 50 and got 404 chainwork at the end of the test. From…

				def run_test(self):
				node0conn = BaseNode()
				connections = []
				connections.append(
				NodeConn('127.0.0.1', p2p_port(0), self.nodes[0], node0conn))
				node0conn.add_connection(connections[0])
				FabienUnsubmitted Done Inline Actions This can be simplified: `node0conn.add_connection(NodeConn('127.0.0.1', p2p_port(0), self.nodes[0], node0conn))` Fabien: This can be simplified: `node0conn.add_connection(NodeConn('127.0.0.1', p2p_port(0), self.nodes…

				NetworkThread().start()
				node0conn.wait_for_verack()

				node0 = self.nodes[0]

				tip = int(node0.getbestblockhash(), 16)
				height = node0.getblockcount() + 1
				time = node0.getblock(node0.getbestblockhash())['time'] + 1

				blocks = []
				for i in range(NUM_IBD_BLOCKS * 2):
				block = create_block(tip, create_coinbase(height), time)
				block.solve()
				blocks.append(block)
				tip = block.sha256
				height += 1
				time += 1

				# Headers need to be sent in-order
				for b in blocks:
				node0conn.send_header(b)

				# Send blocks in some random order
				for b in random.sample(blocks, len(blocks)):
				node0conn.send_block(b)

				# The node should eventually, completely sync without getting stuck
				def node_synced():
				return node0.getbestblockhash() == blocks[len(blocks) - 1].hash
				FabienUnsubmitted Done Inline Actions `blocks[len(blocks) - 1]` => `blocks[-1]` Fabien: `blocks[len(blocks) - 1]` => `blocks[-1]`
				wait_until(node_synced)


				if __name__ == '__main__':
				SyncChainTest().main()