Changeset View
Changeset View
Standalone View
Standalone View
src/test/net_tests.cpp
Show First 20 Lines • Show All 205 Lines • ▼ Show 20 Lines | versionMessage << "/Bitcoin ABC:" << CLIENT_VERSION_MAJOR << "." | ||||
"very very very very very very very very very very very " | "very very very very very very very very very very very " | ||||
"very very very very very very very very very very very " | "very very very very very very very very very very very " | ||||
"very very very very very very very ve)/"; | "very very very very very very very ve)/"; | ||||
BOOST_CHECK_EQUAL(userAgent(config).size(), MAX_SUBVERSION_LENGTH); | BOOST_CHECK_EQUAL(userAgent(config).size(), MAX_SUBVERSION_LENGTH); | ||||
BOOST_CHECK_EQUAL(userAgent(config), versionMessage.str()); | BOOST_CHECK_EQUAL(userAgent(config), versionMessage.str()); | ||||
} | } | ||||
BOOST_AUTO_TEST_CASE(test_userAgentSanitize) { | |||||
GlobalConfig config; | |||||
jasonbcox: I'd like to move away from using GlobalConfig in tests unless absolutely necessary. Please use… | |||||
config.SetMaxBlockSize(32000000); | |||||
jasonbcoxUnsubmitted Not Done Inline ActionsThis line should be unnecessary. jasonbcox: This line should be unnecessary. | |||||
FabienAuthorUnsubmitted Done Inline ActionsAt the moment you're right, but this will prevent failing the test if the default block size gets increased, so I'd better leave it Fabien: At the moment you're right, but this will prevent failing the test if the default block size… | |||||
gArgs.ClearMultiArg("-uacomment"); | |||||
const std::string goodua = "A valid user agent comment .,;-_?@"; | |||||
gArgs.ForceSetMultiArg("-uacomment", goodua); | |||||
std::ostringstream goodSubversion; | |||||
goodSubversion << "/Bitcoin ABC:" << CLIENT_VERSION_MAJOR << "." | |||||
<< CLIENT_VERSION_MINOR << "." << CLIENT_VERSION_REVISION | |||||
<< "(EB32.0; " << goodua << ")/"; | |||||
BOOST_CHECK_EQUAL(userAgent(config), goodSubversion.str()); | |||||
gArgs.ClearMultiArg("-uacomment"); | |||||
const std::string badua = "A bad user agent comment /+:!"; | |||||
gArgs.ForceSetMultiArg("-uacomment", badua); | |||||
std::ostringstream sanSubversion; | |||||
sanSubversion << "/Bitcoin ABC:" << CLIENT_VERSION_MAJOR << "." | |||||
<< CLIENT_VERSION_MINOR << "." << CLIENT_VERSION_REVISION | |||||
<< "(EB32.0; A bad user agent comment )/"; | |||||
BOOST_CHECK_EQUAL(userAgent(config), sanSubversion.str()); | |||||
} | |||||
BOOST_AUTO_TEST_SUITE_END() | BOOST_AUTO_TEST_SUITE_END() |
I'd like to move away from using GlobalConfig in tests unless absolutely necessary. Please use DummyConfig.