Differential D2616 Diff 7577 src/rpc/commandwithargscontext.h

Changeset View

Standalone View

				// Copyright (c) 2018-2019 The Bitcoin developers
				// Distributed under the MIT software license, see the accompanying
				// file COPYING or http://www.opensource.org/licenses/mit-license.php.

				#ifndef BITCOIN_RPC_COMMAND_WITH_ARGS_CONTEXT_H
				#define BITCOIN_RPC_COMMAND_WITH_ARGS_CONTEXT_H

				#include "commandwithrequestcontext.h"
				#include "jsonrpcrequest.h"

				#include <univalue.h>

				#include <boost/noncopyable.hpp>

				#include <string>

				/**
				* By default, use RPCCommandWithArgsContext as the parent class for new RPC
				* command classes that only depend on RPC arguments.
				*/
				class RPCCommandWithArgsContext : public RPCCommandWithRequestContext {
				public:
				RPCCommandWithArgsContext(std::string nameIn)
				: RPCCommandWithRequestContext(nameIn) {}

				virtual UniValue Execute(const UniValue &args) const = 0;

				UniValue Execute(const JSONRPCRequest &request) const final {
				return Execute(request.params);
				deadalnixUnsubmitted Not Done Inline Actions You can just move that in an implementation file and be done with it instead of putting it int he header, especially since you expect that no user of this class will actually use `JSONRPCRequest` (it's the whole point of the class to begin with). deadalnix: You can just move that in an implementation file and be done with it instead of putting it int…
				}
				};

				#endif // BITCOIN_RPC_COMMAND_WITH_ARGS_CONTEXT_H