Changeset View
Changeset View
Standalone View
Standalone View
src/miner.h
Show All 28 Lines | struct CBlockTemplateEntry { | ||||
//!< Total real fees paid by the transaction and cached to avoid parent | //!< Total real fees paid by the transaction and cached to avoid parent | ||||
//!< lookup | //!< lookup | ||||
Amount txFee; | Amount txFee; | ||||
//!< Cached total size of the transaction to avoid reserializing transaction | //!< Cached total size of the transaction to avoid reserializing transaction | ||||
size_t txSize; | size_t txSize; | ||||
//!< Cached total number of SigOps | //!< Cached total number of SigOps | ||||
uint64_t txSigOps; | uint64_t txSigOps; | ||||
//!< Track the "order" of a transaction in a package. | |||||
//!< Higher means it has more dependencies. | |||||
uint64_t packageOrder; | |||||
jasonbcox: I have no sense of scale for this value. Is order == # of dependencies? If so, why not just… | |||||
jasonbcoxUnsubmitted Not Done Inline ActionsAlso: There should be a comment in this diff or the summary with a link to the other diff where this is used so reviewers can appropriate evaluate it. Otherwise we're just looking at variable names with no context. jasonbcox: Also: There should be a comment in this diff or the summary with a link to the other diff where… | |||||
schancelAuthorUnsubmitted Done Inline ActionsThere is a stack of all the diffs provided. schancel: There is a stack of all the diffs provided. | |||||
//!< Estimated package fees (>= real size. Note: This will be offset by | |||||
//!< double counting size as well in certain cases) | |||||
jasonbcoxUnsubmitted Not Done Inline ActionsThe note is the only reference to double counting. There needs to be an explanation in this comment for this behavior otherwise the (>= real size) comments mean nothing without that context. jasonbcox: The note is the only reference to double counting. There needs to be an explanation in this… | |||||
Amount packageFee; | |||||
//!< Estimated package size (>= real size) | |||||
size_t packageSize; | |||||
//!< Estimated package Sigops (>= real size) | |||||
uint64_t packageSigOps; | |||||
CBlockTemplateEntry(CTransactionRef _tx, Amount _fees, uint64_t _size, | CBlockTemplateEntry(CTransactionRef _tx, Amount _fees, uint64_t _size, | ||||
int64_t _sigOps) | int64_t _sigOps) | ||||
: tx(_tx), txFee(_fees), txSize(_size), txSigOps(_sigOps) {} | : tx(_tx), txFee(_fees), txSize(_size), txSigOps(_sigOps), | ||||
packageOrder(1), packageFee(_fees), packageSize(_size), | |||||
packageSigOps(_sigOps) {} | |||||
}; | }; | ||||
struct CBlockTemplate { | struct CBlockTemplate { | ||||
CBlock block; | CBlock block; | ||||
std::vector<CBlockTemplateEntry> entries; | std::vector<CBlockTemplateEntry> entries; | ||||
}; | }; | ||||
▲ Show 20 Lines • Show All 196 Lines • Show Last 20 Lines |
I have no sense of scale for this value. Is order == # of dependencies? If so, why not just call it pacakageDependencies?