Page MenuHomePhabricator
Differential D3331 Diff 9425 src/script/sigencoding.cpp

Changeset View

Standalone View

View Options

src/script/sigencoding.cpp

Show First 20 Lines • Show All 150 Lines • ▼ Show 20 Linesstatic bool IsValidDERSignatureEncoding(const slicedvaltype &sig) {
} }
return true; return true;
} }
static bool CheckRawECDSASignatureEncoding(const slicedvaltype &sig, static bool CheckRawECDSASignatureEncoding(const slicedvaltype &sig,
uint32_t flags, uint32_t flags,
ScriptError *serror) { ScriptError *serror) {
if ((flags & SCRIPT_ENABLE_SCHNORR) && (sig.size() == 64)) { if (sig.size() == 64) {
// In an ECDSA-only context, 64-byte signatures are banned when // In an ECDSA-only context, 64-byte signatures are forbidden.
// Schnorr flag set.
return set_error(serror, SCRIPT_ERR_SIG_BADLENGTH); return set_error(serror, SCRIPT_ERR_SIG_BADLENGTH);
} }
if ((flags & (SCRIPT_VERIFY_DERSIG | SCRIPT_VERIFY_LOW_S | if ((flags & (SCRIPT_VERIFY_DERSIG | SCRIPT_VERIFY_LOW_S |
SCRIPT_VERIFY_STRICTENC)) && SCRIPT_VERIFY_STRICTENC)) &&
!IsValidDERSignatureEncoding(sig)) { !IsValidDERSignatureEncoding(sig)) {
return set_error(serror, SCRIPT_ERR_SIG_DER); return set_error(serror, SCRIPT_ERR_SIG_DER);
} }
if ((flags & SCRIPT_VERIFY_LOW_S) && !CPubKey::CheckLowS(sig)) { if ((flags & SCRIPT_VERIFY_LOW_S) && !CPubKey::CheckLowS(sig)) {
return set_error(serror, SCRIPT_ERR_SIG_HIGH_S); return set_error(serror, SCRIPT_ERR_SIG_HIGH_S);
} }
return true; return true;
} }
static bool CheckRawSignatureEncoding(const slicedvaltype &sig, uint32_t flags, static bool CheckRawSignatureEncoding(const slicedvaltype &sig, uint32_t flags,
ScriptError *serror) { ScriptError *serror) {
if ((flags & SCRIPT_ENABLE_SCHNORR) && (sig.size() == 64)) { if (sig.size() == 64) {
// In a generic-signature context, 64-byte signatures are interpreted // In a generic-signature context, 64-byte signatures are interpreted
// as Schnorr signatures (always correctly encoded) when flag set. // as Schnorr signatures (which are never incorrectly encoded).
jasonbcoxUnsubmitted
Done
Inline Actions

The double-negative doesn't help. I think the parentheses can be reworded or removed all together.

jasonbcox: The double-negative doesn't help. I think the parentheses can be reworded or removed all…
return true; return true;
} }
return CheckRawECDSASignatureEncoding(sig, flags, serror); return CheckRawECDSASignatureEncoding(sig, flags, serror);
} }
bool CheckDataSignatureEncoding(const valtype &vchSig, uint32_t flags, bool CheckDataSignatureEncoding(const valtype &vchSig, uint32_t flags,
ScriptError *serror) { ScriptError *serror) {
// Empty signature. Not strictly DER encoded, but allowed to provide a // Empty signature. Not strictly DER encoded, but allowed to provide a
▲ Show 20 Lines • Show All 114 Lines • Show Last 20 Lines