Page MenuHomePhabricator
Differential D3363 Diff 9647 src/bench/data/convert-raw-to-header.sh

Changeset View

Standalone View

View Options

src/bench/data/convert-raw-to-header.sh

  • This file was added.
PropertyOld ValueNew Value
File Modenull100755
#!/usr/bin/env bash
INPUT_BASENAME=$(basename ${1})
{
echo "static unsigned const char ${INPUT_BASENAME%.*}[] = {" && \
hexdump -v -e '8/1 "0x%02x, "' -e '"\n"' ${1} | sed -e 's/0x ,//g' && \
deadalnixUnsubmitted
Not Done
Inline Actions

There are no dependency on hexdump. I don't understand why the approach taken by src/test/data/generate_header.py is not preferable.

deadalnix: There are no dependency on hexdump. I don't understand why the approach taken by…
FabienAuthorUnsubmitted
Done
Inline Actions

The dependency exists as long as autotools is still supported, the script is just the direct translation of the Makefile.bench.include scipt (only special autotools variables names are adapted).
That said, I don't think the generate_headers.py solution (translation of the bash script to a python script) is worst, it's even a better long-term solution as it effectively removes the hexdump dependency when autotools support gets dropped. I will do the translation.

Fabien: The dependency exists as long as autotools is still supported, the script is just the direct…
echo "};"; \
}