Changeset View
Changeset View
Standalone View
Standalone View
test/functional/abc-schnorr.py
| #!/usr/bin/env python3 | #!/usr/bin/env python3 | ||||
| # Copyright (c) 2019 The Bitcoin developers | # Copyright (c) 2019 The Bitcoin developers | ||||
| # Distributed under the MIT software license, see the accompanying | # Distributed under the MIT software license, see the accompanying | ||||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | # file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||||
| """ | """ | ||||
| This tests the treatment of Schnorr transaction signatures: | This tests the treatment of Schnorr transaction signatures: | ||||
| - acceptance both in mempool and blocks. | - acceptance both in mempool and blocks. | ||||
| - check banning for peers who send txns with 64 byte ECDSA DER sigs. | - check banning for peers who send txns with 64 byte ECDSA DER sigs. | ||||
| Derived from a variety of functional tests. | Derived from a variety of functional tests. | ||||
| """ | """ | ||||
| import time | |||||
| from test_framework.blocktools import ( | from test_framework.blocktools import ( | ||||
| create_block, | create_block, | ||||
| create_coinbase, | create_coinbase, | ||||
| create_transaction, | create_transaction, | ||||
| make_conform_to_ctor, | make_conform_to_ctor, | ||||
| ) | ) | ||||
| from test_framework.key import CECKey | from test_framework.key import CECKey | ||||
| from test_framework.messages import ( | from test_framework.messages import ( | ||||
| COIN, | CBlock, | ||||
| COutPoint, | COutPoint, | ||||
| CTransaction, | CTransaction, | ||||
| CTxIn, | CTxIn, | ||||
| CTxOut, | CTxOut, | ||||
| FromHex, | |||||
| ToHex, | ToHex, | ||||
| ) | ) | ||||
| from test_framework.mininode import ( | from test_framework.mininode import ( | ||||
| network_thread_join, | network_thread_join, | ||||
| network_thread_start, | network_thread_start, | ||||
| P2PDataStore, | P2PDataStore, | ||||
| ) | ) | ||||
| from test_framework import schnorr | from test_framework import schnorr | ||||
| Show All 17 Lines | |||||
| RPC_NULLFAIL_ERROR = 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)' | RPC_NULLFAIL_ERROR = 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)' | ||||
| # This 64-byte signature is used to test exclusion & banning according to | # This 64-byte signature is used to test exclusion & banning according to | ||||
| # the above error messages. | # the above error messages. | ||||
| # Tests of real 64 byte ECDSA signatures can be found in script_tests. | # Tests of real 64 byte ECDSA signatures can be found in script_tests. | ||||
| sig64 = b'\0'*64 | sig64 = b'\0'*64 | ||||
| class PreviousSpendableOutput(object): | |||||
| def __init__(self, tx=CTransaction(), n=-1): | |||||
| self.tx = tx | |||||
| self.n = n | |||||
| class SchnorrTest(BitcoinTestFramework): | class SchnorrTest(BitcoinTestFramework): | ||||
| def set_test_params(self): | def set_test_params(self): | ||||
| self.num_nodes = 1 | self.num_nodes = 1 | ||||
| self.setup_clean_chain = True | |||||
| self.block_heights = {} | self.block_heights = {} | ||||
| self.tip = None | |||||
| self.blocks = {} | |||||
| def next_block(self, number, transactions=None, nTime=None): | |||||
| if self.tip == None: | |||||
| base_block_hash = self.genesis_hash | |||||
| block_time = int(time.time()) + 1 | |||||
| else: | |||||
| base_block_hash = self.tip.sha256 | |||||
| block_time = self.tip.nTime + 1 | |||||
| if nTime: | |||||
| block_time = nTime | |||||
| # First create the coinbase | |||||
| height = self.block_heights[base_block_hash] + 1 | |||||
| coinbase = create_coinbase(height) | |||||
| coinbase.rehash() | |||||
| block = create_block(base_block_hash, coinbase, block_time) | |||||
| # add in transactions | |||||
| if transactions: | |||||
| block.vtx.extend(transactions) | |||||
| make_conform_to_ctor(block) | |||||
| block.hashMerkleRoot = block.calc_merkle_root() | |||||
| # Do PoW, which is cheap on regnet | |||||
| block.solve() | |||||
| self.tip = block | |||||
| self.block_heights[block.sha256] = height | |||||
| assert number not in self.blocks | |||||
| self.blocks[number] = block | |||||
| return block | |||||
| def bootstrap_p2p(self, *, num_connections=1): | def bootstrap_p2p(self, *, num_connections=1): | ||||
| """Add a P2P connection to the node. | """Add a P2P connection to the node. | ||||
| Helper to connect and wait for version handshake.""" | Helper to connect and wait for version handshake.""" | ||||
| for _ in range(num_connections): | for _ in range(num_connections): | ||||
| self.nodes[0].add_p2p_connection(P2PDataStore()) | self.nodes[0].add_p2p_connection(P2PDataStore()) | ||||
| network_thread_start() | network_thread_start() | ||||
| self.nodes[0].p2p.wait_for_verack() | self.nodes[0].p2p.wait_for_verack() | ||||
| def reconnect_p2p(self, **kwargs): | def reconnect_p2p(self, **kwargs): | ||||
| """Tear down and bootstrap the P2P connection to the node. | """Tear down and bootstrap the P2P connection to the node. | ||||
| The node gets disconnected several times in this test. This helper | The node gets disconnected several times in this test. This helper | ||||
| method reconnects the p2p and restarts the network thread.""" | method reconnects the p2p and restarts the network thread.""" | ||||
| self.nodes[0].disconnect_p2ps() | self.nodes[0].disconnect_p2ps() | ||||
| network_thread_join() | network_thread_join() | ||||
| self.bootstrap_p2p(**kwargs) | self.bootstrap_p2p(**kwargs) | ||||
| def getbestblock(self, node): | |||||
| """Get the best block. Register its height so we can use build_block.""" | |||||
| block_height = node.getblockcount() | |||||
| blockhash = node.getblockhash(block_height) | |||||
| block = FromHex(CBlock(), node.getblock(blockhash, 0)) | |||||
| block.calc_sha256() | |||||
| self.block_heights[block.sha256] = block_height | |||||
| return block | |||||
| def build_block(self, parent, transactions=(), nTime=None): | |||||
| """Make a new block with an OP_1 coinbase output. | |||||
| Requires parent to have its height registered.""" | |||||
| parent.calc_sha256() | |||||
| block_height = self.block_heights[parent.sha256] + 1 | |||||
| block_time = (parent.nTime + 1) if nTime is None else nTime | |||||
| block = create_block( | |||||
| parent.sha256, create_coinbase(block_height), block_time) | |||||
| block.vtx.extend(transactions) | |||||
| make_conform_to_ctor(block) | |||||
| block.hashMerkleRoot = block.calc_merkle_root() | |||||
| block.solve() | |||||
| self.block_heights[block.sha256] = block_height | |||||
| return block | |||||
| def check_for_ban_on_rejected_block(self, block, reject_code=None, reject_reason=None): | |||||
| """Check we are disconnected when sending a block that the node rejects. | |||||
| (Can't actually get banned, since bitcoind won't ban local peers.)""" | |||||
| self.nodes[0].p2p.send_blocks_and_test( | |||||
| [block], self.nodes[0], success=False, reject_code=reject_code, reject_reason=reject_reason) | |||||
| self.nodes[0].p2p.wait_for_disconnect() | |||||
| self.reconnect_p2p() | |||||
| def run_test(self): | def run_test(self): | ||||
| node, = self.nodes | |||||
| self.bootstrap_p2p() | self.bootstrap_p2p() | ||||
| self.genesis_hash = int(self.nodes[0].getbestblockhash(), 16) | |||||
| self.block_heights[self.genesis_hash] = 0 | |||||
| spendable_outputs = [] | |||||
| # shorthand | |||||
| block = self.next_block | |||||
| node = self.nodes[0] | |||||
| # save the current tip so its coinbase can be spent by a later block | |||||
| def save_spendable_output(): | |||||
| spendable_outputs.append(self.tip) | |||||
| # get a coinbase that we previously marked as spendable | |||||
| def get_spendable_output(): | |||||
| return PreviousSpendableOutput(spendable_outputs.pop(0).vtx[0], 0) | |||||
| # submit current tip and check it was accepted | |||||
| def accepted(): | |||||
| node.p2p.send_blocks_and_test([self.tip], node) | |||||
| # submit current tip and check it was rejected (and we are banned) | |||||
| def rejected(reject_code, reject_reason): | |||||
| node.p2p.send_blocks_and_test( | |||||
| [self.tip], node, success=False, reject_code=reject_code, reject_reason=reject_reason) | |||||
| node.p2p.wait_for_disconnect() | |||||
| self.reconnect_p2p() | |||||
| # move the tip back to a previous block | tip = self.getbestblock(node) | ||||
| def tip(number): | |||||
| self.tip = self.blocks[number] | |||||
| self.log.info("Create some blocks with OP_1 coinbase for spending.") | self.log.info("Create some blocks with OP_1 coinbase for spending.") | ||||
| blocks = [] | |||||
| for _ in range(10): | |||||
| tip = self.build_block(tip) | |||||
| blocks.append(tip) | |||||
| node.p2p.send_blocks_and_test(blocks, node, success=True) | |||||
| out = [block.vtx[0] for block in blocks] | |||||
| self.log.info("Mature the blocks and get out of IBD.") | |||||
| node.generate(100) | |||||
| # Create a new block | tip = self.getbestblock(node) | ||||
| block(0) | |||||
| save_spendable_output() | |||||
| accepted() | |||||
| # Now we need that block to mature so we can spend the coinbase. | |||||
| matureblocks = [] | |||||
| for i in range(199): | |||||
| block(5000 + i) | |||||
| matureblocks.append(self.tip) | |||||
| save_spendable_output() | |||||
| node.p2p.send_blocks_and_test(matureblocks, node) | |||||
| # collect spendable outputs now to avoid cluttering the code later on | |||||
| out = [] | |||||
| for i in range(100): | |||||
| out.append(get_spendable_output()) | |||||
| self.log.info("Setting up spends to test and mining the fundings.") | self.log.info("Setting up spends to test and mining the fundings.") | ||||
| # Generate a key pair | # Generate a key pair | ||||
| privkeybytes = b"Schnorr!" * 4 | privkeybytes = b"Schnorr!" * 4 | ||||
| private_key = CECKey() | private_key = CECKey() | ||||
| private_key.set_secretbytes(privkeybytes) | private_key.set_secretbytes(privkeybytes) | ||||
| # get uncompressed public key serialization | # get uncompressed public key serialization | ||||
| public_key = private_key.get_pubkey() | public_key = private_key.get_pubkey() | ||||
| def create_fund_and_spend_tx(spend, multi=False, sig='schnorr'): | def create_fund_and_spend_tx(spend, multi=False, sig='schnorr'): | ||||
| if multi: | if multi: | ||||
| script = CScript([OP_1, public_key, OP_1, OP_CHECKMULTISIG]) | script = CScript([OP_1, public_key, OP_1, OP_CHECKMULTISIG]) | ||||
| else: | else: | ||||
| script = CScript([public_key, OP_CHECKSIG]) | script = CScript([public_key, OP_CHECKSIG]) | ||||
| value = spend.vout[0].nValue | |||||
| # Fund transaction | # Fund transaction | ||||
| txfund = create_transaction( | txfund = create_transaction(spend, 0, b'', value, script) | ||||
| spend.tx, spend.n, b'', 50 * COIN, script) | |||||
| txfund.rehash() | txfund.rehash() | ||||
| # Spend transaction | # Spend transaction | ||||
| txspend = CTransaction() | txspend = CTransaction() | ||||
| txspend.vout.append( | txspend.vout.append( | ||||
| CTxOut(50 * COIN - 1000, CScript([OP_TRUE]))) | CTxOut(value-1000, CScript([OP_TRUE]))) | ||||
| txspend.vin.append( | txspend.vin.append( | ||||
| CTxIn(COutPoint(txfund.sha256, 0), b'')) | CTxIn(COutPoint(txfund.sha256, 0), b'')) | ||||
| # Sign the transaction | # Sign the transaction | ||||
| sighashtype = SIGHASH_ALL | SIGHASH_FORKID | sighashtype = SIGHASH_ALL | SIGHASH_FORKID | ||||
| hashbyte = bytes([sighashtype & 0xff]) | hashbyte = bytes([sighashtype & 0xff]) | ||||
| sighash = SignatureHashForkId( | sighash = SignatureHashForkId( | ||||
| script, txspend, 0, sighashtype, 50 * COIN) | script, txspend, 0, sighashtype, value) | ||||
| if sig == 'schnorr': | if sig == 'schnorr': | ||||
| txsig = schnorr.sign(privkeybytes, sighash) + hashbyte | txsig = schnorr.sign(privkeybytes, sighash) + hashbyte | ||||
| elif sig == 'ecdsa': | elif sig == 'ecdsa': | ||||
| txsig = private_key.sign(sighash) + hashbyte | txsig = private_key.sign(sighash) + hashbyte | ||||
| elif isinstance(sig, bytes): | elif isinstance(sig, bytes): | ||||
| txsig = sig + hashbyte | txsig = sig + hashbyte | ||||
| if multi: | if multi: | ||||
| txspend.vin[0].scriptSig = CScript([b'', txsig]) | txspend.vin[0].scriptSig = CScript([b'', txsig]) | ||||
| Show All 26 Lines | def run_test(self): | ||||
| fund, sig64checksigtx = create_fund_and_spend_tx( | fund, sig64checksigtx = create_fund_and_spend_tx( | ||||
| out[5], sig=sig64) | out[5], sig=sig64) | ||||
| fundings.append(fund) | fundings.append(fund) | ||||
| fund, sig64multisigtx = create_fund_and_spend_tx( | fund, sig64multisigtx = create_fund_and_spend_tx( | ||||
| out[6], multi=True, sig=sig64) | out[6], multi=True, sig=sig64) | ||||
| fundings.append(fund) | fundings.append(fund) | ||||
| for fund in fundings: | tip = self.build_block(tip, fundings) | ||||
| send_transaction_to_mempool(fund) | node.p2p.send_blocks_and_test([tip], node) | ||||
| block(1, transactions=fundings) | |||||
| accepted() | |||||
| self.log.info("Typical ECDSA and Schnorr CHECKSIG are valid.") | self.log.info("Typical ECDSA and Schnorr CHECKSIG are valid.") | ||||
| schnorr_tx_id = send_transaction_to_mempool(schnorrchecksigtx) | schnorr_tx_id = send_transaction_to_mempool(schnorrchecksigtx) | ||||
| ecdsa_tx_id = send_transaction_to_mempool(ecdsachecksigtx) | ecdsa_tx_id = send_transaction_to_mempool(ecdsachecksigtx) | ||||
| # It can also be mined | # It can also be mined | ||||
| block(2, transactions=[schnorrchecksigtx, ecdsachecksigtx]) | tip = self.build_block(tip, [schnorrchecksigtx, ecdsachecksigtx]) | ||||
| accepted() | node.p2p.send_blocks_and_test([tip], node) | ||||
| assert schnorr_tx_id not in set(node.getrawmempool()) | assert schnorr_tx_id not in set(node.getrawmempool()) | ||||
| assert ecdsa_tx_id not in set(node.getrawmempool()) | assert ecdsa_tx_id not in set(node.getrawmempool()) | ||||
| self.log.info("Schnorr in multisig is rejected with mandatory error.") | self.log.info("Schnorr in multisig is rejected with mandatory error.") | ||||
| assert_raises_rpc_error(-26, RPC_SCHNORR_MULTISIG_ERROR, | assert_raises_rpc_error(-26, RPC_SCHNORR_MULTISIG_ERROR, | ||||
| node.sendrawtransaction, ToHex(schnorrmultisigtx)) | node.sendrawtransaction, ToHex(schnorrmultisigtx)) | ||||
| # And it is banworthy. | # And it is banworthy. | ||||
| check_for_ban_on_rejected_tx(schnorrmultisigtx) | check_for_ban_on_rejected_tx(schnorrmultisigtx) | ||||
| # And it can't be mined | # And it can't be mined | ||||
| block(13, transactions=[schnorrmultisigtx]) | self.check_for_ban_on_rejected_block( | ||||
| rejected(16, b'blk-bad-inputs') | self.build_block(tip, [schnorrmultisigtx]), 16, b'blk-bad-inputs') | ||||
| # Rewind bad block | |||||
| tip(2) | |||||
| self.log.info("Bad 64-byte sig is rejected with mandatory error.") | self.log.info("Bad 64-byte sig is rejected with mandatory error.") | ||||
| # In CHECKSIG it's invalid Schnorr and hence NULLFAIL. | # In CHECKSIG it's invalid Schnorr and hence NULLFAIL. | ||||
| assert_raises_rpc_error(-26, RPC_NULLFAIL_ERROR, | assert_raises_rpc_error(-26, RPC_NULLFAIL_ERROR, | ||||
| node.sendrawtransaction, ToHex(sig64checksigtx)) | node.sendrawtransaction, ToHex(sig64checksigtx)) | ||||
| # In CHECKMULTISIG it's invalid length and hence BAD_LENGTH. | # In CHECKMULTISIG it's invalid length and hence BAD_LENGTH. | ||||
| assert_raises_rpc_error(-26, RPC_SCHNORR_MULTISIG_ERROR, | assert_raises_rpc_error(-26, RPC_SCHNORR_MULTISIG_ERROR, | ||||
| node.sendrawtransaction, ToHex(sig64multisigtx)) | node.sendrawtransaction, ToHex(sig64multisigtx)) | ||||
| # Getting sent these transactions is banworthy. | # Getting sent these transactions is banworthy. | ||||
| check_for_ban_on_rejected_tx(sig64checksigtx) | check_for_ban_on_rejected_tx(sig64checksigtx) | ||||
| check_for_ban_on_rejected_tx(sig64multisigtx) | check_for_ban_on_rejected_tx(sig64multisigtx) | ||||
| # And they can't be mined either... | # And they can't be mined either... | ||||
| block(14, transactions=[sig64checksigtx]) | self.check_for_ban_on_rejected_block( | ||||
| rejected(16, b'blk-bad-inputs') | self.build_block(tip, [sig64checksigtx]), 16, b'blk-bad-inputs') | ||||
| # Rewind bad block | self.check_for_ban_on_rejected_block( | ||||
| tip(2) | self.build_block(tip, [sig64multisigtx]), 16, b'blk-bad-inputs') | ||||
| block(15, transactions=[sig64multisigtx]) | |||||
| rejected(16, b'blk-bad-inputs') | |||||
| # Rewind bad block | |||||
| tip(2) | |||||
| if __name__ == '__main__': | if __name__ == '__main__': | ||||
| SchnorrTest().main() | SchnorrTest().main() | ||||