Page MenuHomePhabricator
Differential D3471 Diff 10335 src/test/miner_tests.cpp

Changeset View

Standalone View

View Options

src/test/miner_tests.cpp

Show All 26 Lines
#include <boost/test/unit_test.hpp> #include <boost/test/unit_test.hpp>
#include <memory> #include <memory>
BOOST_FIXTURE_TEST_SUITE(miner_tests, TestingSetup) BOOST_FIXTURE_TEST_SUITE(miner_tests, TestingSetup)
static CFeeRate blockMinFeeRate = CFeeRate(DEFAULT_BLOCK_MIN_TX_FEE_PER_KB); static CFeeRate blockMinFeeRate = CFeeRate(DEFAULT_BLOCK_MIN_TX_FEE_PER_KB);
static BlockAssembler AssemblerForTest(const Config &config,
const CTxMemPool &mempool) {
BlockAssembler::Options options;
options.nBlockMaxSize = DEFAULT_MAX_BLOCK_SIZE;
options.blockMinFeeRate = blockMinFeeRate;
return BlockAssembler(config, mempool, options);
}
static struct { static struct {
uint8_t extranonce; uint8_t extranonce;
uint32_t nonce; uint32_t nonce;
} blockinfo[] = { } blockinfo[] = {
{4, 0xa4a3e223}, {2, 0x15c32f9e}, {1, 0x0375b547}, {1, 0x7004a8a5}, {4, 0xa4a3e223}, {2, 0x15c32f9e}, {1, 0x0375b547}, {1, 0x7004a8a5},
{2, 0xce440296}, {2, 0x52cfe198}, {1, 0x77a72cd0}, {2, 0xbb5d6f84}, {2, 0xce440296}, {2, 0x52cfe198}, {1, 0x77a72cd0}, {2, 0xbb5d6f84},
{2, 0x83f30c2c}, {1, 0x48a73d5b}, {1, 0xef7dcd01}, {2, 0x6809c6c4}, {2, 0x83f30c2c}, {1, 0x48a73d5b}, {1, 0xef7dcd01}, {2, 0x6809c6c4},
{2, 0x0883ab3c}, {1, 0x087bbbe2}, {2, 0x2104a814}, {2, 0xdffb6daa}, {2, 0x0883ab3c}, {1, 0x087bbbe2}, {2, 0x2104a814}, {2, 0xdffb6daa},
▲ Show 20 Lines • Show All 78 Lines • ▼ Show 20 Linesstatic void TestPackageSelection(Config &config, CScript scriptPubKey,
tx.vout[0].nValue = int64_t(5000000000LL - 1000 - 50000) * SATOSHI; tx.vout[0].nValue = int64_t(5000000000LL - 1000 - 50000) * SATOSHI;
TxId highFeeTxId = tx.GetId(); TxId highFeeTxId = tx.GetId();
g_mempool.addUnchecked(highFeeTxId, entry.Fee(50000 * SATOSHI) g_mempool.addUnchecked(highFeeTxId, entry.Fee(50000 * SATOSHI)
.Time(GetTime()) .Time(GetTime())
.SpendsCoinbase(false) .SpendsCoinbase(false)
.FromTx(tx)); .FromTx(tx));
std::unique_ptr<CBlockTemplate> pblocktemplate = std::unique_ptr<CBlockTemplate> pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey);
BOOST_CHECK(pblocktemplate->block.vtx[1]->GetId() == parentTxId); BOOST_CHECK(pblocktemplate->block.vtx[1]->GetId() == parentTxId);
BOOST_CHECK(pblocktemplate->block.vtx[2]->GetId() == highFeeTxId); BOOST_CHECK(pblocktemplate->block.vtx[2]->GetId() == highFeeTxId);
BOOST_CHECK(pblocktemplate->block.vtx[3]->GetId() == mediumFeeTxId); BOOST_CHECK(pblocktemplate->block.vtx[3]->GetId() == mediumFeeTxId);
// Test that a package below the block min tx fee doesn't get included // Test that a package below the block min tx fee doesn't get included
tx.vin[0].prevout = COutPoint(highFeeTxId, 0); tx.vin[0].prevout = COutPoint(highFeeTxId, 0);
// 0 fee. // 0 fee.
tx.vout[0].nValue = int64_t(5000000000LL - 1000 - 50000) * SATOSHI; tx.vout[0].nValue = int64_t(5000000000LL - 1000 - 50000) * SATOSHI;
TxId freeTxId = tx.GetId(); TxId freeTxId = tx.GetId();
g_mempool.addUnchecked(freeTxId, entry.Fee(Amount::zero()).FromTx(tx)); g_mempool.addUnchecked(freeTxId, entry.Fee(Amount::zero()).FromTx(tx));
size_t freeTxSize = GetVirtualTransactionSize(CTransaction(tx)); size_t freeTxSize = GetVirtualTransactionSize(CTransaction(tx));
// Calculate a fee on child transaction that will put the package just // Calculate a fee on child transaction that will put the package just
// below the block min tx fee (assuming 1 child tx of the same size). // below the block min tx fee (assuming 1 child tx of the same size).
Amount feeToUse = blockMinFeeRate.GetFee(2 * freeTxSize) - SATOSHI; Amount feeToUse = blockMinFeeRate.GetFee(2 * freeTxSize) - SATOSHI;
tx.vin[0].prevout = COutPoint(freeTxId, 0); tx.vin[0].prevout = COutPoint(freeTxId, 0);
tx.vout[0].nValue = tx.vout[0].nValue =
int64_t(5000000000LL - 1000 - 50000) * SATOSHI - feeToUse; int64_t(5000000000LL - 1000 - 50000) * SATOSHI - feeToUse;
TxId lowFeeTxId = tx.GetId(); TxId lowFeeTxId = tx.GetId();
g_mempool.addUnchecked(lowFeeTxId, entry.Fee(feeToUse).FromTx(tx)); g_mempool.addUnchecked(lowFeeTxId, entry.Fee(feeToUse).FromTx(tx));
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey);
// Verify that the free tx and the low fee tx didn't get selected. // Verify that the free tx and the low fee tx didn't get selected.
for (const auto &txn : pblocktemplate->block.vtx) { for (const auto &txn : pblocktemplate->block.vtx) {
BOOST_CHECK(txn->GetId() != freeTxId); BOOST_CHECK(txn->GetId() != freeTxId);
BOOST_CHECK(txn->GetId() != lowFeeTxId); BOOST_CHECK(txn->GetId() != lowFeeTxId);
} }
// Test that packages above the min relay fee do get included, even if one // Test that packages above the min relay fee do get included, even if one
// of the transactions is below the min relay fee. Remove the low fee // of the transactions is below the min relay fee. Remove the low fee
// transaction and replace with a higher fee transaction // transaction and replace with a higher fee transaction
g_mempool.removeRecursive(CTransaction(tx)); g_mempool.removeRecursive(CTransaction(tx));
// Now we should be just over the min relay fee. // Now we should be just over the min relay fee.
tx.vout[0].nValue -= 2 * SATOSHI; tx.vout[0].nValue -= 2 * SATOSHI;
lowFeeTxId = tx.GetId(); lowFeeTxId = tx.GetId();
g_mempool.addUnchecked(lowFeeTxId, g_mempool.addUnchecked(lowFeeTxId,
entry.Fee(feeToUse + 2 * SATOSHI).FromTx(tx)); entry.Fee(feeToUse + 2 * SATOSHI).FromTx(tx));
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey);
BOOST_CHECK(pblocktemplate->block.vtx[4]->GetId() == freeTxId); BOOST_CHECK(pblocktemplate->block.vtx[4]->GetId() == freeTxId);
BOOST_CHECK(pblocktemplate->block.vtx[5]->GetId() == lowFeeTxId); BOOST_CHECK(pblocktemplate->block.vtx[5]->GetId() == lowFeeTxId);
// Test that transaction selection properly updates ancestor fee // Test that transaction selection properly updates ancestor fee
// calculations as ancestor transactions get included in a block. Add a // calculations as ancestor transactions get included in a block. Add a
// 0-fee transaction that has 2 outputs. // 0-fee transaction that has 2 outputs.
tx.vin[0].prevout = COutPoint(txFirst[2]->GetId(), 0); tx.vin[0].prevout = COutPoint(txFirst[2]->GetId(), 0);
tx.vout.resize(2); tx.vout.resize(2);
tx.vout[0].nValue = int64_t(5000000000LL - 100000000) * SATOSHI; tx.vout[0].nValue = int64_t(5000000000LL - 100000000) * SATOSHI;
// 1BCC output. // 1BCC output.
tx.vout[1].nValue = 100000000 * SATOSHI; tx.vout[1].nValue = 100000000 * SATOSHI;
TxId freeTxId2 = tx.GetId(); TxId freeTxId2 = tx.GetId();
g_mempool.addUnchecked( g_mempool.addUnchecked(
freeTxId2, entry.Fee(Amount::zero()).SpendsCoinbase(true).FromTx(tx)); freeTxId2, entry.Fee(Amount::zero()).SpendsCoinbase(true).FromTx(tx));
// This tx can't be mined by itself. // This tx can't be mined by itself.
tx.vin[0].prevout = COutPoint(freeTxId2, 0); tx.vin[0].prevout = COutPoint(freeTxId2, 0);
tx.vout.resize(1); tx.vout.resize(1);
feeToUse = blockMinFeeRate.GetFee(freeTxSize); feeToUse = blockMinFeeRate.GetFee(freeTxSize);
tx.vout[0].nValue = int64_t(5000000000LL - 100000000) * SATOSHI - feeToUse; tx.vout[0].nValue = int64_t(5000000000LL - 100000000) * SATOSHI - feeToUse;
TxId lowFeeTxId2 = tx.GetId(); TxId lowFeeTxId2 = tx.GetId();
g_mempool.addUnchecked( g_mempool.addUnchecked(
lowFeeTxId2, entry.Fee(feeToUse).SpendsCoinbase(false).FromTx(tx)); lowFeeTxId2, entry.Fee(feeToUse).SpendsCoinbase(false).FromTx(tx));
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey);
// Verify that this tx isn't selected. // Verify that this tx isn't selected.
for (const auto &txn : pblocktemplate->block.vtx) { for (const auto &txn : pblocktemplate->block.vtx) {
BOOST_CHECK(txn->GetId() != freeTxId2); BOOST_CHECK(txn->GetId() != freeTxId2);
BOOST_CHECK(txn->GetId() != lowFeeTxId2); BOOST_CHECK(txn->GetId() != lowFeeTxId2);
} }
// This tx will be mineable, and should cause lowFeeTxId2 to be selected as // This tx will be mineable, and should cause lowFeeTxId2 to be selected as
// well. // well.
tx.vin[0].prevout = COutPoint(freeTxId2, 1); tx.vin[0].prevout = COutPoint(freeTxId2, 1);
// 10k satoshi fee. // 10k satoshi fee.
tx.vout[0].nValue = (100000000 - 10000) * SATOSHI; tx.vout[0].nValue = (100000000 - 10000) * SATOSHI;
g_mempool.addUnchecked(tx.GetId(), entry.Fee(10000 * SATOSHI).FromTx(tx)); g_mempool.addUnchecked(tx.GetId(), entry.Fee(10000 * SATOSHI).FromTx(tx));
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey);
BOOST_CHECK(pblocktemplate->block.vtx[8]->GetId() == lowFeeTxId2); BOOST_CHECK(pblocktemplate->block.vtx[8]->GetId() == lowFeeTxId2);
} }
void TestCoinbaseMessageEB(uint64_t eb, std::string cbmsg) { void TestCoinbaseMessageEB(uint64_t eb, std::string cbmsg) {
GlobalConfig config; GlobalConfig config;
config.SetMaxBlockSize(eb); config.SetMaxBlockSize(eb);
CScript scriptPubKey = CScript scriptPubKey =
CScript() << ParseHex("04678afdb0fe5548271967f1a67130b7105cd6a828e03909" CScript() << ParseHex("04678afdb0fe5548271967f1a67130b7105cd6a828e03909"
"a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112" "a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112"
"de5c384df7ba0b8d578a4c702b6bf11d5f") "de5c384df7ba0b8d578a4c702b6bf11d5f")
<< OP_CHECKSIG; << OP_CHECKSIG;
std::unique_ptr<CBlockTemplate> pblocktemplate = std::unique_ptr<CBlockTemplate> pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey);
CBlock *pblock = &pblocktemplate->block; CBlock *pblock = &pblocktemplate->block;
// IncrementExtraNonce creates a valid coinbase and merkleRoot // IncrementExtraNonce creates a valid coinbase and merkleRoot
unsigned int extraNonce = 0; unsigned int extraNonce = 0;
IncrementExtraNonce(config, pblock, chainActive.Tip(), extraNonce); IncrementExtraNonce(config, pblock, chainActive.Tip(), extraNonce);
unsigned int nHeight = chainActive.Tip()->nHeight + 1; unsigned int nHeight = chainActive.Tip()->nHeight + 1;
std::vector<uint8_t> vec(cbmsg.begin(), cbmsg.end()); std::vector<uint8_t> vec(cbmsg.begin(), cbmsg.end());
Show All 29 LinesBOOST_AUTO_TEST_CASE(CreateNewBlock_validity) {
fCheckpointsEnabled = false; fCheckpointsEnabled = false;
GlobalConfig config; GlobalConfig config;
// Simple block creation, nothing special yet: // Simple block creation, nothing special yet:
BOOST_CHECK( BOOST_CHECK(
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey)); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey));
// We can't make transactions until we have inputs. Therefore, load 100 // We can't make transactions until we have inputs. Therefore, load 100
// blocks :) // blocks :)
int baseheight = 0; int baseheight = 0;
std::vector<CTransactionRef> txFirst; std::vector<CTransactionRef> txFirst;
for (size_t i = 0; i < sizeof(blockinfo) / sizeof(*blockinfo); ++i) { for (size_t i = 0; i < sizeof(blockinfo) / sizeof(*blockinfo); ++i) {
// pointer for convenience. // pointer for convenience.
CBlock *pblock = &pblocktemplate->block; CBlock *pblock = &pblocktemplate->block;
Show All 24 Lines for (size_t i = 0; i < sizeof(blockinfo) / sizeof(*blockinfo); ++i) {
pblock->hashPrevBlock = pblock->GetHash(); pblock->hashPrevBlock = pblock->GetHash();
} }
LOCK(cs_main); LOCK(cs_main);
// Just to make sure we can still make simple blocks. // Just to make sure we can still make simple blocks.
BOOST_CHECK( BOOST_CHECK(
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey)); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey));
const Amount BLOCKSUBSIDY = 50 * COIN; const Amount BLOCKSUBSIDY = 50 * COIN;
const Amount LOWFEE = CENT; const Amount LOWFEE = CENT;
const Amount HIGHFEE = COIN; const Amount HIGHFEE = COIN;
const Amount HIGHERFEE = 4 * COIN; const Amount HIGHERFEE = 4 * COIN;
// block sigops > limit: 1000 CHECKMULTISIG + 1 // block sigops > limit: 1000 CHECKMULTISIG + 1
tx.vin.resize(1); tx.vin.resize(1);
Show All 12 Lines for (unsigned int i = 0; i < 1001; ++i) {
// creation fails. // creation fails.
g_mempool.addUnchecked(txid, entry.Fee(LOWFEE) g_mempool.addUnchecked(txid, entry.Fee(LOWFEE)
.Time(GetTime()) .Time(GetTime())
.SpendsCoinbase(spendsCoinbase) .SpendsCoinbase(spendsCoinbase)
.FromTx(tx)); .FromTx(tx));
tx.vin[0].prevout = COutPoint(txid, 0); tx.vin[0].prevout = COutPoint(txid, 0);
} }
BOOST_CHECK_THROW( BOOST_CHECK_THROW(
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey), AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey),
std::runtime_error); std::runtime_error);
g_mempool.clear(); g_mempool.clear();
tx.vin[0].prevout = COutPoint(txFirst[0]->GetId(), 0); tx.vin[0].prevout = COutPoint(txFirst[0]->GetId(), 0);
tx.vout[0].nValue = BLOCKSUBSIDY; tx.vout[0].nValue = BLOCKSUBSIDY;
for (unsigned int i = 0; i < 1001; ++i) { for (unsigned int i = 0; i < 1001; ++i) {
tx.vout[0].nValue -= LOWFEE; tx.vout[0].nValue -= LOWFEE;
const TxId txid = tx.GetId(); const TxId txid = tx.GetId();
// Only first tx spends coinbase. // Only first tx spends coinbase.
bool spendsCoinbase = i == 0; bool spendsCoinbase = i == 0;
// If we do set the # of sig ops in the CTxMemPoolEntry, template // If we do set the # of sig ops in the CTxMemPoolEntry, template
// creation passes. // creation passes.
g_mempool.addUnchecked(txid, entry.Fee(LOWFEE) g_mempool.addUnchecked(txid, entry.Fee(LOWFEE)
.Time(GetTime()) .Time(GetTime())
.SpendsCoinbase(spendsCoinbase) .SpendsCoinbase(spendsCoinbase)
.SigOpsCost(80) .SigOpsCost(80)
.FromTx(tx)); .FromTx(tx));
tx.vin[0].prevout = COutPoint(txid, 0); tx.vin[0].prevout = COutPoint(txid, 0);
} }
BOOST_CHECK( BOOST_CHECK(
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey)); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey));
g_mempool.clear(); g_mempool.clear();
// block size > limit // block size > limit
tx.vin[0].scriptSig = CScript(); tx.vin[0].scriptSig = CScript();
// 18 * (520char + DROP) + OP_1 = 9433 bytes // 18 * (520char + DROP) + OP_1 = 9433 bytes
std::vector<uint8_t> vchData(520); std::vector<uint8_t> vchData(520);
for (unsigned int i = 0; i < 18; ++i) { for (unsigned int i = 0; i < 18; ++i) {
tx.vin[0].scriptSig << vchData << OP_DROP; tx.vin[0].scriptSig << vchData << OP_DROP;
Show All 10 Lines for (unsigned int i = 0; i < 128; ++i) {
g_mempool.addUnchecked(txid, entry.Fee(LOWFEE) g_mempool.addUnchecked(txid, entry.Fee(LOWFEE)
.Time(GetTime()) .Time(GetTime())
.SpendsCoinbase(spendsCoinbase) .SpendsCoinbase(spendsCoinbase)
.FromTx(tx)); .FromTx(tx));
tx.vin[0].prevout = COutPoint(txid, 0); tx.vin[0].prevout = COutPoint(txid, 0);
} }
BOOST_CHECK( BOOST_CHECK(
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey)); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey));
g_mempool.clear(); g_mempool.clear();
// Orphan in mempool, template creation fails. // Orphan in mempool, template creation fails.
TxId txid = tx.GetId(); TxId txid = tx.GetId();
g_mempool.addUnchecked(txid, entry.Fee(LOWFEE).Time(GetTime()).FromTx(tx)); g_mempool.addUnchecked(txid, entry.Fee(LOWFEE).Time(GetTime()).FromTx(tx));
BOOST_CHECK_THROW( BOOST_CHECK_THROW(
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey), AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey),
std::runtime_error); std::runtime_error);
g_mempool.clear(); g_mempool.clear();
// Child with higher priority than parent. // Child with higher priority than parent.
tx.vin[0].scriptSig = CScript() << OP_1; tx.vin[0].scriptSig = CScript() << OP_1;
tx.vin[0].prevout = COutPoint(txFirst[1]->GetId(), 0); tx.vin[0].prevout = COutPoint(txFirst[1]->GetId(), 0);
tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE; tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE;
txid = tx.GetId(); txid = tx.GetId();
g_mempool.addUnchecked( g_mempool.addUnchecked(
txid, txid,
entry.Fee(HIGHFEE).Time(GetTime()).SpendsCoinbase(true).FromTx(tx)); entry.Fee(HIGHFEE).Time(GetTime()).SpendsCoinbase(true).FromTx(tx));
tx.vin[0].prevout = COutPoint(txid, 0); tx.vin[0].prevout = COutPoint(txid, 0);
tx.vin.resize(2); tx.vin.resize(2);
tx.vin[1].scriptSig = CScript() << OP_1; tx.vin[1].scriptSig = CScript() << OP_1;
tx.vin[1].prevout = COutPoint(txFirst[0]->GetId(), 0); tx.vin[1].prevout = COutPoint(txFirst[0]->GetId(), 0);
// First txn output + fresh coinbase - new txn fee. // First txn output + fresh coinbase - new txn fee.
tx.vout[0].nValue = tx.vout[0].nValue + BLOCKSUBSIDY - HIGHERFEE; tx.vout[0].nValue = tx.vout[0].nValue + BLOCKSUBSIDY - HIGHERFEE;
txid = tx.GetId(); txid = tx.GetId();
g_mempool.addUnchecked( g_mempool.addUnchecked(
txid, txid,
entry.Fee(HIGHERFEE).Time(GetTime()).SpendsCoinbase(true).FromTx(tx)); entry.Fee(HIGHERFEE).Time(GetTime()).SpendsCoinbase(true).FromTx(tx));
BOOST_CHECK( BOOST_CHECK(
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey)); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey));
g_mempool.clear(); g_mempool.clear();
// Coinbase in mempool, template creation fails. // Coinbase in mempool, template creation fails.
tx.vin.resize(1); tx.vin.resize(1);
tx.vin[0].prevout = COutPoint(); tx.vin[0].prevout = COutPoint();
tx.vin[0].scriptSig = CScript() << OP_0 << OP_1; tx.vin[0].scriptSig = CScript() << OP_0 << OP_1;
tx.vout[0].nValue = Amount::zero(); tx.vout[0].nValue = Amount::zero();
txid = tx.GetId(); txid = tx.GetId();
// Give it a fee so it'll get mined. // Give it a fee so it'll get mined.
g_mempool.addUnchecked( g_mempool.addUnchecked(
txid, txid,
entry.Fee(LOWFEE).Time(GetTime()).SpendsCoinbase(false).FromTx(tx)); entry.Fee(LOWFEE).Time(GetTime()).SpendsCoinbase(false).FromTx(tx));
BOOST_CHECK_THROW( BOOST_CHECK_THROW(
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey), AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey),
std::runtime_error); std::runtime_error);
g_mempool.clear(); g_mempool.clear();
// Double spend txn pair in mempool, template creation fails. // Double spend txn pair in mempool, template creation fails.
tx.vin[0].prevout = COutPoint(txFirst[0]->GetId(), 0); tx.vin[0].prevout = COutPoint(txFirst[0]->GetId(), 0);
tx.vin[0].scriptSig = CScript() << OP_1; tx.vin[0].scriptSig = CScript() << OP_1;
tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE; tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE;
tx.vout[0].scriptPubKey = CScript() << OP_1; tx.vout[0].scriptPubKey = CScript() << OP_1;
txid = tx.GetId(); txid = tx.GetId();
g_mempool.addUnchecked( g_mempool.addUnchecked(
txid, txid,
entry.Fee(HIGHFEE).Time(GetTime()).SpendsCoinbase(true).FromTx(tx)); entry.Fee(HIGHFEE).Time(GetTime()).SpendsCoinbase(true).FromTx(tx));
tx.vout[0].scriptPubKey = CScript() << OP_2; tx.vout[0].scriptPubKey = CScript() << OP_2;
txid = tx.GetId(); txid = tx.GetId();
g_mempool.addUnchecked( g_mempool.addUnchecked(
txid, txid,
entry.Fee(HIGHFEE).Time(GetTime()).SpendsCoinbase(true).FromTx(tx)); entry.Fee(HIGHFEE).Time(GetTime()).SpendsCoinbase(true).FromTx(tx));
BOOST_CHECK_THROW( BOOST_CHECK_THROW(
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey), AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey),
std::runtime_error); std::runtime_error);
g_mempool.clear(); g_mempool.clear();
// Subsidy changing. // Subsidy changing.
int nHeight = chainActive.Height(); int nHeight = chainActive.Height();
// Create an actual 209999-long block chain (without valid blocks). // Create an actual 209999-long block chain (without valid blocks).
while (chainActive.Tip()->nHeight < 209999) { while (chainActive.Tip()->nHeight < 209999) {
CBlockIndex *prev = chainActive.Tip(); CBlockIndex *prev = chainActive.Tip();
CBlockIndex *next = new CBlockIndex(); CBlockIndex *next = new CBlockIndex();
next->phashBlock = new uint256(InsecureRand256()); next->phashBlock = new uint256(InsecureRand256());
pcoinsTip->SetBestBlock(next->GetBlockHash()); pcoinsTip->SetBestBlock(next->GetBlockHash());
next->pprev = prev; next->pprev = prev;
next->nHeight = prev->nHeight + 1; next->nHeight = prev->nHeight + 1;
next->BuildSkip(); next->BuildSkip();
chainActive.SetTip(next); chainActive.SetTip(next);
} }
BOOST_CHECK( BOOST_CHECK(
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey)); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey));
// Extend to a 210000-long block chain. // Extend to a 210000-long block chain.
while (chainActive.Tip()->nHeight < 210000) { while (chainActive.Tip()->nHeight < 210000) {
CBlockIndex *prev = chainActive.Tip(); CBlockIndex *prev = chainActive.Tip();
CBlockIndex *next = new CBlockIndex(); CBlockIndex *next = new CBlockIndex();
next->phashBlock = new uint256(InsecureRand256()); next->phashBlock = new uint256(InsecureRand256());
pcoinsTip->SetBestBlock(next->GetBlockHash()); pcoinsTip->SetBestBlock(next->GetBlockHash());
next->pprev = prev; next->pprev = prev;
next->nHeight = prev->nHeight + 1; next->nHeight = prev->nHeight + 1;
next->BuildSkip(); next->BuildSkip();
chainActive.SetTip(next); chainActive.SetTip(next);
} }
BOOST_CHECK( BOOST_CHECK(
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey)); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey));
// Invalid p2sh txn in mempool, template creation fails // Invalid p2sh txn in mempool, template creation fails
tx.vin[0].prevout = COutPoint(txFirst[0]->GetId(), 0); tx.vin[0].prevout = COutPoint(txFirst[0]->GetId(), 0);
tx.vin[0].scriptSig = CScript() << OP_1; tx.vin[0].scriptSig = CScript() << OP_1;
tx.vout[0].nValue = BLOCKSUBSIDY - LOWFEE; tx.vout[0].nValue = BLOCKSUBSIDY - LOWFEE;
script = CScript() << OP_0; script = CScript() << OP_0;
tx.vout[0].scriptPubKey = GetScriptForDestination(CScriptID(script)); tx.vout[0].scriptPubKey = GetScriptForDestination(CScriptID(script));
txid = tx.GetId(); txid = tx.GetId();
g_mempool.addUnchecked( g_mempool.addUnchecked(
txid, txid,
entry.Fee(LOWFEE).Time(GetTime()).SpendsCoinbase(true).FromTx(tx)); entry.Fee(LOWFEE).Time(GetTime()).SpendsCoinbase(true).FromTx(tx));
tx.vin[0].prevout = COutPoint(txid, 0); tx.vin[0].prevout = COutPoint(txid, 0);
tx.vin[0].scriptSig = CScript() tx.vin[0].scriptSig = CScript()
<< std::vector<uint8_t>(script.begin(), script.end()); << std::vector<uint8_t>(script.begin(), script.end());
tx.vout[0].nValue -= LOWFEE; tx.vout[0].nValue -= LOWFEE;
txid = tx.GetId(); txid = tx.GetId();
g_mempool.addUnchecked( g_mempool.addUnchecked(
txid, txid,
entry.Fee(LOWFEE).Time(GetTime()).SpendsCoinbase(false).FromTx(tx)); entry.Fee(LOWFEE).Time(GetTime()).SpendsCoinbase(false).FromTx(tx));
BOOST_CHECK_THROW( BOOST_CHECK_THROW(
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey), AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey),
std::runtime_error); std::runtime_error);
g_mempool.clear(); g_mempool.clear();
// Delete the dummy blocks again. // Delete the dummy blocks again.
while (chainActive.Tip()->nHeight > nHeight) { while (chainActive.Tip()->nHeight > nHeight) {
CBlockIndex *del = chainActive.Tip(); CBlockIndex *del = chainActive.Tip();
chainActive.SetTip(del->pprev); chainActive.SetTip(del->pprev);
pcoinsTip->SetBestBlock(del->pprev->GetBlockHash()); pcoinsTip->SetBestBlock(del->pprev->GetBlockHash());
▲ Show 20 Lines • Show All 154 Lines • ▼ Show 20 LinesBOOST_AUTO_TEST_CASE(CreateNewBlock_validity) {
tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG; tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG;
// Sequence locks pass. // Sequence locks pass.
BOOST_CHECK(TestSequenceLocks(CTransaction(tx), flags)); BOOST_CHECK(TestSequenceLocks(CTransaction(tx), flags));
tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG | 1; tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG | 1;
// Sequence locks fail. // Sequence locks fail.
BOOST_CHECK(!TestSequenceLocks(CTransaction(tx), flags)); BOOST_CHECK(!TestSequenceLocks(CTransaction(tx), flags));
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey);
BOOST_CHECK(pblocktemplate); BOOST_CHECK(pblocktemplate);
// None of the of the absolute height/time locked tx should have made it // None of the of the absolute height/time locked tx should have made it
// into the template because we still check IsFinalTx in CreateNewBlock, but // into the template because we still check IsFinalTx in CreateNewBlock, but
// relative locked txs will if inconsistently added to g_mempool. For now // relative locked txs will if inconsistently added to g_mempool. For now
// these will still generate a valid template until BIP68 soft fork. // these will still generate a valid template until BIP68 soft fork.
BOOST_CHECK_EQUAL(pblocktemplate->block.vtx.size(), 3UL); BOOST_CHECK_EQUAL(pblocktemplate->block.vtx.size(), 3UL);
// However if we advance height by 1 and time by 512, all of them should be // However if we advance height by 1 and time by 512, all of them should be
// mined. // mined.
for (int i = 0; i < CBlockIndex::nMedianTimeSpan; i++) { for (int i = 0; i < CBlockIndex::nMedianTimeSpan; i++) {
// Trick the MedianTimePast. // Trick the MedianTimePast.
chainActive.Tip()->GetAncestor(chainActive.Tip()->nHeight - i)->nTime += chainActive.Tip()->GetAncestor(chainActive.Tip()->nHeight - i)->nTime +=
512; 512;
} }
chainActive.Tip()->nHeight++; chainActive.Tip()->nHeight++;
SetMockTime(chainActive.Tip()->GetMedianTimePast() + 1); SetMockTime(chainActive.Tip()->GetMedianTimePast() + 1);
BOOST_CHECK( BOOST_CHECK(
pblocktemplate = pblocktemplate =
BlockAssembler(config, g_mempool).CreateNewBlock(scriptPubKey)); AssemblerForTest(config, g_mempool).CreateNewBlock(scriptPubKey));
BOOST_CHECK_EQUAL(pblocktemplate->block.vtx.size(), 5UL); BOOST_CHECK_EQUAL(pblocktemplate->block.vtx.size(), 5UL);
chainActive.Tip()->nHeight--; chainActive.Tip()->nHeight--;
SetMockTime(0); SetMockTime(0);
g_mempool.clear(); g_mempool.clear();
TestPackageSelection(config, scriptPubKey, txFirst); TestPackageSelection(config, scriptPubKey, txFirst);
fCheckpointsEnabled = true; fCheckpointsEnabled = true;
} }
void CheckBlockMaxSize(const Config &config, uint64_t size, uint64_t expected) { void CheckBlockMaxSize(const Config &config, uint64_t size, uint64_t expected) {
gArgs.ForceSetArg("-blockmaxsize", std::to_string(size)); gArgs.ForceSetArg("-blockmaxsize", std::to_string(size));
BlockAssembler ba(config, g_mempool); BlockAssembler ba(config, g_mempool);
BOOST_CHECK_EQUAL(ba.GetMaxGeneratedBlockSize(), expected); BOOST_CHECK_EQUAL(ba.GetMaxGeneratedBlockSize(), expected);
// BlockAssembler with options gives the same result
BlockAssembler::Options options;
options.nBlockMaxSize = size;
options.blockMinFeeRate = blockMinFeeRate;
BlockAssembler ba2(config, g_mempool, options);
FabienUnsubmitted
Not Done
Inline Actions

ba2 => baWithOptions or something similar is more explicit.

Fabien: `ba2` => `baWithOptions` or something similar is more explicit.
BOOST_CHECK_EQUAL(ba2.GetMaxGeneratedBlockSize(), expected);
} }
BOOST_AUTO_TEST_CASE(BlockAssembler_construction) { BOOST_AUTO_TEST_CASE(BlockAssembler_construction) {
GlobalConfig config; GlobalConfig config;
// We are working on a fake chain and need to protect ourselves. // We are working on a fake chain and need to protect ourselves.
LOCK(cs_main); LOCK(cs_main);
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines