Differential D4043 Diff 11213 src/compat/assumptions.h

Changeset View

Standalone View

src/compat/assumptions.h

This file was added.

				// Copyright (c) 2009-2010 Satoshi Nakamoto
				// Copyright (c) 2009-2019 The Bitcoin Core developers
				// Distributed under the MIT software license, see the accompanying
				// file COPYING or http://www.opensource.org/licenses/mit-license.php.

				// Compile-time verification of assumptions we make.

				#ifndef BITCOIN_COMPAT_ASSUMPTIONS_H
				#define BITCOIN_COMPAT_ASSUMPTIONS_H

				#include <limits>

				// Assumption: We assume that the macro NDEBUG is not defined.
				// Example(s): We use assert(...) extensively with the assumption of it never
				// being a noop at runtime.
				#if defined(NDEBUG)
				#error "Bitcoin cannot be compiled without assertions."
				#endif
				FabienUnsubmitted Not Done Inline Actions This is duplicated, you should remove it from `validation.cpp` Fabien: This is duplicated, you should remove it from `validation.cpp`

				// Assumption: We assume the floating-point types to fulfill the requirements of
				// IEC 559 (IEEE 754) standard.
				// Example(s): Floating-point division by zero in ConnectBlock,
				// CreateTransaction
				// and EstimateMedianVal.
				static_assert(std::numeric_limits<float>::is_iec559, "IEEE 754 float assumed");
				static_assert(std::numeric_limits<double>::is_iec559,
				"IEEE 754 double assumed");

				// Assumption: We assume eight bits per byte (obviously, but remember: don't
				// trust -- verify!).
				// Example(s): Everywhere :-)
				static_assert(std::numeric_limits<uint8_t>::digits == 8, "8-bit byte assumed");

				// Assumption: We assume floating-point widths.
				// Example(s): Type punning in serialization code
				// (ser_{float,double}_to_uint{32,64}).
				static_assert(sizeof(float) == 4, "32-bit float assumed");
				static_assert(sizeof(double) == 8, "64-bit double assumed");

				// Assumption: We assume integer widths.
				// Example(s): GetSizeOfCompactSize and WriteCompactSize in the serialization
				// code.
				static_assert(sizeof(short) == 2, "16-bit short assumed");
				static_assert(sizeof(int) == 4, "32-bit int assumed");

				// Some important things we are NOT assuming (non-exhaustive list):
				// * We are NOT assuming a specific value for sizeof(std::size_t).
				// * We are NOT assuming a specific value for std::endian::native.
				// * We are NOT assuming a specific value for std::locale("").name().
				// * We are NOT assuming a specific value for
				// std::numeric_limits<char>::is_signed.
				FabienUnsubmitted Not Done Inline Actions IMO a list of things that doesn't exist shouldn't exist... but keep it to avoid merge conflicts. Fabien: IMO a list of things that doesn't exist shouldn't exist... but keep it to avoid merge conflicts.

				#endif // BITCOIN_COMPAT_ASSUMPTIONS_H