Differential D3871 Diff 11241 cmake/modules/LibraryHelper.cmake

Changeset View

Standalone View

				# Facilities to manage libraries

				macro(build_shared FROM_TARGET TO_TARGET)
				deadalnixUnsubmitted Not Done Inline Actions This is the exact reverse as what cmake libraries typically do. deadalnix: This is the exact reverse as what cmake libraries typically do.
				set_target_properties(${FROM_TARGET} PROPERTIES POSITION_INDEPENDENT_CODE ON)
				deadalnixUnsubmitted Not Done Inline Actions Why is that necessary ? Also, this doesn't seem to be a generally useful function as properties aren't applied transitively. I'd be surprised if cmake was unable to figure out it need to build PIC code for SHARED lib dependencies. deadalnix: Why is that necessary ? Also, this doesn't seem to be a generally useful function as properties…
				FabienAuthorUnsubmitted Done Inline Actions The shared library will be built with PIC as cmake will add it automatically because of being shared, but it does not apply to the dependencies. Even when creating a shared from an object library you still need to set it manually. Fabien: The shared library will be built with PIC as cmake will add it automatically because of being…
				add_library(${TO_TARGET} SHARED $<TARGET_PROPERTY:${FROM_TARGET},SOURCES>)
				endmacro()