Changeset View
Changeset View
Standalone View
Standalone View
doc/release-notes.md
Bitcoin ABC version 0.20.3 is now available from: | Bitcoin ABC version 0.20.3 is now available from: | ||||
<https://download.bitcoinabc.org/0.20.3/> | <https://download.bitcoinabc.org/0.20.3/> | ||||
This release includes the following features and fixes: | This release includes the following features and fixes: | ||||
- The `getwalletinfo` RPC method now returns an `hdseedid` value, which is always the same as the incorrectly-named `hdmasterkeyid` value. `hdmasterkeyid` will be removed in V0.21. | |||||
- The `getaddressinfo` RPC method now returns an `hdseedid` value, which is always the same as the incorrectly-named `hdmasterkeyid` value. `hdmasterkeyid` will be removed in V0.21. | |||||
deadalnix: grepping through the doc history, the V0.21 nomenclature was never used.
Second there doesn't… | |||||
nakihitoAuthorUnsubmitted Done Inline ActionsI don't understand what you what you mean by the first part of your comment. As for the second part of you comment, this is purely the scripted commit as you requested I split before (https://reviews.bitcoinabc.org/D4175#100125). The tests are included in the other half of this backport (see D4175). nakihito: I don't understand what you what you mean by the first part of your comment.
As for the second… | |||||
deadalnixUnsubmitted Not Done Inline ActionsSo this doesn't do what is written int he release notes, actually breaks backward compatibility. The mass rename can only occurs after dual naming is introduced. You should have realized this when putting release notes in there that do not match what the patch is doing, if not when doing the patch itself. deadalnix: So this doesn't do what is written int he release notes, actually breaks backward compatibility. |
grepping through the doc history, the V0.21 nomenclature was never used.
Second there doesn't seem to be a test for hdmasterkeyid anywhere, so how do we know it works at all? (glancing at the diff, I strongly suspect it doesn't).