Page MenuHomePhabricator
Differential D4588 Diff 14516 src/test/CMakeLists.txt

Changeset View

Standalone View

View Options

src/test/CMakeLists.txt

Show First 20 Lines • Show All 182 Lines • ▼ Show 20 Lines PRIVATE
../wallet/test/wallet_crypto_tests.cpp ../wallet/test/wallet_crypto_tests.cpp
) )
endif() endif()
add_executable(test_bitcoin_fuzzy EXCLUDE_FROM_ALL add_executable(test_bitcoin_fuzzy EXCLUDE_FROM_ALL
test_bitcoin_fuzzy.cpp test_bitcoin_fuzzy.cpp
) )
target_link_libraries(test_bitcoin_fuzzy server) target_link_libraries(test_bitcoin_fuzzy server)
if("fuzzer" IN_LIST ENABLE_SANITIZERS)
target_compile_options(test_bitcoin_fuzzy PRIVATE -fsanitize=fuzzer)
target_link_libraries(test_bitcoin_fuzzy -fsanitize=fuzzer)
deadalnixUnsubmitted
Not Done
Inline Actions

Does building that target without the sanitizer makes any sense at all? Also, are you sure that it doesn't have all to be build with the sanitizer?

deadalnix: Does building that target without the sanitizer makes any sense at all? Also, are you sure that…
FabienAuthorUnsubmitted
Done
Inline Actions

The reason for not setting the option by default is that there are 2 possible ways to use the executable for fuzzing:

    • You can build against an AFL compiler, such as afl-clang-fast then use afl-fuzz to manage the instrumented binary (this is the method described in the fuzzing.md documentation)
  • Or you can use clang's integrated libFuzzer which is what is done by passing the -fsanitize=fuzzer option. I don't think you can do both at the same time, as I don't expect the afl-* enabled compilers to support libFuzzer.

Regarding your second question, there is no need for building anything else with the fuzzer sanitizer (see https://github.com/bitcoin/bitcoin/pull/16338).
But you can (should ?) build with other sanitizers such as ASAN for example, then run with an abort on error option (don't remember the exact syntax). That would allow you to catch the vectors that trigger ASAN faults.

Fabien: The reason for not setting the option by default is that there are 2 possible ways to use the…
endif()