Page MenuHomePhabricator
Differential D4627 Diff 14606 src/Makefile.test.include

Changeset View

Standalone View

View Options

src/Makefile.test.include

# Copyright (c) 2013-2016 The Bitcoin Core developers # Copyright (c) 2013-2016 The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying # Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php. # file COPYING or http://www.opensource.org/licenses/mit-license.php.
bin_PROGRAMS += test/test_bitcoin
FUZZ_TARGETS = \ FUZZ_TARGETS = \
test/fuzz/address_deserialize \ test/fuzz/address_deserialize \
test/fuzz/addrman_deserialize \ test/fuzz/addrman_deserialize \
test/fuzz/banentry_deserialize \ test/fuzz/banentry_deserialize \
test/fuzz/block_deserialize \ test/fuzz/block_deserialize \
test/fuzz/blockheader_deserialize \ test/fuzz/blockheader_deserialize \
test/fuzz/blocklocator_deserialize \ test/fuzz/blocklocator_deserialize \
Show All 9 LinesFUZZ_TARGETS = \
test/fuzz/netaddr_deserialize \ test/fuzz/netaddr_deserialize \
test/fuzz/service_deserialize \ test/fuzz/service_deserialize \
test/fuzz/transaction_deserialize \ test/fuzz/transaction_deserialize \
test/fuzz/txoutcompressor_deserialize \ test/fuzz/txoutcompressor_deserialize \
test/fuzz/txundo_deserialize test/fuzz/txundo_deserialize
if ENABLE_FUZZ if ENABLE_FUZZ
noinst_PROGRAMS += $(FUZZ_TARGETS:=) noinst_PROGRAMS += $(FUZZ_TARGETS:=)
else
bin_PROGRAMS += test/test_bitcoin
deadalnixUnsubmitted
Not Done
Inline Actions

Why isn't test_bitcoin built when the fuzzer is on? Why isn't that behavior matched with cmake?

deadalnix: Why isn't test_bitcoin built when the fuzzer is on? Why isn't that behavior matched with cmake?
FabienAuthorUnsubmitted
Done
Inline Actions

No other executable will link with -fsanitize=fuzzer because it defines a main and expect some functions to be defined. CMake has a different target to build all the fuzzer executables so you don't need to disable everything to build them.
I updated the test plan so you get a better idea of the difference.

Fabien: No other executable will link with `-fsanitize=fuzzer` because it defines a main and expect…
endif endif
TEST_SRCDIR = test TEST_SRCDIR = test
TEST_BINARY=test/test_bitcoin$(EXEEXT) TEST_BINARY=test/test_bitcoin$(EXEEXT)
JSON_TEST_FILES = \ JSON_TEST_FILES = \
test/data/base58_encode_decode.json \ test/data/base58_encode_decode.json \
test/data/blockfilters.json \ test/data/blockfilters.json \
▲ Show 20 Lines • Show All 540 Lines • Show Last 20 Lines