Page MenuHomePhabricator
Differential D5042 Diff 16071 contrib/teamcity/build-configurations.sh

Changeset View

Standalone View

View Options

contrib/teamcity/build-configurations.sh

Show All 34 Linessetup() {
mkdir -p "${SAN_LOG_DIR}" mkdir -p "${SAN_LOG_DIR}"
rm -rf "${SAN_LOG_DIR:?}"/* rm -rf "${SAN_LOG_DIR:?}"/*
# Sanitizers options, not used if sanitizers are not enabled # Sanitizers options, not used if sanitizers are not enabled
export ASAN_OPTIONS="malloc_context_size=0:log_path=${SAN_LOG_DIR}/asan.log" export ASAN_OPTIONS="malloc_context_size=0:log_path=${SAN_LOG_DIR}/asan.log"
export LSAN_OPTIONS="suppressions=${SAN_SUPP_DIR}/lsan:log_path=${SAN_LOG_DIR}/lsan.log" export LSAN_OPTIONS="suppressions=${SAN_SUPP_DIR}/lsan:log_path=${SAN_LOG_DIR}/lsan.log"
export TSAN_OPTIONS="suppressions=${SAN_SUPP_DIR}/tsan:log_path=${SAN_LOG_DIR}/tsan.log" export TSAN_OPTIONS="suppressions=${SAN_SUPP_DIR}/tsan:log_path=${SAN_LOG_DIR}/tsan.log"
export UBSAN_OPTIONS="suppressions=${SAN_SUPP_DIR}/ubsan:print_stacktrace=1:halt_on_error=1:log_path=${SAN_LOG_DIR}/ubsan.log" export UBSAN_OPTIONS="suppressions=${SAN_SUPP_DIR}/ubsan:print_stacktrace=1:halt_on_error=1:log_path=${SAN_LOG_DIR}/ubsan.log"
# Unit test logger parameters
UNIT_TESTS_JUNIT_LOG_LEVEL=message
jasonbcoxUnsubmitted
Not Done
Inline Actions

Apparently this log level produces strange results in ASAN (I haven't tried UBSAN or TSAN yet): https://build.bitcoinabc.org/viewLog.html?buildId=28319&buildTypeId=BitcoinABC_BitcoinAbcStaging&tab=buildLog&state=60&_focus=1070#_state=60

This isn't an actual error and appears to be expected: https://stackoverflow.com/a/54951825/6312728 It's unfortunate that it throws garbage into the logs. Please take a look and see if there's an easy way to mitigate this.

jasonbcox: Apparently this log level produces strange results in ASAN (I haven't tried UBSAN or TSAN yet)…
FabienAuthorUnsubmitted
Done
Inline Actions

message is not the cause. This seems to be a bug in boost, when there are multiple loggers enabled (independently of the log level).
Unfortunately I have no solution at the moment apart trying to remove the BOOST_TEST_CONTEXT occurrence, and I don't want to do this.

Fabien: `message` is not the cause. This seems to be a bug in boost, when there are multiple loggers…
FabienAuthorUnsubmitted
Done
Inline Actions

See https://github.com/boostorg/test/issues/251

Fabien: See https://github.com/boostorg/test/issues/251
}
run_test_bitcoin() {
# Usage: run_test_bitcoin "Context as string" [arguments...]
ninja test_bitcoin
TEST_BITCOIN_JUNIT="junit_results_unit_tests${1:+_${1// /_}}.xml"
TEST_BITCOIN_SUITE_NAME="Bitcoin ABC unit tests${1:+ $1}"
./src/test/test_bitcoin \
--logger=HRF:JUNIT,${UNIT_TESTS_JUNIT_LOG_LEVEL},${TEST_BITCOIN_JUNIT} \
-- -testsuitename="${TEST_BITCOIN_SUITE_NAME}" "${@:2}"
jasonbcoxUnsubmitted
Not Done
Inline Actions

Nit: It may be best for readability to put each arg (especially --) on it's own line:

./src/test/test_bitcoin \
  --logger=HRF:JUNIT,${UNIT_TESTS_JUNIT_LOG_LEVEL},${TEST_BITCOIN_JUNIT} \
  -- \
  -testsuitename="${TEST_BITCOIN_SUITE_NAME}" \
  "${@:2}"
jasonbcox: Nit: It may be best for readability to put each arg (especially `--`) on it's own line: ``` .
} }
# Facility to print out sanitizer log outputs to the build log console # Facility to print out sanitizer log outputs to the build log console
print_sanitizers_log() { print_sanitizers_log() {
for log in "${SAN_LOG_DIR}"/*.log.* for log in "${SAN_LOG_DIR}"/*.log.*
do do
echo "*** Output of ${log} ***" echo "*** Output of ${log} ***"
cat "${log}" cat "${log}"
Show All 13 Lines CMAKE_FLAGS=(
# ASAN does not support assembly code: https://github.com/google/sanitizers/issues/192 # ASAN does not support assembly code: https://github.com/google/sanitizers/issues/192
# This will trigger a segfault if the SSE4 implementation is selected for SHA256. # This will trigger a segfault if the SSE4 implementation is selected for SHA256.
# Disabling the assembly works around the issue. # Disabling the assembly works around the issue.
"-DCRYPTO_USE_ASM=OFF" "-DCRYPTO_USE_ASM=OFF"
"-DENABLE_SANITIZERS=address" "-DENABLE_SANITIZERS=address"
"-DCCACHE=OFF" "-DCCACHE=OFF"
) )
CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh
ninja check check-functional
run_test_bitcoin "with address sanitizer"
jasonbcoxUnsubmitted
Not Done
Inline Actions

Aren't the sanitizer tests reducing coverage for all tools and libs that are compiled with cmake?

jasonbcox: Aren't the sanitizer tests reducing coverage for all tools and libs that are compiled with…
ninja check-functional
;; ;;
build-ubsan) build-ubsan)
# Build with the undefined sanitizer, then run unit tests and functional tests. # Build with the undefined sanitizer, then run unit tests and functional tests.
CMAKE_FLAGS=( CMAKE_FLAGS=(
"-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_BUILD_TYPE=Debug"
"-DENABLE_SANITIZERS=undefined" "-DENABLE_SANITIZERS=undefined"
"-DCCACHE=OFF" "-DCCACHE=OFF"
"-DCMAKE_C_COMPILER=clang" "-DCMAKE_C_COMPILER=clang"
"-DCMAKE_CXX_COMPILER=clang++" "-DCMAKE_CXX_COMPILER=clang++"
) )
CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh
ninja check check-functional
run_test_bitcoin "with undefined sanitizer"
ninja check-functional
;; ;;
build-tsan) build-tsan)
# Build with the thread sanitizer, then run unit tests and functional tests. # Build with the thread sanitizer, then run unit tests and functional tests.
CMAKE_FLAGS=( CMAKE_FLAGS=(
"-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_BUILD_TYPE=Debug"
"-DENABLE_SANITIZERS=thread" "-DENABLE_SANITIZERS=thread"
"-DCCACHE=OFF" "-DCCACHE=OFF"
"-DCMAKE_C_COMPILER=clang" "-DCMAKE_C_COMPILER=clang"
"-DCMAKE_CXX_COMPILER=clang++" "-DCMAKE_CXX_COMPILER=clang++"
) )
CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh
run_test_bitcoin "with thread sanitizer"
ninja check check-functional ninja check check-functional
;; ;;
build-diff) build-diff)
# Build, run unit tests and functional tests. # Build, run unit tests and functional tests.
CMAKE_FLAGS=( CMAKE_FLAGS=(
"-DSECP256K1_ENABLE_MODULE_ECDH=ON" "-DSECP256K1_ENABLE_MODULE_ECDH=ON"
"-DSECP256K1_ENABLE_JNI=ON" "-DSECP256K1_ENABLE_JNI=ON"
) )
CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh
# FIXME: Path collisions in src/test/util_tests.cpp cause issues when
# upgraded tests are run in parallel with their non-upgraded counterpart. # Unit tests
# Change this back to a one-liner when the root cause is fixed. run_test_bitcoin
ninja check-all run_test_bitcoin "with next upgrade activated" -phononactivationtime=1575158400
ninja check-upgrade-activated
# Libs and tools tests
ninja \
check-bitcoin-qt \
check-bitcoin-seeder \
check-bitcoin-util \
check-devtools \
check-leveldb \
check-rpcauth \
check-secp256k1 \
check-univalue \
# Functional tests
ninja check-functional
ninja check-functional-upgrade-activated
;; ;;
build-master) build-master)
# Build, run unit tests and extended functional tests. # Build, run unit tests and extended functional tests.
CMAKE_FLAGS=( CMAKE_FLAGS=(
"-DSECP256K1_ENABLE_MODULE_ECDH=ON" "-DSECP256K1_ENABLE_MODULE_ECDH=ON"
"-DSECP256K1_ENABLE_JNI=ON" "-DSECP256K1_ENABLE_JNI=ON"
) )
CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh
# FIXME: Path collisions in src/test/util_tests.cpp cause issues when
# upgraded tests are run in parallel with their non-upgraded counterpart. # Unit tests
# Change this back to a one-liner when the root cause is fixed. run_test_bitcoin
ninja check-extended run_test_bitcoin "with next upgrade activated" -phononactivationtime=1575158400
ninja check-upgrade-activated-extended
# Libs and tools tests
ninja \
check-bitcoin-qt \
check-bitcoin-seeder \
check-bitcoin-util \
check-devtools \
check-leveldb \
check-rpcauth \
check-secp256k1 \
check-univalue \
# Functional tests
ninja check-functional-extended
ninja check-functional-upgrade-activated-extended
;; ;;
build-without-wallet) build-without-wallet)
# Build without wallet and run the unit tests. # Build without wallet and run the unit tests.
CMAKE_FLAGS=( CMAKE_FLAGS=(
"-DBUILD_BITCOIN_WALLET=OFF" "-DBUILD_BITCOIN_WALLET=OFF"
) )
CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh
ninja check
run_test_bitcoin "without wallet"
;; ;;
build-ibd) build-ibd)
"${CI_SCRIPTS_DIR}"/build_cmake.sh "${CI_SCRIPTS_DIR}"/build_cmake.sh
"${CI_SCRIPTS_DIR}"/ibd.sh -disablewallet -debug=net "${CI_SCRIPTS_DIR}"/ibd.sh -disablewallet -debug=net
;; ;;
build-ibd-no-assumevalid-checkpoint) build-ibd-no-assumevalid-checkpoint)
Show All 9 Lines CMAKE_FLAGS=(
"-DCMAKE_CXX_COMPILER=clang++" "-DCMAKE_CXX_COMPILER=clang++"
) )
CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh CMAKE_FLAGS="${CMAKE_FLAGS[*]}" "${CI_SCRIPTS_DIR}"/build_cmake.sh
;; ;;
build-autotools) build-autotools)
# Ensure that the build using autotools is not broken # Ensure that the build using autotools is not broken
"${CI_SCRIPTS_DIR}"/build_autotools.sh "${CI_SCRIPTS_DIR}"/build_autotools.sh
make -j "${THREADS}" check
run_test_bitcoin "built with autotools"
;; ;;
build-bench) build-bench)
# Build and run the benchmarks. # Build and run the benchmarks.
CMAKE_FLAGS=( CMAKE_FLAGS=(
"-DBUILD_BITCOIN_WALLET=ON" "-DBUILD_BITCOIN_WALLET=ON"
"-DSECP256K1_ENABLE_MODULE_ECDH=ON" "-DSECP256K1_ENABLE_MODULE_ECDH=ON"
"-DSECP256K1_ENABLE_MODULE_MULTISET=ON" "-DSECP256K1_ENABLE_MODULE_MULTISET=ON"
Show All 22 Lines