Page MenuHomePhabricator
Differential D3582

Merge #10248: Rewrite addrdb with less duplication using CHashVerifier
ClosedPublic
Actions

Authored by markblundeberg on Jul 7 2019, 20:08.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING316a92010546: Merge #10248: Rewrite addrdb with less duplication using CHashVerifier
rABC316a92010546: Merge #10248: Rewrite addrdb with less duplication using CHashVerifier
Summary

PR10248 backport https://github.com/bitcoin/bitcoin/pull/10248/files
cf68a48 Deduplicate addrdb.cpp and use CHashWriter/Verifier (Pieter Wuille)

backport note: had to add chainParams everywhere due to ABC style; in
turn static had to be removed from one member function so addrdb.h remains
unmodified.

Test Plan

make check

Diff Detail

Event Timeline

markblundeberg created this revision.Jul 7 2019, 20:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 20:08
teamcity added a comment.Jul 7 2019, 20:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg planned changes to this revision.Jul 7 2019, 20:10
markblundeberg added inline comments.
src/addrdb.cpp
48 ↗(On Diff #10055)

braces

52 ↗(On Diff #10055)

braces

57 ↗(On Diff #10055)

braces

101 ↗(On Diff #10055)

braces

teamcity added a comment.Jul 7 2019, 20:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6710: Diff 10055.Jul 7 2019, 20:17
markblundeberg updated this revision to Diff 10057.Jul 7 2019, 20:19

braces

teamcity added a comment.Jul 7 2019, 20:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a child revision: D3583: Merge #13039: Add logging and error handling for file syncing.Jul 7 2019, 20:21
teamcity added a comment.Jul 7 2019, 20:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6712: Diff 10057.Jul 7 2019, 20:26
Fabien accepted this revision.Jul 8 2019, 07:39
Fabien added inline comments.
src/addrdb.cpp
73

Revert to uint8_t

This revision is now accepted and ready to land.Jul 8 2019, 07:39
Closed by commit rABC316a92010546: Merge #10248: Rewrite addrdb with less duplication using CHashVerifier (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 8 2019, 14:07
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC316a92010546: Merge #10248: Rewrite addrdb with less duplication using CHashVerifier.
markblundeberg marked an inline comment as done.Jul 8 2019, 14:08
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING316a92010546: Merge #10248: Rewrite addrdb with less duplication using CHashVerifier.Sep 19 2019, 01:03

Revision Contents
Changeset List

PathSize
src/
216 lines

Diff 10057

View Options

src/addrdb.cpp

Loading...