Page MenuHomePhabricator

[wallet] setup wallet background flushing in WalletInit directly
ClosedPublic

Authored by Fabien on Jul 10 2019, 09:59.

Details

Summary
WalletInit::Start calls postInitProcess() for each wallet. Previously
each call to postInitProcess() would attempt to schedule wallet
background flushing.

Just start wallet background flushing once from WalletInit::Start().

Partial backport of core PR10740 (commit 470316c)
https://github.com/bitcoin/bitcoin/pull/10740/commits/470316c3bf5ca343d5d66b94839169a4572eceb7

Progress towards T459

Test Plan
make check
./test/functional/test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10740_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6828
Build 11703: Bitcoin ABC Buildbot (legacy)
Build 11702: arc lint + arc unit

Event Timeline

deadalnix added inline comments.
src/wallet/init.cpp
400 ↗(On Diff #10189)

Do you actually need the full trinity here ?

This revision is now accepted and ready to land.Jul 11 2019, 01:49

Remove () from the predicate.