Page MenuHomePhabricator
Differential D3668

Add purpose arg to Wallet::getAddress
ClosedPublic
Actions

Authored by deadalnix on Jul 12 2019, 18:01.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGf06e9f7b610b: Add purpose arg to Wallet::getAddress
rABCf06e9f7b610b: Add purpose arg to Wallet::getAddress
Summary

Also make all arguments to getAddress required and document args at call sites.

This is a partial backport of Core PR12830 : https://github.com/bitcoin/bitcoin/pull/12830/commits/c5b277033a72650c221084ec0f1326623a810fd0

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
addpurposegetaddress
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6842
Build 11731: Bitcoin ABC Buildbot (legacy)
Build 11730: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 12 2019, 18:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 18:01
teamcity added a comment.Jul 12 2019, 18:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 12 2019, 18:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B6842: Diff 10268!Jul 12 2019, 18:09
deadalnix added a child revision: D3669: [qt] Display more helpful message when adding a send address has failed.Jul 12 2019, 18:12
teamcity added a comment.Jul 12 2019, 20:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 12 2019, 20:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6842: Diff 10268.Jul 12 2019, 20:56
jasonbcox accepted this revision.Jul 16 2019, 03:06
This revision is now accepted and ready to land.Jul 16 2019, 03:06
Closed by commit rABCf06e9f7b610b: Add purpose arg to Wallet::getAddress (authored by James O'Beirne <james.obeirne@gmail.com>, committed by deadalnix). · Explain WhyJul 16 2019, 13:05
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCf06e9f7b610b: Add purpose arg to Wallet::getAddress.
deadalnix added a commit: rSTAGINGf06e9f7b610b: Add purpose arg to Wallet::getAddress.Sep 19 2019, 01:17

Revision Contents
Changeset List

PathSize
src/
interfaces/
5 lines
5 lines
qt/
12 lines
16 lines
3 lines

Diff 10268

View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/addresstablemodel.cpp

Loading...
View Options

src/qt/transactiondesc.cpp

Loading...
View Options

src/qt/walletmodel.cpp

Loading...