Page MenuHomePhabricator

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.
ClosedPublic

Authored by deadalnix on Jul 9 2019, 19:49.

Details

Summary

5a9b508 [trivial] Add end of namespace comments (practicalswift)

Tree-SHA512: 92b0fcae4d1d3f4da9e97569ae84ef2d6e09625a5815cd0e5f0eb6dd2ecba9852fa85c184c5ae9de5117050330ce995e9867b451fa8cd5512169025990541a2b

Backport of Core PR9544
https://github.com/bitcoin/bitcoin/pull/9544/files

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D3619
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6858
Build 11763: Bitcoin ABC Buildbot (legacy)
Build 11762: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jul 9 2019, 19:49

base58.cpp change wes made in D624 and then the code was moved to a different file in D3577.
The majority of other changes were made in D873.

deadalnix requested changes to this revision.Jul 10 2019, 23:56

There is a tool that can do this automatically and exaustively. Use it.

This revision now requires changes to proceed.Jul 10 2019, 23:56
deadalnix edited reviewers, added: nakihito; removed: deadalnix.

Update cland-format to enforce the new style

This revision is now accepted and ready to land.Jul 16 2019, 03:01