Page MenuHomePhabricator

net: Add option `-enablebip61` to configure sending of BIP61 notifications
ClosedPublic

Authored by deadalnix on Jul 24 2019, 00:56.

Details

Summary

This commit adds a boolean option -enablebip61, defaulting to 1, that
can be used to disable the sending of BIP61 reject messages. This
functionality has been requested for various reasons:

  • security (DoS): reject messages can reveal internal state that can be used to target certain resources such as the mempool more easily.
  • bandwidth: a typical node sends lots of reject messages; this counts against upstream bandwidth. Also the reject messages tend to be larger than the message that was rejected.

On the other hand, reject messages can be useful while developing client
software (I found them indispensable while creating bitcoin-submittx),
as well as for our own test cases, so whatever the default becomes on the
long run, IMO the functionality should be retained as option. But that's
a discussion for later.

  • doc: Mention disabling BIP61 in bips.md

This is a backport of Core PR13134

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13134
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6934
Build 11915: Bitcoin ABC Buildbot (legacy)
Build 11914: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Jul 24 2019, 06:25
Fabien added a subscriber: Fabien.

The test is failing

This revision now requires changes to proceed.Jul 24 2019, 06:25
test/functional/p2p_invalid_tx.py
86 ↗(On Diff #10414)

Don't know if it's related to the test failure, but this change is from another PR: https://github.com/bitcoin/bitcoin/pull/11423

Can't reproduce the issue

This revision is now accepted and ready to land.Jul 25 2019, 06:45