Page MenuHomePhabricator

Migrate abc-invalid-chains off of the ComparisonTestFramework
ClosedPublic

Authored by jasonbcox on Aug 12 2019, 23:18.

Details

Summary

See title.

Depends on D3862 due to a difficult to pinpoint robustness issue without that change.
Rather than attempt to solve the issue, we can get rid of it entirely by backporting D3862 first.

Progress towards T669

Test Plan

test_runner.py abc-invalid-chains

Diff Detail

Repository
rABC Bitcoin ABC
Branch
invalid-chains-comptool
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7155
Build 12355: Bitcoin ABC Buildbot (legacy)
Build 12354: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Aug 13 2019, 07:49
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc-invalid-chains.py
46 ↗(On Diff #10748)

Nit: the name is confusing because sync_blocks() is already defined by the test_framework (twice...).

This revision now requires changes to proceed.Aug 13 2019, 07:49
test/functional/abc-invalid-chains.py
46 ↗(On Diff #10748)

I further realized after copying this over from Core's tests, that this intermediate function isn't necessary in this test since there's no reconnecting going on. I'll just remove it entirely.

Cleanup unnecessary and confusing sync_blocks function.

This revision is now accepted and ready to land.Aug 16 2019, 08:00