Page MenuHomePhabricator

Merge #12853: qa: Match full plain text by default
ClosedPublic

Authored by jasonbcox on Aug 19 2019, 22:24.

Details

Summary

faace13868 qa: Match full plain text by default (MarcoFalke)

Pull request description:

Instead of escaping all full plain text error strings, just compare their strings by default.

Tree-SHA512: 42e28f55105eb947ac6af6ce4056f0ec0f701d85f1c2a38b35ab777bbdf2296bdb79639c345621b8adc03a98b28c7630ded9a67b8b04a48e2c3a49d598ecdcd7

Backport of Core PR12853
https://github.com/bitcoin/bitcoin/pull/12853/files

Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D3914
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7367
Build 12777: Bitcoin ABC Buildbot (legacy)
Build 12776: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Aug 20 2019, 06:46
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/test_node.py
10 ↗(On Diff #10875)

Nit: enum is lexically before errno

test/functional/wallet_multiwallet.py
95 ↗(On Diff #10875)

Why did you remove the leading 'r' ? AFAIK the \. is not a valid escape sequence (regex-only), so I think it should still be required ?

127 ↗(On Diff #10875)

Dito with the \S here.

This revision now requires changes to proceed.Aug 20 2019, 06:46

Rebase + fix according to feedback

Fabien requested changes to this revision.Sep 9 2019, 06:27
Fabien added inline comments.
test/functional/test_framework/test_node.py
10 ↗(On Diff #11139)

You missed this one :)

This revision now requires changes to proceed.Sep 9 2019, 06:27
This revision is now accepted and ready to land.Sep 10 2019, 06:19