Page MenuHomePhabricator

Use C++11 default member initializers
ClosedPublic

Authored by deadalnix on Sep 16 2019, 10:12.

Details

Summary

This is a backport of Core PR15109

Depends on D4079

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15109
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7479
Build 13001: Bitcoin ABC Buildbot (legacy)
Build 13000: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Sep 16 2019, 10:45
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/addrman_tests.cpp
18 ↗(On Diff #11340)

This is a missing dependency: https://github.com/bitcoin/bitcoin/pull/11112

This revision now requires changes to proceed.Sep 16 2019, 10:45
deadalnix added inline comments.
src/test/addrman_tests.cpp
18 ↗(On Diff #11340)

I don't see how blocking this because all the patches to make ctors explicit across the codebase aren't backported.

This revision is now accepted and ready to land.Sep 16 2019, 13:01