Page MenuHomePhabricator

Add AssertLockHeld assertions in CWallet::ListCoins
ClosedPublic

Authored by deadalnix on Sep 27 2019, 16:14.

Details

Summary
  • Add AssertLockHeld assertions in CWallet::ListCoins
  • Add EXCLUSIVE_LOCKS_REQUIRED to CWallet::ListCoins

Suggested by MarcoFalke <falke.marco@gmail.com> in
https://github.com/bitcoin/bitcoin/pull/10605#issuecomment-417643535

This is a backport of Core PR10605

Test Plan
  • Build with clang and make sure there are no warning related to locks.
  • Build in debug mode and run the extended test suite.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10605
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7612
Build 13264: Bitcoin ABC Buildbot (legacy)
Build 13263: arc lint + arc unit

Event Timeline

deadalnix reclaimed this revision.
deadalnix retitled this revision from Add EXCLUSIVE_LOCKS_REQUIRED to CWallet::ListCoins to Add AssertLockHeld assertions in CWallet::ListCoins.Sep 27 2019, 16:59
deadalnix edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 27 2019, 21:59