Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGa6851819dd55: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub…
rABCa6851819dd55: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub…

Summary

7de1de7 Add new fee structure with all sub-fields denominated in BTC (mryandao)

Pull request description:

the denomination for `fee` is current in btc while the other such as `decendentFee` and `ancestorFee` are in satoshis.

Tree-SHA512: e428f6dca1d339f89ab73e38ce5903f5465c46b159069d9bcc3f8b1140fe6657fa49a11abe0088e9f7ba9999f64af72a349a4735bf5eaa61b8e4a185b23543f3

Backport of Core PR12240
https://github.com/bitcoin/bitcoin/pull/12240/

Also included PR13109 and PR13124 (small typo fixes)
https://github.com/bitcoin/bitcoin/pull/13109/
https://github.com/bitcoin/bitcoin/pull/13124/

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12240

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7658
Build 13355: Bitcoin ABC Buildbot (legacy)
Build 13354: arc lint + arc unit

Event Timeline

nakihito created this revision.Sep 25 2019, 18:45

Owners added a reviewer: Restricted Owners Package.Sep 25 2019, 18:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2019, 18:45

nakihito planned changes to this revision.Sep 25 2019, 18:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7585: Diff 13136.Sep 25 2019, 18:55

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Applied another typo fix changes.

nakihito planned changes to this revision.Sep 25 2019, 19:01

nakihito retitled this revision from Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BTC to Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.Sep 25 2019, 19:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Sep 25 2019, 19:23

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7587: Diff 13141.Sep 25 2019, 19:32

nakihito requested review of this revision.Sep 25 2019, 21:15

jasonbcox requested changes to this revision.Oct 1 2019, 18:44

jasonbcox added inline comments.

doc/release-notes.md
6 ↗	(On Diff #13141)	Ideally, this would be formatted so that it's readable in 80-char wide terminals. Add some newlines to break this up.

This revision now requires changes to proceed.Oct 1 2019, 18:44

Reformatted release notes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7657: Diff 13308.Oct 1 2019, 21:14

jasonbcox requested changes to this revision.Oct 1 2019, 21:26

jasonbcox added inline comments.

doc/release-notes.md
10 ↗	(On Diff #13308)	This still isn't right. Markdown uses whitespace to group bullet-pointed, multi-line content. See old release notes as examples.