Page MenuHomePhabricator

Do not cache version in cmake build
ClosedPublic

Authored by deadalnix on Oct 9 2019, 00:05.

Details

Summary

The cmake build produce stale version numbers as a result of the caching.

Test Plan

Build with cmake.

Increment the version number of bitcoin-abc in /CMakeLists.txt .

Rebuild, make sure the version actually changed in the generated version.h

Diff Detail

Repository
rABC Bitcoin ABC
Branch
versionnocache
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7720
Build 13479: Bitcoin ABC Buildbot (legacy)
Build 13478: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Oct 9 2019, 06:27
Fabien added a subscriber: Fabien.

It's breaking the doc/Doxyfile.cmake.in template.
Please replace the line:
PROJECT_NUMBER = ${CLIENT_VERSION_MAJOR}.${CLIENT_VERSION_MINOR}.${CLIENT_VERSION_REVISION}
with:
PROJECT_NUMBER = ${bitcoin-abc_VERSION}
to fix it.

This revision now requires changes to proceed.Oct 9 2019, 06:27
This revision is now accepted and ready to land.Oct 9 2019, 12:43
This revision was automatically updated to reflect the committed changes.