Page MenuHomePhabricator

Merge #13114: wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore
ClosedPublic

Authored by nakihito on Oct 20 2019, 22:32.

Details

Summary

968b76f77c Add missing cs_KeyStore lock (practicalswift)
4bcd5bb87d Add locking annotations for variables guarded by cs_KeyStore (practicalswift)

Pull request description:

  • Add Clang thread safety annotations for variables guarded by cs_KeyStore
  • Add missing cs_KeyStore lock

Tree-SHA512: 7d93513c2da0cd564b9f1e75aa5156a454a4133eb845020fde8872e685dd5758353e93c33364aeea4a812c08353a810494e503a5ce160cc5be0af5af4bb2e6d7

Backport of Core PR13114
https://github.com/bitcoin/bitcoin/pull/13114/

Test Plan
../configure --enable-debug CXX=clang++ CC=clang
make clean
make check
test_runner.py

Run team city build-werror.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13114
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7861
Build 13741: Bitcoin ABC Buildbot (legacy)
Build 13740: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 20 2019, 22:32
deadalnix requested changes to this revision.Oct 23 2019, 01:13

The test plan is inadequate. If you actually checked for thread safety annotation warning from the compiler, you'd know that there are some since Oct, 3rd (!)

This revision now requires changes to proceed.Oct 23 2019, 01:13
nakihito edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Oct 25 2019, 01:04