Page MenuHomePhabricator

remove NULLDUMMY
ClosedPublic

Authored by markblundeberg on Nov 29 2019, 04:12.

Details

Summary

Now that the Schnorr multisig upgrade is active, the NULLDUMMY standard
flag is totally superseded and pointless.

Test Plan
make check
test_runner.py

run IBD

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove_nulldummy
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8329
Build 14677: Default Diff Build & Tests
Build 14676: arc lint + arc unit

Event Timeline

src/script/bitcoinconsensus.h
55 ↗(On Diff #14496)

better to put _DEPRECATED like the WITNESS flag?

src/test/data/script_tests.json
3348 ↗(On Diff #14496)

will rm

test/functional/abc-schnorrmultisig-activation.py
58 ↗(On Diff #14496)

technically unrelated comment change but I missed it in previous Diff; happy to leave out if that is wanted.

remove spurious newline and request teamcity rerun

Great to see this!

Just to be safe, I think doing an IBD should be added to the test plan.

deadalnix requested changes to this revision.Nov 29 2019, 14:11
deadalnix edited the test plan for this revision. (Show Details)

Please Run IBD, otherwise, LGTM.

I edited the test plan, you don't need to use backticks on every line :)

This revision now requires changes to proceed.Nov 29 2019, 14:12
This revision is now accepted and ready to land.Nov 30 2019, 17:51