Differential D4597

Use TxId in setInventoryTxToSend
ClosedPublic
Actions

Authored by deadalnix on Nov 30 2019, 20:32.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING3489ac50107f: Use TxId in setInventoryTxToSend
rABC3489ac50107f: Use TxId in setInventoryTxToSend

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

setInventoryTxToSendtxid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8353
Build 14725: Default Diff Build & Tests
Build 14724: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 30 2019, 20:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2019, 20:32

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8353: Diff 14536.Nov 30 2019, 20:46

Fabien requested changes to this revision.Dec 2 2019, 07:52

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net_processing.cpp
1411	You missed this one

This revision now requires changes to proceed.Dec 2 2019, 07:52

deadalnix requested review of this revision.Dec 2 2019, 13:38

deadalnix added inline comments.

src/net_processing.cpp
1411	This clearly is not a miss or that would be a compilation error.

Fabien accepted this revision.Dec 2 2019, 13:48

Fabien added inline comments.

src/net_processing.cpp
1411	My bad.

This revision is now accepted and ready to land.Dec 2 2019, 13:48

Closed by commit rABC3489ac50107f: Use TxId in setInventoryTxToSend (authored by deadalnix). · Explain WhyDec 2 2019, 14:22

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC3489ac50107f: Use TxId in setInventoryTxToSend.

deadalnix added a commit: rSTAGING3489ac50107f: Use TxId in setInventoryTxToSend.Apr 7 2020, 21:57

Revision Contents
Changeset List

Path

Size

src/

net.h

7 lines

net_processing.cpp

33 lines

Diff 14536

View Options

src/net.h