Page MenuHomePhabricator

Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction.
ClosedPublic

Authored by markblundeberg on Feb 11 2020, 13:45.

Details

Summary

PR13030 backport

Depends on D5261

Pull request description:

`-zapwallettxes` should be disallowed when starting bitcoin in multiwallet mode.

There's code in `WalletInit::ParameterInteraction()` to disallow `-zapwallettxes` when running in multiwallet mode. This code functioned as expected when passing the parameter `-zapwallettxes=1`, but not when passing the parameter `-zapwallettxes` (ie without the value specified). Fix that and add a test.

The new test in the
_[wallet] [tests] Test disallowed multiwallet params_ commit reproduces the bug and should fail against master.
Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13030
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9438
Build 16805: Default Diff Build & Tests
Build 16804: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Feb 11 2020, 14:36