Page MenuHomePhabricator
Differential D5300

[sigcheck] Add per tx limit
ClosedPublic
Actions

Authored by deadalnix on Feb 16 2020, 02:38.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING18708a54d44c: [sigcheck] Add per tx limit
rABC18708a54d44c: [sigcheck] Add per tx limit
Summary

As per title.

Test Plan

Added integration tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pertxlimit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9516
Build 16944: Default Diff Build & Tests
Build 16943: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 16 2020, 02:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 16 2020, 02:38
teamcity added a comment.Feb 16 2020, 02:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 16 2020, 02:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9515: Diff 16414.Feb 16 2020, 02:50
jasonbcox requested changes to this revision.Feb 16 2020, 03:42
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
1225 ↗(On Diff #16414)

Won't this short circuit so pBlockLimitSigChecks->consume_and_check(metrics.nSigChecks) may not be evaluated?

1273 ↗(On Diff #16414)

ditto

src/validation.h
524 ↗(On Diff #16414)

Nit: s/for to/to

test/functional/abc-block-sigchecks-activation.py
298 ↗(On Diff #16414)

s/may/many ?

This revision now requires changes to proceed.Feb 16 2020, 03:42
deadalnix updated this revision to Diff 16416.Feb 16 2020, 03:47

Fix nits

teamcity added a comment.Feb 16 2020, 03:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox accepted this revision.Feb 16 2020, 03:48
jasonbcox added inline comments.
src/validation.cpp
1225 ↗(On Diff #16414)

nvm, the tx limit check failing is the only case where this does not short circuit, so it doesn't matter.

This revision is now accepted and ready to land.Feb 16 2020, 03:48
deadalnix updated this revision to Diff 16418.Feb 16 2020, 03:55

More nits

teamcity added a comment.Feb 16 2020, 03:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

This revision was landed with ongoing or failed builds.Feb 16 2020, 03:56
Closed by commit rABC18708a54d44c: [sigcheck] Add per tx limit (authored by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC18708a54d44c: [sigcheck] Add per tx limit.
teamcity added a comment.Feb 16 2020, 03:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9516: Diff 16416.Feb 16 2020, 03:59
teamcity added a comment.Feb 16 2020, 04:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9518: Diff 16418.Feb 16 2020, 04:07
deadalnix added a commit: rSTAGING18708a54d44c: [sigcheck] Add per tx limit.Apr 7 2020, 23:02

Revision Contents
Changeset List

PathSize
src/
consensus/
4 lines
test/
17 lines
50 lines
24 lines
test/
functional/
84 lines

Diff 16416

View Options

src/consensus/consensus.h

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-block-sigchecks-activation.py

Loading...