Page MenuHomePhabricator

Label length unit tests for parse_name()
ClosedPublic

Authored by nakihito on Feb 25 2020, 21:25.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING9c34988e63da: Label length unit tests for parse_name()
rABC9c34988e63da: Label length unit tests for parse_name()
Summary

Adds some label length unit tests for the seeder's parse_name() function.

Depends on D4418

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ParseNameUnitTest-4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9573
Build 17050: Default Diff Build & Tests
Build 17049: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Feb 25 2020, 22:55
jasonbcox added inline comments.
src/seeder/test/seeder_tests.cpp
117 ↗(On Diff #16502)

You can init this all at once using what's called a "fill constructor": std::string s6a (MAX_LABEL_LENGTH, 'x'); see http://www.cplusplus.com/reference/string/string/string/

This revision now requires changes to proceed.Feb 25 2020, 22:55
jasonbcox added inline comments.
src/seeder/test/seeder_tests.cpp
117 ↗(On Diff #16502)

This has the added benefit of making it immediately obvious how long the string is. Making it const is even better.

Removed for-loop initialization.

jasonbcox requested changes to this revision.Feb 25 2020, 23:06
jasonbcox added inline comments.
src/seeder/test/seeder_tests.cpp
118 ↗(On Diff #16510)

you dont need this check anymore

This revision now requires changes to proceed.Feb 25 2020, 23:06

Added const and removed unnecessary check.

jasonbcox added inline comments.
src/seeder/test/seeder_tests.cpp
20

Same feedback as this comment for a future diff: https://reviews.bitcoinabc.org/D4418#inline-32872

This revision is now accepted and ready to land.Feb 26 2020, 00:53
This revision was automatically updated to reflect the committed changes.