Page MenuHomePhabricator

[debian release] Fetch signer string from GPG rather than requiring the user to enter a perfectly formatted one
ClosedPublic

Authored by jasonbcox on Mar 24 2020, 00:12.

Details

Summary

This allows the releaser to type fewer characters with simpler formatting requirements.
See test plan for examples.

Test Plan
./debian-packages.sh --dry-run jason
./debian-packages.sh --dry-run jasonbcox
./debian-packages.sh --dry-run jasonbcox@bitcoinabc.org
./debian-packages.sh --dry-run 3BB16D0
./debian-packages.sh --dry-run 1  # fails due to too many matches
./debian-packages.sh --dry-run blah  # fails due to no matches

Diff Detail

Repository
rABC Bitcoin ABC
Branch
get-signer-from-gpg
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9956
Build 17766: Default Diff Build & Tests
Build 17765: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Mar 24 2020, 09:24
Fabien added a subscriber: Fabien.

This does not guarantee that you will use the expected key. For example I have several keys with my name and various email addresses, and the script could randomly pick any of these.
The input should be unique. Another approach would be to filter using the keys.txt file from the repo.

This revision now requires changes to proceed.Mar 24 2020, 09:24

Make the key fetching more robust against both too many and no matches

This revision is now accepted and ready to land.Mar 24 2020, 16:27