Page MenuHomePhabricator

Rebuild native executable when changes to the build system are made
ClosedPublic

Authored by deadalnix on Mar 31 2020, 18:19.

Details

Summary

When the build rules needs to be updated, cmake isn't always rerun for the native build.

This adds a dependency file that ensures it does. This feature is limited to cmake, so there are no changes with other build systems and a call to clean might still be necessary.

Test Plan
ninja
ninja # Check native build isn't ran again.
touch build.ninja
ninja # Native build runs again.

Build with make as a generator and verify it's still good.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nativedeps
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10059
Build 17953: Default Diff Build & Tests
Build 17952: arc lint + arc unit

Event Timeline

Always generate the dep file. It doesn't hurt on other targets and makes things simpler.

This revision is now accepted and ready to land.Apr 1 2020, 07:44