Enable decoding and optional encoding of cashaddr
ClosedPublic
Actions

Authored by dagurval on Nov 10 2017, 22:59.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING1a3a9d7cbe9e: Enable decoding and optional encoding of cashaddr
rABC1a3a9d7cbe9e: Enable decoding and optional encoding of cashaddr

Summary

Wraps both cashaddr and base58 addresses into EncodeDestination and
DecodeDestination.

Test Plan

Added unittest

Diff Detail

Branch

14-11-cashaddr-noflag

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1117
Build 1117: arc lint + arc unit

Event Timeline

dagurval created this revision.Nov 10 2017, 22:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2017, 22:59

remove -use-cashaddr flag

dagurval edited the summary of this revision. (Show Details)Nov 14 2017, 13:06

deadalnix accepted this revision.Nov 14 2017, 13:37

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/test/dstencode_tests.cpp
9	Add a line between our imports and the system ones.

This revision is now accepted and ready to land.Nov 14 2017, 13:37

Closed by commit rABC1a3a9d7cbe9e: Enable decoding and optional encoding of cashaddr (authored by dagurval). · Explain WhyNov 14 2017, 14:15

This revision was automatically updated to reflect the committed changes.

dagurval mentioned this in D683: Add flag to enable dst encoding using cashaddr.Nov 14 2017, 21:43

Revision Contents
Changeset List

Path

Size

src/

Makefile.am

4 lines

Makefile.test.include

1 line

7 lines

19 lines

2 lines

8 lines

9 lines

2 lines

26 lines

41 lines

1 line

qt/

addresstablemodel.cpp

2 lines

bitcoinaddressvalidator.cpp

2 lines

coincontroldialog.cpp

1 line

guiutil.cpp

1 line

paymentserver.cpp

2 lines

sendcoinsdialog.cpp

2 lines

signverifymessagedialog.cpp

2 lines

transactiondesc.cpp

2 lines

transactionrecord.cpp

2 lines

walletmodel.cpp

2 lines

rpc/

mining.cpp

2 lines

misc.cpp

2 lines

rawtransaction.cpp

1 line

test/

base58_tests.cpp

8 lines

dstencode_tests.cpp

77 lines

key_tests.cpp

1 line

wallet/

1 line

2 lines

2 lines

2 lines

Diff 1737

View Options

src/Makefile.am

View Options

src/Makefile.test.include

View Options

src/base58.h

View Options

src/base58.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/config.h

View Options

src/config.cpp

View Options

src/core_write.cpp

View Options

src/dstencode.h

View Options

src/dstencode.cpp

View Options

src/init.cpp

View Options

src/qt/addresstablemodel.cpp

View Options

src/qt/bitcoinaddressvalidator.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/guiutil.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/signverifymessagedialog.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionrecord.cpp

View Options

src/qt/walletmodel.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/base58_tests.cpp

View Options

src/test/dstencode_tests.cpp

View Options

src/test/key_tests.cpp

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/wallet.cpp

View Options

Enable decoding and optional encoding of cashaddrClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1737

src/Makefile.am

src/Makefile.test.include

src/base58.h

src/base58.cpp

src/bitcoin-tx.cpp

src/config.h

src/config.cpp

src/core_write.cpp

src/dstencode.h

src/dstencode.cpp

src/init.cpp

src/qt/addresstablemodel.cpp

src/qt/bitcoinaddressvalidator.cpp

src/qt/coincontroldialog.cpp

src/qt/guiutil.cpp

src/qt/paymentserver.cpp

src/qt/sendcoinsdialog.cpp

src/qt/signverifymessagedialog.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.cpp

src/qt/walletmodel.cpp

src/rpc/mining.cpp

src/rpc/misc.cpp

src/rpc/rawtransaction.cpp

src/test/base58_tests.cpp

src/test/dstencode_tests.cpp

src/test/key_tests.cpp

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

src/wallet/wallet.cpp

src/wallet/walletdb.cpp

Enable decoding and optional encoding of cashaddr
ClosedPublic
Actions

Revision Contents
Changeset List